View Issue Details

IDProjectCategoryView StatusLast Update
0003305Slicer4Module Annotationspublic2018-03-02 11:01
Reporternicole Assigned Tolassoan  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.7.0Fixed in VersionSlicer 4.7.0 
Summary0003305: Fiducial projection not working well with dash2d and cross2d
Description

When fiducial projection in 2D is turned on, for the Cross2D and Dash2D glyph types, the scaling is too large.

Steps To Reproduce

Load MRHead sample data.
Put down a fiducial, then in the edit properties window:

  • changed glyph to Cross2D
  • turn on 2D Projection, with outlined behind slice plane on
    Scroll slices to show the projection in front of and behind the fiducial.

In the red 2d viewer in the attached image you can see the large cross made up of two single lines (outlined, fill == off). In the yellow viewer, not projected, there's a solid big cross, and and green you can see that the projected filled cross is a lot smaller on the other side of the plane.

Additional Information

It's in the glyph source 2D, in the not filled case. For the dash at least it's using the scale to make a longer and longer line. I think an outlined box might work but it has to be built out of line segments.
In Markups I might just use the oriented polygonal handle for the projections so that the scale stays the same (there is a scale factor of * 2 in the displayable manager), but the glyph source needs some work so that the outline/not filled case is handled better.

TagsNo tags attached.

Activities

2013-08-21 07:07

 

nicole

nicole

2013-08-27 11:00

administrator   ~0009620

Projection on/off not being saved/restored correctly with system settings.

nicole

nicole

2013-08-27 11:00

administrator   ~0009621

Projections not being deleted on scene close.

nicole

nicole

2013-08-27 11:04

administrator   ~0009622

For now, projection outline is turned off for Cross2D and Dash2D.

lassoan

lassoan

2017-09-27 10:12

developer   ~0015143

Scaling issue is fixed in https://github.com/Slicer/Slicer/commit/a2f6eb518951ef96e9559a006c4934b8b20c976c.

Projections not being deleted on scene close => not reproducible.
Projection on/off not being saved/restored correctly with system settings => nofix, projection settings are saved correctly into and restored from the scene

Issue History

Date Modified Username Field Change
2013-08-21 07:07 nicole New Issue
2013-08-21 07:07 nicole Status new => assigned
2013-08-21 07:07 nicole Assigned To => Lchauvin
2013-08-21 07:07 nicole File Added: AnnotationsCross2DProjectionScaleBug.png
2013-08-23 11:43 nicole Assigned To Lchauvin => nicole
2013-08-27 11:00 nicole Note Added: 0009620
2013-08-27 11:00 nicole Note Added: 0009621
2013-08-27 11:04 nicole Note Added: 0009622
2013-08-27 12:17 nicole Target Version => Slicer 4.4.0
2014-03-07 09:52 pieper Assigned To nicole => Lchauvin
2014-07-29 12:17 jcfr Target Version Slicer 4.4.0 => Slicer 4.5.0-1
2015-11-02 11:27 jcfr Target Version Slicer 4.5.0-1 => Slicer 4.6.0
2016-10-12 14:33 jcfr Target Version Slicer 4.6.0 => Slicer 4.7.0
2017-09-27 10:12 lassoan Assigned To Lchauvin => lassoan
2017-09-27 10:12 lassoan Status assigned => resolved
2017-09-27 10:12 lassoan Resolution open => fixed
2017-09-27 10:12 lassoan Fixed in Version => Slicer 4.7.0
2017-09-27 10:12 lassoan Note Added: 0015143
2018-03-02 11:01 jcfr Status resolved => closed