View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003304Slicer4Module Volumespublic2013-08-20 13:552015-11-02 08:51
Reporterpinter Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.5.0-1Fixed in VersionSlicer 4.5.0-1 
Summary0003304: Make "regular scalar volume" to/from labelmap conversions easier
Description

If I set the LabelMap attribute of a scalar volume, it does not change the related display node, and it has undesired effects (color node dropped, bad visualization).
The proper way of doing it is implemented in vtkSlicerVolumesLogic::SetVolumeAsLabelMap and in qMRMLVolumeInfoWidget::setLabelMap (identical code there), but cannot be accessed without having the instance of vtkSlicerVolumesLogic.

I propose making the SetVolumeAsLabelMap function static (it doesn't use the this pointer in any way as I saw).
Also there are other duplicated pieces of code between these two classes, see the comments about duplication.

TagsNo tags attached.

Activities

jcfr

jcfr

2014-03-06 12:41

administrator   ~0011284

Fixed in topic https://github.com/jcfr/Slicer/tree/3304-easier-conversion-from-to-label-map

Let me know what you think

We will also have to check with the other developer to coordinate the integration since it may break compilation of some code ...

pinter

pinter

2014-03-06 23:39

developer   ~0011307

Looks good after a quick glance.
However, I'm travelling and cannot try it now. As far as I saw this issue was only about making it static. If the other concerns of yours are resolved, then you can close this.

Thanks!
pieper

pieper

2014-09-06 05:38

administrator   ~0012467

Should this topic be integrated for the release? It seems not crucial to me, so it could be re-targeted to the next patch release.
pinter

pinter

2014-09-06 07:32

developer   ~0012468

No, it is definitely not crucial. Thanks!
jcfr

jcfr

2015-11-02 08:45

administrator   ~0013486

@Csaba: Given the recent development associated with the Segmentations module, could we close this issue ?
pinter

pinter

2015-11-02 08:47

developer   ~0013487

Yes, I think this is an obsolete issue. Thanks, Jc!
pinter

pinter

2015-11-02 08:51

developer   ~0013488

Instead of the flag Slicer now uses a different class for labelmaps (vtkMRMLLabelMapVolumeNode), so there is no display node correspondence problems any more.
Svalar volume to Labelmap volume conversion is supported in CastScalarVolume module, so this issue can be closed

Issue History

Date Modified Username Field Change
2013-08-20 13:55 pinter New Issue
2014-03-06 12:39 jcfr Status new => assigned
2014-03-06 12:39 jcfr Assigned To => jcfr
2014-03-06 12:39 jcfr Target Version => Slicer 4.4.0
2014-03-06 12:41 jcfr Note Added: 0011284
2014-03-06 12:41 jcfr Status assigned => feedback
2014-03-06 23:39 pinter Note Added: 0011307
2014-09-06 05:38 pieper Note Added: 0012467
2014-09-06 07:32 pinter Note Added: 0012468
2014-09-06 07:45 pieper Target Version Slicer 4.4.0 => Slicer 4.5.0-1
2015-11-02 08:45 jcfr Note Added: 0013486
2015-11-02 08:47 pinter Note Added: 0013487
2015-11-02 08:50 jcfr Status feedback => resolved
2015-11-02 08:50 jcfr Fixed in Version => Slicer 4.5.0-1
2015-11-02 08:50 jcfr Resolution open => no change required
2015-11-02 08:51 pinter Note Added: 0013488
2015-11-02 08:51 pinter Status resolved => closed
2015-11-02 08:51 pinter Resolution no change required => fixed