0003296: Saving a scene with fiducials - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0003296	Slicer4	Module Annotations	public	2013-08-14 09:42	2017-06-07 23:27

Reporter	spujol	Assigned To	nicole
Priority	high	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	Slicer 4.2.2-1
Target Version	Slicer 4.3.1	Fixed in Version	Slicer 4.3.1

Summary	0003296: Saving a scene with fiducials
Description	When I try to re-save a scene that contains a series of fiducials, all the fiducials get checked by default whereas they have not been modified in the 'Save Scene and Unsaved Data' window. As a consequence, I have to check and uncheck all the elements of the scene, and select manually what I want to actually write on disk.
Additional Information	MacOSX 10.8 Slicer nightly build of 08-13-2013
Tags	No tags attached.

pieper 2013-08-14 13:41 administrator ~0009471	I couldn't replicate this. Here's what I saw: start slicer add fiducials click save all fiducials are marked as changed and need to be saved (correct) save scene close scene reload saved scene pick save again, nothing is marked as needing to be saved (correct) But: move a fiducial pick save, nothing is marked as needing to be saved (incorrect)

nicole 2013-09-03 12:16 administrator ~0009859	I saw a problem related to this issue when opening an mrml scene that had Annotation fiducials in it, and the Markups module converts them. On save, the Annotation nodes are still appearing in the Save Data dialog.

nicole 2013-09-10 08:19 administrator ~0009921	Turns out that it was due to the change Alex made to save data that only appears in scene views, the scene I was testing had scene views with non converted Annotation fiducials. Also found a typo in the selection node XML parsing (was using an old tag) that lost the active place node id. Added in looking for end scene restore events in the GUI so that it will be updated properly even if there wasn't an active place node id in the saved scene view. Fixed in svn 22422 and 22423: http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22422 http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22423

jcfr 2014-03-06 05:00 administrator ~0010868	Closing resolved issues that have not been updated in more than 3 months

Slicer: 2145-support-for-installing-extension-from-file 9b7e0253 2013-09-10 12:11:17 naucoin Details Diff	BUG: fixing a Markups merge error for the active place node The more general activePlaceNodeID is to be used instead of a specific Annotations or Markups variable name. Fixed while working on issue 0003296 for the 4.3.1 release. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22422 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Libs/MRML/Core/vtkMRMLSelectionNode.cxx		Diff File
	mod - Libs/MRML/Core/vtkMRMLSelectionNode.h		Diff File
Slicer: 2145-support-for-installing-extension-from-file 85233d50 2013-09-10 12:18:02 naucoin Details Diff	BUG: Fix missing conversion of fiducials in scene views Annotation fiducials in scene view scenes were coming up as unsaved in the Save data dialog when loaded from a scene with scene views where only the current scene had had it's fiducials conerted to markups. This was due to the change Alex made to save data that only appears in scene views, so added in iterating over the current scene and scene views when converting fiducials. Added in looking for end scene restore events in the GUI so that it will be updated properly even if there wasn't an active place node id in the saved scene view. Expanded the AddNewFiducialNode method to support adding to a passed in scene so that the converted markups can be added to the scene view scenes. Issue 0003296 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22423 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.cxx		Diff File
	mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.h		Diff File
	mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx		Diff File
	mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h		Diff File

Date Modified	Username	Field	Change
2013-08-14 09:42	spujol	New Issue
2013-08-14 09:42	spujol	Status	new => assigned
2013-08-14 09:42	spujol	Assigned To	=> nicole
2013-08-14 13:41	pieper	Note Added: 0009471
2013-09-03 12:16	nicole	Note Added: 0009859
2013-09-03 12:16	nicole	Target Version	=> Slicer 4.3.1
2013-09-10 08:19	nicole	Note Added: 0009921
2013-09-10 08:19	nicole	Status	assigned => resolved
2013-09-10 08:19	nicole	Fixed in Version	=> Slicer 4.3.1
2013-09-10 08:19	nicole	Resolution	open => fixed
2014-03-06 05:00	jcfr	Note Added: 0010868
2014-03-06 05:01	jcfr	Status	resolved => closed
2017-06-07 23:27		Changeset attached	=> Slicer 2145-support-for-installing-extension-from-file 85233d50
2017-06-07 23:27		Changeset attached	=> Slicer 2145-support-for-installing-extension-from-file 9b7e0253