View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003290 | Slicer4 | Core: CLI infrastructure | public | 2013-08-12 03:51 | 2013-09-02 08:54 |
Reporter | blowekamp | Assigned To | alexy | ||
Priority | high | Severity | block | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0003290: Can not pass Region to CLI | ||||
Description | I am trying to create a CLI which optionally takes on ROI as input. Based on the doc[1] and using the MultiResolutionAffineRegistration as an example[2], I am using the following XML description: <region multiple="false" coordinateSystem="lps"> For either mine or the existing CLI, I can't seem to find an ROI, or ROI list/hierarchy in the parameter pull down. Indifferent to multiple attributes in the region tag, in the pull down menu I am getting a selection of Rename/Create/Delete ROIList. Upon creating the node type is a vtkMRMLROIListNode defaulting to the name "Image ROI". When I create a new ROI node, from the toolbar mouse tool, it creates a region, under a vtkMRMLAnnotationHierachyNode, but it's call "ROI List". I am not sure what the expected behavior of this is and if I am just using it wrong or if these are bugs. In summary I have two issues: 1) the multiple attribute of region didn't have the of searching for a individual ROI node My initial thought is that bit of code didn't get updated at some point. And that a fairly simple change to the code to something similar to what I did in SimpleFilters for Fiducial points [3],4] would need to be done here. [1] http://www.slicer.org/slicerWiki/index.php/Slicer3:Execution_Model_Documentation | ||||
Additional Information | I hacked together a little fix in progress here: It's a hack but should allow me to continue development of my cli, locally. It does show what I was on the right track with the needed changes of classes :) | ||||
Tags | No tags attached. | ||||
Has any progress been made on this issue? It very important for my IASEM project to have this capability? I am going to work on this patch this afternoon to get it into a usable patch if I haven't heard that progress as been made. Get we get this fix scheduled for the upcoming release? |
|
Hi Bradley, |
|
This certainly looks like it's expecting a ROI defined by 6 floats to me: What did you see that makes you think otherwise? I need a ROI passed to my CLI. This is very important for the future of my IASEM module and this development path. I need to be able to define a ROI, so that I don't have to load up the entire data set. If you need the module as an example I could push it to git up as a topic for my extension. Thanks. |
|
Fixed handling of ROIs and Annotation nodes in CLI modules. Added ROITest module in Modules/CLI. |
|
I tries out the patch against my CLI module and worked as expected. Thank you SO much for getting this in before the release! The who choosing node which contains multiple items, is still odd and not intuitive, and I expect it to be problematic to my users. However, this is consistent with how the marker fiducials are done. This second issue may be more of a design thing then a bug. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2013-08-12 03:51 | blowekamp | New Issue | |
2013-08-12 03:51 | blowekamp | Status | new => assigned |
2013-08-12 03:51 | blowekamp | Assigned To | => millerjv |
2013-08-13 12:13 | pieper | Assigned To | millerjv => alexy |
2013-08-27 04:48 | blowekamp | Note Added: 0009608 | |
2013-08-27 11:30 | pieper | Target Version | => Slicer 4.3.0 |
2013-08-30 11:30 | alexy | Note Added: 0009734 | |
2013-08-30 11:41 | blowekamp | Note Added: 0009735 | |
2013-08-31 04:48 | alexy | Note Added: 0009763 | |
2013-08-31 04:48 | alexy | Status | assigned => resolved |
2013-08-31 04:48 | alexy | Resolution | open => fixed |
2013-09-02 08:54 | blowekamp | Note Added: 0009767 | |
2013-09-02 08:54 | blowekamp | Status | resolved => closed |
2013-09-02 08:54 | blowekamp | Fixed in Version | => Slicer 4.3.0 |