View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003284Slicer4Module DICOMpublic2013-08-09 15:012013-09-03 03:44
Reporterfedorov Assigned Topieper  
PrioritynormalSeveritytrivialReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003284: Assign user-defined name on loadable load
Description

Editing the loadable name in DICOM table widget does not lead to that name being used on loading that loadable.

TagsNo tags attached.

Activities

mehrtash

mehrtash

2013-08-25 10:31

developer   ~0009588

Topic fixed and pushed to: https://github.com/mehrtash/Slicer/tree/3284-assign-user-defined-name-on-loadable-loads-DICOM
pieper

pieper

2013-08-26 08:06

administrator   ~0009589

Fixed in r22329
pieper

pieper

2013-08-26 08:18

administrator   ~0009590

r22330 disables editing of the other columns.
fedorov

fedorov

2013-08-26 12:59

developer   ~0009601

Steve, warning field is still editable when warning is not initialized by the loadable, because the flags are never set:

https://github.com/Slicer/Slicer/blob/c99f6ba17a057743cc02a96efe41eae57df581e1/Modules/Scripted/DICOM/DICOMLib/DICOMWidgets.py#L360-L362

Otherwise the issue is fixed, let me know if I should close it.
jcfr

jcfr

2013-09-02 19:21

administrator   ~0009801

Comment indicates that the issue has been resolved. Additionally, commit r22330 [1] take care of setting the flag (as reported in note 9601?). Please, create a specific issue if the "warning field" is still editable. Thanks

[1] http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Modules/Scripted/DICOM/DICOMLib/DICOMWidgets.py?r1=22330&r2=22329&pathrev=22330
fedorov

fedorov

2013-09-03 03:44

developer   ~0009816

fixed in r22390

Issue History

Date Modified Username Field Change
2013-08-09 15:01 fedorov New Issue
2013-08-09 15:01 fedorov Status new => assigned
2013-08-09 15:01 fedorov Assigned To => pieper
2013-08-25 10:31 mehrtash Note Added: 0009588
2013-08-26 08:06 pieper Note Added: 0009589
2013-08-26 08:06 pieper Status assigned => resolved
2013-08-26 08:06 pieper Fixed in Version => Slicer 4.3.0
2013-08-26 08:06 pieper Resolution open => fixed
2013-08-26 08:18 pieper Note Added: 0009590
2013-08-26 08:43 pieper Target Version => Slicer 4.3.0
2013-08-26 12:59 fedorov Note Added: 0009601
2013-08-26 12:59 fedorov Status resolved => feedback
2013-08-26 12:59 fedorov Resolution fixed => reopened
2013-09-02 19:21 jcfr Note Added: 0009801
2013-09-02 19:21 jcfr Status feedback => resolved
2013-09-02 19:21 jcfr Resolution reopened => fixed
2013-09-03 03:44 fedorov Note Added: 0009816
2013-09-03 03:44 fedorov Status resolved => closed