View Issue Details

IDProjectCategoryView StatusLast Update
0003248Slicer4Module OpenIGTLinkIFpublic2017-06-07 23:27
Reportertokuda Assigned Tojcfr  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003248: Add pointlist support classes
Description

The current OpenIGTLinkIF does not support POINT message type.

TagsNo tags attached.

Relationships

related to 0003077 closedjcfr Fix warning related to qSlicerOpenIGTLinkIFModuleWidget::setMRMLScene 

Activities

tokuda

tokuda

2013-07-25 20:34

developer   ~0009204

Isaiah Norton has implemented the feature:

https://github.com/openigtlink/OpenIGTLinkIF/commit/d7ac45c99d3e68fa4f104c950f0353f728c9270d

jcfr

jcfr

2013-07-26 06:46

administrator   ~0009210

Last edited: 2013-07-26 06:46

Since this issue hasn't been targeted for 4.3, could you confirm that it compiled and worked on MacOSX, Windows and Linux ?

jcfr

jcfr

2013-07-26 06:59

administrator   ~0009211

Reminder sent to: inorton

Hi Isaiah,

Let me know what you think. Could you confirm that this new classes have been compiled on MacOSX/Linux/Windows .. and that it doesn't break / change the current way of using the module ?

inorton

inorton

2013-07-26 11:11

developer   ~0009217

Hi Jc,
It has been tested on Windows by me and MacOSX by Junichi. I don't have a linux build available right now but it "should" be fine... I can test on linux this weekend.

tokuda

tokuda

2013-07-26 11:12

developer   ~0009218

I believe Isaiah developed this module on Windows, but I need Isaiah's confirmation. I could compile it on Mac OS X and Linux. The code Isaiah added does not affects the current way of using the module.

inorton

inorton

2013-07-26 11:14

developer   ~0009219

Yes, developed on Windows. The gui part is implemented in
https://github.com/SlicerIGT/OpenIGTLinkRemote/pull/8

jcfr

jcfr

2013-07-26 14:04

administrator   ~0009224

Thanks for your comments.

Fixed in r22242
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22242

jcfr

jcfr

2013-07-29 08:48

administrator   ~0009241

From Isaiah:

"Thanks @tokjun @jcfr just tested (linux build) against clinical system and it worked well."

See https://github.com/openigtlink/OpenIGTLinkIF/pull/8#issuecomment-21724245

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014622

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file d4e6c0a2

2013-07-26 18:02:14

jcfr

Details Diff
ENH: Add pointlist support to OpenIGTLinkIF and fix warnings

Fixes 0003077
Fixes 0003248

Co-authored-by: Isaiah Norton <inorton@bwh.harvard.edu>

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22242 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_OpenIGTLinkIF.cmake Diff File

Issue History

Date Modified Username Field Change
2013-07-25 20:31 tokuda New Issue
2013-07-25 20:31 tokuda Status new => assigned
2013-07-25 20:31 tokuda Assigned To => tokuda
2013-07-25 20:34 tokuda Note Added: 0009204
2013-07-25 20:34 tokuda Status assigned => resolved
2013-07-25 20:34 tokuda Resolution open => fixed
2013-07-26 06:46 jcfr Note Added: 0009210
2013-07-26 06:46 jcfr Note Edited: 0009210
2013-07-26 06:59 jcfr Note Added: 0009211
2013-07-26 07:00 jcfr Relationship added related to 0003077
2013-07-26 11:11 inorton Note Added: 0009217
2013-07-26 11:12 tokuda Note Added: 0009218
2013-07-26 11:14 inorton Note Added: 0009219
2013-07-26 14:04 jcfr Note Added: 0009224
2013-07-29 08:48 jcfr Note Added: 0009241
2013-07-29 08:48 jcfr Status resolved => closed
2013-07-29 08:48 jcfr Fixed in Version => Slicer 4.3.0
2013-07-29 08:49 jcfr Target Version => Slicer 4.3.0
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file d4e6c0a2
2017-06-07 23:27 jcfr Note Added: 0014622
2017-06-07 23:27 jcfr Assigned To tokuda => jcfr