View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003204Slicer4Core: GUIpublic2013-07-03 06:442017-06-07 23:27
Reporterfedorov Assigned Tomillerjv  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003204: Cross hair is not initialized as instructed
Description

Every time I select "Small basic" in cross hair selector in the toolbar, I instead get "Basic" crosshair. After I click "Small basic" for the second time, it becomes "Small basic".

TagsNo tags attached.

Activities

jcfr

jcfr

2013-08-02 08:16

administrator   ~0009357

@Jim: Is it something you could investigate in the coming week ?
millerjv

millerjv

2013-08-02 10:14

developer   ~0009365

Fixed in r22255

BUG: 0003204. Crosshair selection overridden by cross hair toggle.

This addresses a bug involving toggling and switching crosshairs:

1. If crosshair display is in mode "A"
2. Crosshair it toggled off in the GUI
3. Crosshair is set to mode "B" in the GUI

then the cross would display as "A" and not as "B".

The issue is in the order in which the "selection" signals are raised
relative to the "toggle" signals. When switching from off to any mode
the selection signals are raised first and then the toggled signals.

This ordering was aligned with the order in which the crosshair
node was modified relative to how the mode was cached (to set up for
toggling).

Caching the mode before setting mode addressed the issue.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22255 3bd1e089-480b-0410-8df
fedorov

fedorov

2013-08-03 04:57

developer   ~0009375

Confirmed - thank you!

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file c2bcb028

2013-08-02 14:13:42

millerjv

Details Diff 		BUG: 0003204. Crosshair selection overridden by cross hair toggle.

This addresses a bug involving toggling and switching crosshairs:

1. If crosshair display is in mode "A"
2. Crosshair it toggled off in the GUI
3. Crosshair is set to mode "B" in the GUI

then the cross would display as "A" and not as "B".

The issue is in the order in which the "selection" signals are raised
relative to the "toggle" signals. When switching from off to any mode
the selection signals are raised first and then the toggled signals.

This ordering was aligned with the order in which the crosshair
node was modified relative to how the mode was cached (to set up for
toggling).

Caching the mode before setting mode addressed the issue.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22255 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerViewersToolBar.cxx Diff File

Issue History

Date Modified Username Field Change
2013-07-03 06:44 fedorov New Issue
2013-07-03 06:44 fedorov Status new => assigned
2013-07-03 06:44 fedorov Assigned To => kikinis
2013-07-03 09:53 kikinis Assigned To kikinis => jcfr
2013-08-02 08:16 jcfr Assigned To jcfr => millerjv
2013-08-02 08:16 jcfr Note Added: 0009357
2013-08-02 10:14 millerjv Note Added: 0009365
2013-08-02 10:14 millerjv Status assigned => resolved
2013-08-02 10:14 millerjv Resolution open => fixed
2013-08-02 21:45 jcfr Fixed in Version => Slicer 4.3.0
2013-08-02 21:45 jcfr Target Version => Slicer 4.3.0
2013-08-03 04:57 fedorov Note Added: 0009375
2013-08-03 04:57 fedorov Status resolved => closed
2017-06-07 23:27 millerjv Changeset attached => Slicer 2145-support-for-installing-extension-from-file c2bcb028