|
|
test.bat (9,925 bytes)
|
|
|
|
To reproduce the problem there is no need to build Slicer or SimpleITK or anything, just edit the attached test.bat with the correct swig.exe path on your computer then run it. It will give the error:
swig error : Unrecognized option -F:/S4R/ITKv4/Modules/IO/ImageBase/include |
|
|
|
The problem is reproducible without on VS2008 with a simple console application:
int main(int argc, char **argv)
{
for (int i=0; i<argc; i++)
{
std::puts(argv[i]);
}
return 0;
}
Run this app with the attached batch file. The output is:
...
-IF:/S4R/zlib-install/include
-IF:/S4R/ITKv4-build/Modules/ThirdParty/ZLIB/src
-IF:/S4R/ITKv4/Modules/Core/Mesh/include
-F:/S4R/ITKv4/Modules/IO/ImageBase/include
-IF:/S4R/ITKv4-build/Modules/IO/ImageBase
-IF:/S4R/ITKv4/Modules/Filtering/ImageCompose/include
-IF:/S4R/ITKv4/Modules/Filtering/AnisotropicSmoothing/include
...
Note the missing 'I' character in the ...IO/ImageBase/include line.
So, it seems to be a Windows issue. One solution is to shorten the command line path so that it doesn't reach the 8k limit. |
|
|
|
From: Sharp, Gregory C. [mailto:GCSHARP@partners.org]
Sent: June 11, 2013 7:22 PM
To: 'Andras Lasso'; 'Bradley Lowekamp'
Cc: 'Slicer devel'
Subject: RE: [slicer-devel] SimpleITK compiling with shared libraries ( was: running on mac nightly with hack… and other )
We encountered this problem using ITK4 with nvcc.
There are several workarounds one can imagine
- If application allows command line parameters as file, use it
- Write small program to call CreateProcesss(), which allows 32k command line
- Remove unnecessary ITK include paths
We chose the last option. As you know, cmake can't set
include directories on a target-specific basis. So we created
special subdirectories for spawning the nvcc process.
This allows include path to be customized. |
|
|
|
from: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
to: Andras Lasso <lasso@cs.queensu.ca>
cc: "Sharp, Gregory C." <GCSHARP@partners.org>,
Bradley Lowekamp <blowekamp@mail.nih.gov>,
Slicer devel <slicer-devel@bwh.harvard.edu>
date: Wed, Jun 12, 2013 at 8:56 AM
subject: Re: [slicer-devel] SimpleITK compiling with shared libraries ( was: running on mac nightly with hack… and other )
Hi Folks,
The latest version of CMake now include a feature allowing to specify target usage requirements. It means it is now possible to associate a list of include directories for each targets. Moving forward, this is something I would like to setup within Slicer.
See http://www.kitware.com/blog/home/post/462 and http://community.kde.org/Frameworks/Epics/CMake_target_usage_requirements |
|
|
|
This particular issue can be resolved in SimpleITK by the removal of "include(${ITK_USE_FILE})" in SimpleITK/Wrapping/CMakeLists.txt. Here is the issue in the SimpleITK bug tracker:
https://issues.itk.org/jira/browse/SIMPLEITK-408
As another possible long term solution to this problem. ITK's modular structure could be take advantage of , each library/module could find and include the ITK project, and specify the components needed. This would only added the required include paths to the compilation lines. |
|
|
|
A topic has been merged into SimpleITK's next brach to address this issue:
https://github.com/SimpleITK/SimpleITK/commit/0ad83f82ce129d08f4271655120a9a251a82f2dc
it will be merged into the release and master branch after successful nightly testing. |
|
|
|
thanks! |
|
|
|
This patch should address this issue:
https://github.com/blowekamp/Slicer/tree/SimpleITKVersionUpdate |
|
|
|
The version of SimpleITK in Slicer has been updated to address this bug. It'd be great if the original reporter could confirm. |
|
|
|
Closing resolved issues that have not been updated in more than 3 months |
|
|
|
The changes might have reduced the probability of the issue occurring, but unfortunately, the problem still has not been resolved, see an error report below.
From: slicer-devel-bounces@bwh.harvard.edu [mailto:slicer-devel-bounces@bwh.harvard.edu] On Behalf Of yao2049@gmail.com
Sent: May 19, 2014 7:46 AM
To: slicer-devel@bwh.harvard.edu
Subject: [slicer-devel] Slicer Nightly Build Error while Build CTK with error
hello
i’m pretty new to here and has problems came up when building the slicer new nightly version… i think i was very regarding the build wiki page
the build error log lays below:
PythonQt Wrapping - Generating generated_cpp/org_commontk_CTKWidgets/org_commontk_CTKWidgets_init.cpp
Qt: Untested Windows version 6.2 detected!
Traceback (most recent call last):
File "E:/Kitware/3DSlicer/SlicerBuildDebug/CTK/CMake/ctkWrapPythonQt.py", line 225, in
ctk_wrap_pythonqt(options.target, options.namespace, options.output_dir, args, options.extra_verbose)
File "E:/Kitware/3DSlicer/SlicerBuildDebug/CTK/CMake/ctkWrapPythonQt.py", line 79, in ctk_wrap_pythonqt
with open(input_file) as f:
IOError: [Errno 2] No such file or directory: 'E:/Kitare/3DSlicer/SlicerBuildDebug/CTK/Libs/Widgets/ctkPopupWidgetEventTranslator.h'
Project : error PRJ0019: A tool returned an error code from "PythonQt Wrapping - Generating generated_cpp/org_commontk_CTKWidgets/org_commontk_CTKWidgets_init.cpp"
while the true directory was
'E:/Kitware/3DSlicer/SlicerBuildDebug……
i was wonder why it will be automatically cut a letter… and i never write it by hand the project is automatical constructed by cmake.
and how can i build successfully?
many thanks
YAO JIALIANG
CCI OF INFORMATION ENGINEERING
ZJUT |
|
|
|
ITK continues to grow and add more modules. When build against ITK's build tree this adds more path to the include and linker paths. However when ITK is installed it's a flat tree with significantly fewer number of required paths. |
|
|
|
It seems that the issue is not specific to SWIG, for example:
http://typescript.codeplex.com/workitem/597
and
https://issues.apache.org/jira/browse/PROTON-249 |
|
|
|
I have good news! I had a look at this path length issue again, and it seems that there may be a clean and definitive solution.
=> Problem
Maximum command line length on Windows for cmd.exe is 8192 (32767 for CreateProcess). If you pass longer than 8192 then the behavior is undefined (actually, 8192th character is removed and the rest of the string is passed). CMake passes parameters to the compiler or linker using a parameter file (instead of command-line arguments) when it finds that the command-line would be too long.
However, CMake cannot implement this mechanism for custom commands, that's up to the developer who adds a custom command!
=> Example
The particular issue that caused build error for Jim is due to a custom command defined in ctkMacroWrapPythonQt.cmake:
add_custom_command(
OUTPUT
${wrapper_init_cpp_filename}
${wrapper_h_filename}
DEPENDS
${SOURCES_TO_WRAP}
${CTK_CMAKE_DIR}/ctkWrapPythonQt.py
COMMAND ${PYTHON_EXECUTABLE} ${CTK_CMAKE_DIR}/ctkWrapPythonQt.py
--target=${TARGET}
--namespace=${WRAPPING_NAMESPACE}
--output-dir=${CMAKE_CURRENT_BINARY_DIR}/${wrap_int_dir} ${extra_args}
${SOURCES_TO_WRAP}
COMMENT "PythonQt Wrapping - Generating ${wrapper_init_cpp_filename}"
VERBATIM
)
The ${SOURCES_TO_WRAP} variable can contain hundreds of full paths, which of course can easily grow over 8192. For example, a command like this can be generated (see in the generated CTKWidgetsPythonQt.vcxproj file):
<CustomBuild Include="..\..\CMakeFiles\d4e9ed124a08aa4e815590aff2c25a3c\org_commontk_CTKWidgets_init.cpp.rule">
<Message Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">PythonQt Wrapping - Generating generated_cpp/org_commontk_CTKWidgets/org_commontk_CTKWidgets_init.cpp</Message>
<Command Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">setlocal
C:\S4D\python-install\bin\SlicerPython.exe C:/S4D/CTK/CMake/ctkWrapPythonQt.py --target=CTKWidgets --namespace=org.commontk --output-dir=C:/S4D/CTK-build/CTK-build/Libs/Widgets/generated_cpp/org_commontk_CTKWidgets/ C:/S4D/CTK/Libs/Widgets/ctkActionsWidget.h C:/S4D/CTK/Libs/Widgets/ctkAddRemoveComboBox.h C:/S4D/CTK/Libs/Widgets/ctkAxesWidget.h C:/S4D/CTK/Libs/Widgets/ctkBasePopupWidget.h C:/S4D/CTK/Libs/Widgets/ctkButtonGroup.h C:/S4D/CTK/Libs/Widgets/ctkCheckableComboBox.h C:/S4D/CTK/Libs/Widgets/ctkCheckableHeaderView.h C:/S4D/CTK/Libs/Widgets/ctkCheckableModelHelper.h C:/S4D/CTK/Libs/Widgets/ctkCheckBox.h C:/S4D/CTK/Libs/Widgets/ctkCheckBoxPixmaps.h C:/S4D/CTK/Libs/Widgets/ctkCheckablePushButton.h C:/S4D/CTK/Libs/Widgets/ctkComboBox.h C:/S4D/CTK/Libs/Widgets/ctkCompleter.h C:/S4D/CTK/Libs/Widgets/ctkCollapsibleButton.h C:/S4D/CTK/Libs/Widgets/ctkCollapsibleGroupBox.h C:/S4D/CTK/Libs/Widgets/ctkColorDialog.h C:/S4D/CTK/Libs/Widgets/ctkColorPickerButton.h C:/S4D/CTK/Libs/Widgets/ctkConsole.h C:/S4D/CTK/Libs/Widgets/ctkCoordinatesWidget.h C:/S4D/CTK/Libs/Widgets/ctkCrosshairLabel.h C:/S4D/CTK/Libs/Widgets/ctkDateRangeWidget.h C:/S4D/CTK/Libs/Widgets/ctkDirectoryButton.h
…
many many more similar lines here
…
C:/S4D/CTK/Libs/Widgets/ctkMenuComboBoxEventTranslator.h C:/S4D/CTK/Libs/Widgets/ctkPathLineEditEventPlayer.h C:/S4D/CTK/Libs/Widgets/ctkPathLineEditEventTranslator.h C:/S4D/CTK/Libs/Widgets/ctkPopupWidgetEventPlayer.h C:/S4D/CTK/Libs/Widgets/ctkPopupWidgetEventTranslator.h C:/S4D/CTK/Libs/Widgets/ctkRangeSliderEventPlayer.h C:/S4D/CTK/Libs/Widgets/ctkRangeSliderEventTranslator.h C:/S4D/CTK/Libs/Widgets/ctkTreeComboBoxEventPlayer.h C:/S4D/CTK/Libs/Widgets/ctkTreeComboBoxEventTranslator.h
if %errorlevel% neq 0 goto :cmEnd
:cmEnd
endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone
:cmErrorLevel
exit /b %1
:cmDone
if %errorlevel% neq 0 goto :VCEnd</Command>
=> Solution
Fortunately, there is a nice, clean solution to this issue: pass the ${SOURCES_TO_WRAP} list to the python script through a file, not through command-line.
There may be other instances where long lists are attempted to pass through command-line parameters, so fixing this issue may not allow us to use arbitrarily long paths yet, but if we fix these issues one by one as they pop up, finally we may end up fixing all of them. |
|
|
|
This is no longer a SimpleITK issue. I believe the original issue was resolved and closed. The original title and description are not longer accurate. The latest report on an issue (2014-05-19 04:18) with CTK issues should be separate ticket. |
|
|
|
I agree that the remaining is not specific to SimpleITK and there is already a ticket in CTK's bugtracker (https://github.com/commontk/CTK/issues/525), so this issue can be closed.
The current workaround is to reduce build path length to a few characters. At some point, as more and more code is added, it will not possible to have a build path short enough to be able to build Slicer. At that point, either it has to be made sure that no include directory list is attempted to passed through command line (modify ctkWrapPythonQt and similar CMake scripts) or VTK/ITK should be fixed to not require hundreds of include directories (this would be much nicer). |
|
