View Issue Details

IDProjectCategoryView StatusLast Update
0003086Slicer4Core: Base Codepublic2017-06-07 23:27
Reporterjohan.andruejol Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003086: Hook fails on windows
Description

I don't know if I am doing something wrong but I can't commit my changes, the hook fails with the following error message (see screenshot).

TagsNo tags attached.

Activities

2013-04-25 11:31

 

Capture.PNG (116,014 bytes)
Capture.PNG (116,014 bytes)
sankhesh

sankhesh

2013-04-25 12:53

developer   ~0008493

Last edited: 2013-04-25 13:08

The error is because Git bash/GUI uses an old version of BASH.
This should fix it -

diff --git a/commit-msg b/commit-msg
index fd6b1ce..3995eac 100755
--- a/commit-msg
+++ b/commit-msg
@@ -70,9 +70,12 @@ msg_first() {
printErrorAndExit 'The first line may not have leading or trailing space:
['"$line"']'
fi

  • if [[ ( "$(echo "$line" | cut -c1-4)" =~ (BUG:|ENH:)$ ) ||
  • ( "$(echo "$line" | cut -c1-5)" =~ (COMP:|PERF:)$ ) ||
  • ( "$(echo "$line" | cut -c1-6)" =~ (STYLE:)$ ) ]]; then
  • firstSixLetters=$(echo "$line" | cut -c1-6)
  • if [ "${firstSixLetters:0:4}" == "BUG:" -o \
  • "${firstSixLetters:0:4}" == "ENH:" -o \
  • "${firstSixLetters:0:5}" == "COMP:" -o \
  • "${firstSixLetters:0:5}" == "PERF:" -o \
  • "$firstSixLetters" == "STYLE:" ]; then

    first line okay

    state=second
    else

And then, incrementing SetupForDevelopment_VERSION would notify developers to update their version of hooks.

jcfr

jcfr

2013-04-25 13:13

administrator   ~0008495

Thanks Sankhesh.

@Johan: Could you locally try the change suggested by Sankhesh ?

johan.andruejol

johan.andruejol

2013-04-25 13:19

manager   ~0008496

It works ! Thanks Sankhesh !

jcfr

jcfr

2013-04-26 13:52

administrator   ~0008522

Fixed in r21946
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21946

jcfr

jcfr

2014-03-06 04:53

administrator   ~0010786

Closing resolved issues that have not been updated in more than 3 months

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014645

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 518e1f22

2013-04-26 17:52:30

jcfr

Details Diff
BUG: Fix hook error specific Git bash/GUI using an old version of BASH.

Thanks Sankhesk for his help.

See http://www.na-mic.org/Bug/view.php?id=3086
Fixes 0003086

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21946 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Utilities/SetupForDevelopment.sh Diff File

Issue History

Date Modified Username Field Change
2013-04-25 11:31 johan.andruejol New Issue
2013-04-25 11:31 johan.andruejol Status new => assigned
2013-04-25 11:31 johan.andruejol Assigned To => jcfr
2013-04-25 11:31 johan.andruejol File Added: Capture.PNG
2013-04-25 12:52 sankhesh Assigned To jcfr => sankhesh
2013-04-25 12:53 sankhesh Note Added: 0008493
2013-04-25 13:08 sankhesh Note Edited: 0008493
2013-04-25 13:12 sankhesh Assigned To sankhesh => jcfr
2013-04-25 13:13 jcfr Note Added: 0008495
2013-04-25 13:19 johan.andruejol Note Added: 0008496
2013-04-26 13:52 jcfr Note Added: 0008522
2013-04-26 13:52 jcfr Status assigned => resolved
2013-04-26 13:52 jcfr Fixed in Version => Slicer 4.3.0
2013-04-26 13:52 jcfr Resolution open => fixed
2014-03-06 04:53 jcfr Note Added: 0010786
2014-03-06 04:54 jcfr Status resolved => closed
2014-03-06 06:16 jcfr Target Version => Slicer 4.3.0
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 518e1f22
2017-06-07 23:27 jcfr Note Added: 0014645