View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003067Slicer4Module EMSegmentpublic2013-04-16 09:302014-03-06 06:15
Reporterjcfr Assigned Topohl  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003067: EMSegment - Fix EMSegment/AMF/vtkImagePropagateDist2.cxx warnings
Description

/home/jchris/Projects/Slicer-AHM-Superbuild-Release/EMSegment/AMF/vtkImagePropagateDist2.cxx: In member function ‘void vtkImagePropagateDist2::IsoSurfDist3D()’:
/home/jchris/Projects/Slicer-AHM-Superbuild-Release/EMSegment/AMF/vtkImagePropagateDist2.cxx:373: warning: ‘Grad[2]’ may be used uninitialized in this function [-Wuninitialized]
/home/jchris/Projects/Slicer-AHM-Superbuild-Release/EMSegment/AMF/vtkImagePropagateDist2.cxx:373: warning: ‘Grad[1]’ may be used uninitialized in this function [-Wuninitialized]
/home/jchris/Projects/Slicer-AHM-Superbuild-Release/EMSegment/AMF/vtkImagePropagateDist2.cxx:373: warning: ‘Grad[0]’ may be used uninitialized in this function [-Wuninitialized]

TagsNo tags attached.

Activities

pohl

pohl

2013-04-17 11:54

developer   ~0008425

Last edited: 2013-04-17 12:04

Fixed in EMSegment. See r17025 [1]
Associated Slicer commit is r21894 [2]

[1] http://viewvc.slicer.org/viewvc.cgi/Slicer3?view=revision&revision=17025
[2] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21894
jcfr

jcfr

2013-04-17 12:01

administrator   ~0008426

Thanks :)

Note for later:

(1) In your Slicer commit message. Reference issue using "#XXXXX"
See http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Style_Guide#Commits

(2) The Slicer commit message, you mentioned "Fixed issue with SetSceneReference", what does that mean ? Did you change the code so that it changes the behavior from the user perspective or did you simply fix warnings ? ... the idea is to be descriptive so that other community members understand where/how/what/who :)

(3)In note "8425" you previously added, you talk about revision. Make sure to add a pointer to the associated repo. May be this should have been mentioned in the commit message instead.
jcfr

jcfr

2014-03-06 05:15

administrator   ~0011065

Closing resolved issues that have not been updated in more than 3 months

Issue History

Date Modified Username Field Change
2013-04-16 09:30 jcfr New Issue
2013-04-16 09:30 jcfr Status new => assigned
2013-04-16 09:30 jcfr Assigned To => pohl
2013-04-17 11:54 pohl Note Added: 0008425
2013-04-17 11:55 pohl Resolution open => fixed
2013-04-17 11:56 pohl Status assigned => resolved
2013-04-17 12:01 jcfr Note Added: 0008426
2013-04-17 12:02 jcfr Note Edited: 0008425
2013-04-17 12:04 jcfr Note Edited: 0008425
2014-03-06 05:15 jcfr Note Added: 0011065
2014-03-06 05:17 jcfr Status resolved => closed
2014-03-06 05:54 jcfr Fixed in Version => Slicer 4.4.0
2014-03-06 06:15 jcfr Target Version => Slicer 4.4.0