View Issue Details

IDProjectCategoryView StatusLast Update
0003045Slicer4Core: Extensionspublic2017-06-07 23:27
Reporterkikinis Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003045: Extension Manager - Open external link in the browser
Description

See http://stackoverflow.com/questions/741984/open-external-browser-from-qwebview

TagsNo tags attached.

Activities

jcfr

jcfr

2013-04-17 14:14

administrator   ~0008431

Fixed in r21897
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21897

// ----------------------
BUG: External link in extension manager now open in browser. Fixes 0003045

To determine if a link should be open in the extension manager or in an
external browser, the "host" of the clicked url and the server url are
compared.

See http://qt-project.org/doc/qt-4.8/qurl.html#setAuthority for more details.

See http://www.na-mic.org/Bug/view.php?id=3045

jcfr

jcfr

2013-08-28 12:00

administrator   ~0009666

Fixed in r22347
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22347

// -------------------------
BUG: Fix opening of link in extension manager

Opening of links different from slicer.kitware.com host into regular
browser has been initially introduced by r21897. Then, when commit r22220
introduced qSlicerWebWidget, the management of external links has been
broken.

This commit fixes the issue by ensuring the qSlicerWebWidget always open
link within its associated webview. The slot "onLinkClicked" from
"qSlicerExtensionsInstallWidget" will check what is the host and open
into a regular browser if needed.

See 0003045

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014647

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file a018e28b

2013-04-17 18:11:53

jcfr

Details Diff
BUG: External link in extension manager now open in browser. Fixes 0003045

To determine if a link should be open in the extension manager or in an
external browser, the "host" of the clicked url and the server url are
compared.

See http://qt-project.org/doc/qt-4.8/qurl.html#setAuthority for more details.

See http://www.na-mic.org/Bug/view.php?id=3045

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21897 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerExtensionsInstallWidget.cxx Diff File
mod - Base/QTGUI/qSlicerExtensionsInstallWidget.h Diff File

Issue History

Date Modified Username Field Change
2013-04-02 15:34 jcfr New Issue
2013-04-02 15:34 jcfr Status new => assigned
2013-04-02 15:34 jcfr Assigned To => jcfr
2013-04-02 15:35 jcfr Reporter jcfr => kikinis
2013-04-02 15:35 jcfr Target Version => Slicer 4.3.0
2013-04-17 14:14 jcfr Note Added: 0008431
2013-04-17 14:14 jcfr Status assigned => resolved
2013-04-17 14:14 jcfr Fixed in Version => Slicer 4.3.0
2013-04-17 14:14 jcfr Resolution open => fixed
2013-07-26 19:06 kikinis Status resolved => closed
2013-08-28 12:00 jcfr Note Added: 0009666
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file a018e28b
2017-06-07 23:27 jcfr Note Added: 0014647