View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003036Slicer4Module ModelMakerpublic2013-03-27 12:582017-06-07 23:27
Reportermuratmaga Assigned Tonicole  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003036: Can't save as .stl or .ply from Grayscale Model Maker in Windows 64 bit version
Description

.ply and .stl formats don't appear as file format options for grayscale model maker, even though they are available for the normal model maker module

TagsNo tags attached.

Activities

nicole

nicole

2013-03-27 13:07

administrator   ~0008254

Somehow the model node is being assigned a vtkMRMLFreeSurferModelStorageNode which doesn't suppor the .stl format.

Also to investigate:
Some model file options are not showing up in the save data dialog, and are different when load a model from disk. When saving the greyscale model get these format options:
.orig .inflated .sphere .white .smoothwm .pial .vtk .vtp
That's a partial list from the qSlicerModelsIO. When saving a model that I loaded from disk, I get:
Poly Data (.vtk)
XML Poly Data (.vtp)
STL (.stl)
PLY (.ply)
which is the list from the model storage node.
nicole

nicole

2013-04-12 12:08

administrator   ~0008388

Fixed in svn 21887[1].

The freesurfer model storage node was being used by the application logic due to a copy/paste error in the list of supported write types in the node. Cleaned up the storage node and now grey scale model maker and merge model output should offer the standard .vtk, .vtp, .stl, .ply save options. The Model Maker was working because it returns a mrml scene file with the proper model storage nodes stored there.

[1] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21887
jcfr

jcfr

2014-03-06 04:53

administrator   ~0010781

Closing resolved issues that have not been updated in more than 3 months

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file cda2a6c7

2013-04-12 16:05:26

naucoin

Details Diff 		BUG: Fix saving of models from GrayscaleModelMaker

When the models were being read back into Slicer by the vtkSlicerApplicationLogic,
it would check first if .vtk was a supported read type in the FreeSurfer
model storage node. Due to a copy/paste error in that class, it's SupportedReadFileTypes
string array was empty, which was interpreted as supporting all types and the
application logic would assign a FS model storage node to it. Because the
SupportedWriteFileTypes array was initialised with the supported read file types, the
grey scale model would come up in the save dialog as being able to be written in
FS formats.
It's a known interoperability issue that the FS model storage node doesn't support
writing FS formats, so the storage node inhertis from the model storage node superclass's
list of supported write types and uses it's WriteDataInternal to save FS models as .vtk
files.

Changes:
Initialize the SupportedReadFileTypes string array with just FS model file types.
Removed .vtk and .vtp as supported read types, Slicer should default to a regular
model storage node for those files.
Fixed some debugging string print outs.

Issue 0003036



git-svn-id: http://svn.slicer.org/Slicer4/trunk@21887 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLFreeSurferModelStorageNode.cxx Diff File

Issue History

Date Modified Username Field Change
2013-03-27 12:58 muratmaga New Issue
2013-03-27 12:58 muratmaga Status new => assigned
2013-03-27 12:58 muratmaga Assigned To => nicole
2013-03-27 13:07 nicole Note Added: 0008254
2013-03-27 15:01 jcfr Target Version => Slicer 4.3.0
2013-04-12 12:08 nicole Note Added: 0008388
2013-04-12 12:08 nicole Status assigned => closed
2013-04-12 12:08 nicole Resolution open => fixed
2013-04-12 12:08 nicole Fixed in Version => Slicer 4.3.0
2013-04-12 12:51 nicole Status closed => resolved
2014-03-06 04:53 jcfr Note Added: 0010781
2014-03-06 04:54 jcfr Status resolved => closed
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file cda2a6c7