View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002976 | Slicer4 | Core: Extensions | public | 2013-02-22 09:40 | 2013-06-16 20:45 |
Reporter | crmullin | Assigned To | jcfr | ||
Priority | urgent | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.2.2-1 | ||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0002976: Extensions Manager hangs when a category is selected | ||||
Description | Steps to reproduce: 1) Download Slicer4.2.2-1 from the downloads page for MacOS X. | ||||
Additional Information | I am able to download an extension properly, as long as I don't click on any of the categories. | ||||
Tags | No tags attached. | ||||
Based on my discussion with Chris, on MacOSX:
|
|
It is not OS dependent. I observe the same thing on Linux. |
|
Issue has been identified. The recent changes allowing to fetch on demand extensions when scrolling required to extend the QWebkit object embedded in Slicer so that it emulates part of the HTML5 Visibility API. This was done while working on Slicer issue 2911, and the associated changesets are Slicer r21660 [2] and SlicerAppStore commit fd86adc7 [3] When the slicerappstore page is loaded, it checks if the browser has support for // Setup scroll pagination and fetch results based on the initial settings
} else {
} The problem occurred when clicking on a category. Indeed, the javascript callback associated with the click event was "applyFilter()" and this function wasn't checking if the pagevisiblity API was present and was assuming the "fetch on demand" mode was enabled. Then a "loading gif" was displayed bu no extension were fetched .. it then give the impression of "hang". [1] http://na-mic.org/Mantis/view.php?id=2911 |
|
This has been fixed in the slicerappstore midas plugin. See https://github.com/jcfr/slicerappstore/commit/fb3e94343df37c69f32f9ffc766211c79b88aa6d and https://github.com/midasplatform/slicerappstore/pull/37 As soon as the change have been reviewed, integrated and the server update. It should be possible to click on the category using from Slicer 4.2.2-1. |
|
Changes have been reviewed, integrated and tested. @chris: Issue can be closed Thanks |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2013-02-22 09:40 | crmullin | New Issue | |
2013-02-22 09:40 | crmullin | Status | new => assigned |
2013-02-22 09:40 | crmullin | Assigned To | => jcfr |
2013-02-22 10:53 | jcfr | Priority | normal => urgent |
2013-02-22 10:53 | jcfr | Target Version | => Slicer 4.3.0 |
2013-02-22 10:56 | jcfr | Note Added: 0008003 | |
2013-02-22 11:08 | jcfr | Note Added: 0008004 | |
2013-02-22 11:08 | jcfr | Note Edited: 0008003 | |
2013-02-22 12:37 | jcfr | Note Added: 0008007 | |
2013-02-22 12:44 | jcfr | Relationship added | related to 0002911 |
2013-02-22 13:01 | jcfr | Note Added: 0008008 | |
2013-02-22 13:01 | jcfr | Status | assigned => resolved |
2013-02-22 13:01 | jcfr | Fixed in Version | => Slicer 4.3.0 |
2013-02-22 13:01 | jcfr | Resolution | open => fixed |
2013-02-22 14:33 | jcfr | Note Added: 0008009 | |
2013-06-16 20:45 | crmullin | Status | resolved => closed |