View Issue Details

IDProjectCategoryView StatusLast Update
0002955Slicer4Core: CLI infrastructurepublic2018-03-02 11:00
Reporternicole Assigned Tomillerjv  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.7.0Fixed in Version 
Summary0002955: Add support for points as output types for CLIs
Description

Annotation mrml nodes are currently passed to CLIs as a list of points on the command line. They cannot be returned to Slicer yet. It would be great to add support for the annotation storage nodes (and then the markup storage nodes) to be written to disk and then read back in.

Additional Information

Would it be possible to revamp the command line module logic to allow a more generic file based input/output structure to allow passing storable nodes back and forth to command line modules via disk? Backward compatibility is required as the library is in use outside of Slicer.

TagsNo tags attached.

Activities

jcfr

jcfr

2013-02-15 05:54

administrator   ~0007941

From Nicole:

Right now the Slicer execution model still passes fiducial points to
CLI's on the command line and doesn't take back output parameters. You
can pass points back in a parameter file, but they won't be
automatically turned into annotation fiducials (see the bug linked
below
for a link to the simple return types project page).
The plan is to extend the functionality once the fiducials are being
stored in a single file per list and CLI developers can read and write
the files via MRML storage node.
fedorov

fedorov

2013-02-17 06:44

developer   ~0007972

Related issue reported for Slicer3:

======================================================================
http://www.na-mic.org/Bug/view.php?id=648

Reported By: fedorov
Assigned To: millerjv

Project: Slicer3
Issue ID: 648
Category: Command Line Modules (Applications/CLI)
Reproducibility: always
Severity: feature
Priority: normal
Status: assigned

Date Submitted: 2009-09-25 14:43 EDT
Last Modified: 2013-02-14 15:26 EST

Summary: Passing ROI to CLI
Description:
I would like to be able to pass an ROI (vtkMRMLROINode) through the CLI
interface.


(0001254) pieper (administrator) - 2009-11-10 16:45
http://www.na-mic.org/Bug/view.php?id=648#c1254

Also need to be able to send fiducials back from CLIs...


(0001255) pieper (administrator) - 2009-11-10 16:47
http://www.na-mic.org/Bug/view.php?id=648#c1255

Perhaps there's a way to easily add a new storable data type.


(0001321) fedorov (developer) - 2010-01-30 12:20
http://www.na-mic.org/Bug/view.php?id=648#c1321

Jim introduced the capability to return scalars back from CLI. Follow the
development here:
http://www.na-mic.org/Wiki/index.php/2010_Winter_Project_Week_Command_Line_Module_Simple_Return_Types

nicole

nicole

2014-01-08 05:58

administrator   ~0010491

From Winter 2014 Project week: 2 people have asked for being able to return fiducials from CLI modules.

nicole

nicole

2014-01-08 05:59

administrator   ~0010492

Reminder sent to: tokuda

Here's the bug report I was talking about.

jcfr

jcfr

2016-10-12 14:55

administrator   ~0014189

Related commit:

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24812

<pre>
ENH: Improved ExecutionModelTour pointfile example

Fiducial node selector widget created for pointfile field does not support selection of multiple nodes
therefore adding a <pointfile multiple="true" ...> tag in the ExecutionModelTour example was misleading
(it will never get multiple files).
=> removed multiple="true"

Pointfile with channel="output" is a regular file field (same as transform, image, table, etc),
therefore adding a separate "File return types" section in the XML was misleading.
=> moved the field from separate section to right after the pointfile with channel="input", so now
it looks the same as all other file fields
</pre>

lassoan

lassoan

2017-09-27 12:31

developer   ~0015181

This feature was implemented some time ago. Markup fiducial points can be used as inputs and outputs (passed as files).

Issue History

Date Modified Username Field Change
2013-02-15 05:49 nicole New Issue
2013-02-15 05:49 nicole Status new => assigned
2013-02-15 05:49 nicole Assigned To => millerjv
2013-02-15 05:52 nicole Relationship added parent of 0002606
2013-02-15 05:54 jcfr Note Added: 0007941
2013-02-17 06:44 fedorov Note Added: 0007972
2013-09-03 10:57 jcfr Target Version Slicer 4.3.0 => Slicer 4.4.0
2014-01-08 05:58 nicole Note Added: 0010491
2014-01-08 05:59 nicole Note Added: 0010492
2014-05-13 20:47 jcfr Target Version Slicer 4.4.0 => Slicer 4.5.0-1
2015-11-02 11:27 jcfr Target Version Slicer 4.5.0-1 => Slicer 4.6.0
2016-10-12 14:55 jcfr Note Added: 0014189
2016-10-12 14:58 jcfr Target Version Slicer 4.6.0 => Slicer 4.7.0
2017-09-27 12:31 lassoan Relationship deleted parent of 0002606
2017-09-27 12:31 lassoan Status assigned => resolved
2017-09-27 12:31 lassoan Resolution open => fixed
2017-09-27 12:31 lassoan Note Added: 0015181
2018-03-02 11:00 jcfr Status resolved => closed