View Issue Details

IDProjectCategoryView StatusLast Update
0002929Slicer4Core: Usabilitypublic2017-06-07 23:27
Reportereli Assigned Topieper  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.0 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002929: Remove Islands
Description

The remove islands feature is present but does not perform correctly as far as we can tell.

In slicer 2.7, we would choose the mimimum island size, then we would click inside the labelmap and outside the labelmap in the coronal view while in native mode.

Next, we would change to Active mode and click inside and then outside the labelmap in the coronal, then sagital and finally in the axial view.

TagsNo tags attached.

Relationships

related to 0002737 closedpieper improve island removal tool 

Activities

eli

eli

2013-05-20 06:04

reporter   ~0008662

Would we be able to get an update on how this is coming along? We don't need it to function exactly like it does in Slicer 2.7, but as of now it doesn't seem to work at all.

pieper

pieper

2013-06-05 06:22

administrator   ~0008709

Can you attach a sample label map before and after the remove Islands operation from Slicer2 that works the way you want it to work in Slicer 4?

pieper

pieper

2013-07-08 07:04

administrator   ~0008879

I'm trying to better understand why this is failing for you. Here is the sequence I tried:

1) load some image data
2) go to editor
3) use the paint tool to add a spot in the middle of the volume in label 1
4) use the dilate tool to make the spot big (dilate 20 times or so)
5) switch back to the paint and pick label 0
6) add a hole in the middle of the big region
7) pick remove islands and apply

What should happen here is that the hole of 0 goes away. Can you replicate this? How is it different from what you are trying to accomplish?

eli

eli

2013-07-08 07:07

reporter   ~0008880

We will check in on this and get back to you today.

eli

eli

2013-07-08 09:12

reporter   ~0008887

I uploaded a standard "tensor mask" dataset that we would like to use the remove islands tool on. As you can see, there are several holes in the mask. Slicer 2.7 does an excellent job of removing all of these holes, even though some of them are connected to the "sea" in other slices. If this is not possible in Slicer 4, that is fine, we will find a workaround, but I just wanted to show you that it doesn't have the desired effect.

2013-07-08 09:12

 

Scene-Before_Remove_Islands.mrml (57,486 bytes)
pieper

pieper

2013-07-08 09:29

administrator   ~0008891

Hi -

The file you attached is only the scene description and it doesn't have the actual data. If you could save a .mrb version I could look at that.

But first, were you able to replicate the steps I listed above? Does that not capture the use case?

Or are you saying that what you want is for the island removal to be applied on a slice-by-slice basis rather than in 3D?

eli

eli

2013-07-08 09:46

reporter   ~0008893

What would be a good way to transfer the data to you, since the .mrb file is too large for Mantis?

I was able to replicate your steps successfully. I suppose that being able to use remove islands on a slice-by-slice basis may be the most similar to what we are used to, although that could end up causing problems as well. Either way, it may be worth testing.

pieper

pieper

2013-07-08 09:55

administrator   ~0008894

1) There is a partners secure file transfer service: http://rc.partners.org/sFTP

2) Since you were able to replicate the simple test case, can you describe how your use case is different? Is it because the islands aren't really islands but only appear to be on a per-slice basis?

eli

eli

2013-07-08 10:13

reporter   ~0008896

Okay I will use that.

I suppose that is correct. I think the best example of why we want to be able to remove islands on a per-slice basis, would be if you look at the scan that I will send to you, you will see that the eye-ball is included in the automatically generated mask ("labelmap"). In Slicer 2.7, running "remove islands" will remove the mask covering that area, whether or not it is connected in a different slice. However, in Slicer4, running "save island" or "remove island" does not have the desired effect.

pieper

pieper

2013-08-07 10:34

administrator   ~0009422

Here's a prototype of a new tool to address this:

https://gist.github.com/pieper/6176830

pieper

pieper

2013-08-19 13:46

administrator   ~0009523

Please test r22299 (should be in a nightly build as of Aug 20, 2013).

There is now a new Morphological option in RemoveIslands that will clean up interior and exterior structures even if there is some connectivity.

pieper

pieper

2013-09-05 08:47

administrator   ~0009894

PNL reports this works well for their data.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file ab99bd45

2013-08-19 17:43:51

pieper

Details Diff
BUG: 0002737, 0002929 improve RemoveIslands tool

This adds a new "Morphological" island removal algorithm that has
been tested as useful on the brain mask that is output from the
diffusion tensor estimation module. It may be useful for other
applications as well.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22299 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/RemoveIslandsEffect.py Diff File

Issue History

Date Modified Username Field Change
2013-02-11 07:42 eli New Issue
2013-02-11 07:42 eli Status new => assigned
2013-02-11 07:42 eli Assigned To => kikinis
2013-02-11 07:52 kikinis Assigned To kikinis => pieper
2013-05-20 06:04 eli Note Added: 0008662
2013-06-05 06:22 pieper Note Added: 0008709
2013-07-08 06:56 pieper Relationship added related to 0002737
2013-07-08 07:04 pieper Note Added: 0008879
2013-07-08 07:07 eli Note Added: 0008880
2013-07-08 09:12 eli Note Added: 0008887
2013-07-08 09:12 eli File Added: Scene-Before_Remove_Islands.mrml
2013-07-08 09:29 pieper Note Added: 0008891
2013-07-08 09:46 eli Note Added: 0008893
2013-07-08 09:55 pieper Note Added: 0008894
2013-07-08 10:13 eli Note Added: 0008896
2013-08-07 10:34 pieper Note Added: 0009422
2013-08-07 10:35 pieper Target Version => Slicer 4.3.0
2013-08-19 13:46 pieper Note Added: 0009523
2013-08-19 13:46 pieper Status assigned => resolved
2013-08-19 13:46 pieper Fixed in Version => Slicer 4.3.0
2013-08-19 13:46 pieper Resolution open => fixed
2013-09-05 08:47 pieper Note Added: 0009894
2013-09-05 08:47 pieper Status resolved => closed
2017-06-07 23:27 pieper Changeset attached => Slicer 2145-support-for-installing-extension-from-file ab99bd45