View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002878 | Slicer4 | Core: GUI | public | 2013-01-18 05:35 | 2017-06-07 23:27 |
Reporter | pieper | Assigned To | pieper | ||
Priority | high | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.2.2-1 | ||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0002878: slice locations are at pixel boundaries instead of pixel centers after SnapSliceOffsetToIJK | ||||
Description | The vtkMRMLSliceLogic::SnapSliceOffsetToIJK() method should move the slice plane (slice node offset) to be in the middle of background pixel. This is important for visualizing and editing volume data because when the slice plane is exactly at the boundary between two pixels then a rounding error can lead to different parts of the code selecting to view or operate on different slices. | ||||
Steps To Reproduce | 1) Load MR-head Note that with 4.2 the line stays exactly at the boundary of the pixels. In 4.1 the line is properly adjusted to lie in the middle of the pixel. | ||||
Additional Information | This is a regression that needs to be investigated and fixed. | ||||
Tags | No tags attached. | ||||
2013-01-18 05:36
|
|
See attached screen shot showing the different behavior between 4.1 and 4.2. |
|
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21640 |
|
Hi Steve
|
|
Fix committed to 2145-support-for-installing-extension-from-file branch. |
|
Slicer: 2145-support-for-installing-extension-from-file 5916e3d8 2013-01-27 13:22:17 Details Diff |
BUG: fix calculation for snapping to center of slice (fixes 0002878) When performing pixel level operations, as with the Editor module, or even when rendering multiple layers, the result can be ambiguous when the slice plane is exactly at the border between two pixels due to rounding differences accumulated through transforms. This can lead to inconsistent rendering or operations being applied in a differnt location than expected. A regression from 4.1 had crept in by which the slice plane was being consistently adjusted to be exactly on the pixel boundary, leading to the potential issues. This fix ensures that the plane is adjusted to the middle of the pixel. git-svn-id: http://svn.slicer.org/Slicer4/trunk@21640 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2013-01-18 05:35 | pieper | New Issue | |
2013-01-18 05:35 | pieper | Status | new => assigned |
2013-01-18 05:35 | pieper | Assigned To | => pieper |
2013-01-18 05:36 | pieper | File Added: Screen Shot 2013-01-18 at 10.33.36 AM.png | |
2013-01-18 05:36 | pieper | Note Added: 0007707 | |
2013-01-27 08:23 | pieper | Note Added: 0007742 | |
2013-01-27 08:23 | pieper | Status | assigned => resolved |
2013-01-27 08:23 | pieper | Fixed in Version | => Slicer 4.2.3 |
2013-01-27 08:23 | pieper | Resolution | open => fixed |
2013-02-12 09:40 | jcfr | Fixed in Version | Slicer 4.2.3 => Slicer 4.3.0 |
2013-02-26 13:00 | pieper | Note Added: 0008054 | |
2013-02-26 13:00 | pieper | Status | resolved => closed |
2013-03-07 05:39 | pieper | Relationship added | duplicate of 0002930 |
2013-03-11 08:16 | pieper | Relationship added | related to 0002999 |
2017-06-07 23:27 | pieper | Changeset attached | => Slicer 2145-support-for-installing-extension-from-file 5916e3d8 |
2017-06-07 23:27 | pieper | Note Added: 0014665 |