Pushed topic to: https://github.com/sankhesh/Slicer/tree/2834-consolidate-svn-git-hooks

Wiki documentation on the issue: http://www.slicer.org/slicerWiki/index.php/Documentation/Labs/DevelopmentWithGit

See also http://itk.org/Wiki/ITK/Git/Develop/Data

Topic where the hooks are available: https://github.com/sankhesh/Slicer/commits/hooks

Just tried the script. Love it.

Next steps:

• Squash the commits together (on master and hooks branch)
• Move http://www.slicer.org/slicerWiki/index.php/Documentation/Labs/DevelopmentWithGit to http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/
• Update current build instruction to include/reference the new page.

Thanks
Jc

Feature merged. http://viewvc.slicer.org/viewvc.cgi/Slicer4/?view=query&pathrev=21913&dir=&file=&file_match=exact&who=&who_match=exact&comment=&comment_match=exact&querysort=date&hours=2&date=explicit&mindate=2013-04-24+13%3A00%3A00&maxdate=2013-04-24+15%3A00%3A00&limit_changes=100

Hooks branch: https://github.com/Slicer/Slicer/tree/hooks

Very nice :)

The view link for viewvc is also cool.

I noticed you added the Version information, would it be possible to check if the current version match stored in the .git/config matches the one hardcoded in the hook. That way, the developer could be notified he was to re-run SetupForDevelopment.sh

Thank you.

The version checking is done by the pre-commit hook. See: https://github.com/Slicer/Slicer/blob/hooks/pre-commit#L53-67

Excellent. Of course .. it all makes sens.

Could you send an email on devel list ?

Could you also create an entry in the develop FAQ named: "How to setup git hooks?" See http://www.slicer.org/slicerWiki/index.php?title=Documentation/Nightly/Developers/FAQ/General&action=edit

Done.

Hi Sankesh,

Could you please add .mrml to the list of extensions that aren't checked for max line length? I needed to check in a test scene and had to manually disable that test.

Thanks!

Fixed in r21911, r21946, r22002, r22237

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21911
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21946
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22002
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22237

Related links:

http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ/General#How_to_setup_for_Git_development_.3F

http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/DevelopmentWithGit#Slicer_Setup

Thanks!