View Issue Details

IDProjectCategoryView StatusLast Update
0002811Slicer4Core: Base Codepublic2017-06-07 23:27
Reporterpieper Assigned Topieper  
PriorityhighSeveritycrashReproducibilityalways
Status closedResolutionfixed 
PlatformwindowsOSOS Version
Product VersionSlicer 4.2.0 
Target VersionSlicer 4.2.2-1Fixed in VersionSlicer 4.2.2-1 
Summary0002811: crash loading dicom volume on windows
Description

Trying to load a volume led to a crash in the std iterator code in this method:

vtkMRMLVolumeNode vtkSlicerVolumesLogic::AddArchetypeVolume (
const NodeSetFactoryRegistry& volumeRegistry,
const char
filename, const char volname, int loadingOptions,
vtkStringArray
fileList)

Additional Information

Tracked it down and it's fixed with this change. Note that with the capital V VolumeRegistry.end() it's referring to this->VolumeRegistry.end() while volumeRegistry.begin() is the local instance variable.

@@ -514,11 +514,11 @@ vtkMRMLVolumeNode* vtkSlicerVolumesLogic::AddArchetypeVolume (

vtkNew<vtkSlicerErrorSink> errorSink;

// Run through the factory list and test each factory until success
for (NodeSetFactoryRegistry::const_iterator fit = volumeRegistry.begin();

  • fit != VolumeRegistry.end(); ++fit)
  • fit != volumeRegistry.end(); ++fit)
    {
    ArchetypeVolumeNodeSet nodeSet( (*fit)(volumeName, this->GetMRMLScene(), loadingOptions) );

    nodeSet.StorageNode->AddObserver(vtkCommand::ErrorEvent, errorSink.GetPointer());
    nodeSet.StorageNode->AddObserver(vtkCommand::ProgressEvent, this->GetMRMLNodesCallbackCommand());

TagsNo tags attached.

Relationships

duplicate of 0002814 closedmillerjv Crash when loading scalar DICOM volume 

Activities

pieper

pieper

2012-11-30 13:26

administrator   ~0007397

Reminder sent to: millerjv

Jim, Julien -

Can you look at this and confirm:

https://github.com/pieper/slicer/tree/2811-volumeRegistry-crash

Thanks,
Steve

pinter

pinter

2012-12-04 10:42

developer   ~0007404

Steve,

Thanks for taking care of my issue. Sorry I didn't browse the mantis list before adding it.

Anyway, I came up with the same fix and tested it, and it prevents the crash.

pieper

pieper

2012-12-04 11:06

administrator   ~0007406

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=21475

jcfr

jcfr

2014-03-06 05:12

administrator   ~0011004

Closing resolved issues that have not been updated in more than 3 months

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file dfb83c0a

2012-12-04 15:48:28

pieper

Details Diff
BUG: fix typo in iterator loop

See issue 0002811

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21475 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx Diff File

Issue History

Date Modified Username Field Change
2012-11-30 13:22 pieper New Issue
2012-11-30 13:22 pieper Status new => assigned
2012-11-30 13:22 pieper Assigned To => pieper
2012-11-30 13:26 pieper Note Added: 0007397
2012-12-04 10:39 pieper Relationship added duplicate of 0002814
2012-12-04 10:42 pinter Note Added: 0007404
2012-12-04 11:06 pieper Note Added: 0007406
2012-12-04 11:06 pieper Status assigned => resolved
2012-12-04 11:06 pieper Fixed in Version => Slicer 4.2.2
2012-12-04 11:06 pieper Resolution open => fixed
2014-03-06 05:12 jcfr Note Added: 0011004
2014-03-06 05:13 jcfr Status resolved => closed
2017-06-07 23:27 pieper Changeset attached => Slicer 2145-support-for-installing-extension-from-file dfb83c0a