View Issue Details

IDProjectCategoryView StatusLast Update
0002790Slicer4Core: Packagingpublic2013-02-12 09:40
Reporterfedorov Assigned Tojcfr  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.0 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002790: nightlies version is displayed 4.2.0
Description

Shouldn't it be 4.2.1 ? It's a bit strange that nightlies have earlier release version than stable packages.

TagsNo tags attached.

Relationships

related to 0003265 closedjcfr Consistent Slicer version between trunk and release branch 

Activities

jcfr

jcfr

2012-12-16 03:29

administrator   ~0007504

This is expected. You will find below email exchange I got with Ron where I explain why.

// -------------------------------
// -------------------------------
Ron - Dec 15, 2012

I notice that the nightly build is still numbered 4.2.0 instead of 4.2.2-1 or such.

// -------------------------------
// -------------------------------
Jc - 12/15/12:

This is expected, The version 4.2.2-1 is a patch release build of the 4.2 branch. On the other hand, the main branch (trunk) doesn'have the commit specific to the versioning of the 4.2 branch.
I tried to illustrate it below.

   4.2.0                               4.3.0

--------#-----------------------------------#
\
\ --- 4.2.1---4.2.2----4.2.3

// -------------------------------
// -------------------------------
Ron - Sat, Dec 15, 2012

I guess, I need more education. I do not understand your explanation. What is the meaning of "the main branch doesn't have the commit specific to the versioning of the 4.2 branch"?

// -------------------------------
// -------------------------------
Jc - 12/15/12

Each time we create a release, we have to modify a file where the
revision is written. To save this revision update, a commit is created.
Then, a package is created based on this commit.

Since we have two branch for slicer development:

  • trunk or master branch where all the active development is going
  • 4.2 release maintenance branch

.. each time we create a patch release for 4.2, the commit representing
the update of the revision is only on the 4.2 branch. It means only this
branch will contain commit resulting in package like 4.2.1, 4.2.2 ....

Thanks
Jc

// -------------------------------
// -------------------------------
Ron - Sat, Dec 15, 2012

If I understnd properly, that means that all the bug fixes on 4.2.2 are not in the 4.2.0 branch?
This results in duplicate work?

// -------------------------------
// -------------------------------
Jc - Dec 15, 2012

In fact, the commit happening in the main (master/trunk) branch are backported to the maintenance branch. In other word, when a bug is fixed in the nightly, I select the associated commit and apply it on the maintenance branch, when I have enough small fixes ... I then create a patch release (4.2.1, 4.2.2, 4.2.3, ...)

Let's also note that major feature, change introducing redesign, ... are not backported .. these ones along with the regular fixes will be part of the next minor release: 4.3.0

Issue History

Date Modified Username Field Change
2012-11-23 12:57 fedorov New Issue
2012-11-23 12:57 fedorov Status new => assigned
2012-11-23 12:57 fedorov Assigned To => jcfr
2012-12-08 10:07 jcfr Target Version => Slicer 4.2.3
2012-12-16 03:29 jcfr Note Added: 0007504
2012-12-16 03:29 jcfr Status assigned => resolved
2012-12-16 03:29 jcfr Fixed in Version => Slicer 4.2.3
2012-12-16 03:29 jcfr Resolution open => fixed
2012-12-16 07:38 fedorov Status resolved => closed
2013-02-12 09:39 jcfr Target Version Slicer 4.2.3 => Slicer 4.3.0
2013-02-12 09:40 jcfr Fixed in Version Slicer 4.2.3 => Slicer 4.3.0
2013-07-31 08:30 jcfr Relationship added related to 0002980
2013-07-31 08:30 jcfr Relationship deleted related to 0002980
2013-07-31 08:30 jcfr Relationship added related to 0003265