View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002734 | Slicer4 | Extension: TubeTk | public | 2012-11-06 04:25 | 2014-03-06 05:13 |
Reporter | rkwitt | Assigned To | mccormic | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.1.0 | ||||
Target Version | Slicer 4.2.1 | Fixed in Version | Slicer 4.2.1 | ||
Summary | 0002734: Slicer freezes when loading .tre file | ||||
Description | Slicer freezes when loading a SpatialObject file, such as the one attached. No error messages are shown ... | ||||
Tags | No tags attached. | ||||
2012-11-06 04:25
|
Branch-truth.tre (59,164 bytes) |
I'm investigating the following error and output from gdb which I think might be responsible. warning: Could not load shared library symbols for libvtkSlicerSpatialObjectsModuleLogicPythonD.so. Program received signal SIGINT, Interrupt. The blame returns this commit where metaVesselTube was added: Here's the fix by Matt McCormick: This patch was already added to ITKv3 in Slicer. |
|
Email sent to Roland: You need to add the extra condition && c!="\377" at this line https://github.com/Kitware/ITK/blob/dcd655f89cd17b5b864878f0c0e0b77b00b17553/Utilities/MetaIO/metaVesselTube.cxx#L947 |
|
@Roland: Could you please retry with a fresh Slicer build and a fresh Extension build? Also, make sure that Slicer is using your built extension by checking the Slicer "Additional module paths". I tried this on that dataset you attached, and it works fine. There has been a problem with the ExternalProject UPDATE_COMMAND, and your ITK may not have been updated. @JC, FYI, I finally may have made progress with upstream CMake on that front per today: @JC, Chris, I don't see '\377' in the file that Roland uploaded? |
|
|
|
Interesting. A hangout is a good idea -- I'll add a calendar invite for tomorrow at 11 if you can make it. |
|
During our hangout session, we solved the problem. Here are the topics:
While working on the issue, also backported the most recent change of the MetaIO library to ITK3.20. See https://github.com/jcfr/ITK/tree/backport-metaio-itkv4-fixes Matt> Could you push changes on top of release-3.20 integration branch, and then update the External_ITKv3.cmake in Slicer ? Make the issue as resolved when done. Thanks |
|
Great stuff, JC. ITKv3 release-3.20 has been merged: http://itk.org/gitweb?p=ITK.git;a=commit;h=3f5d32015df46591fde9c4656b59842f11efe9e4 Slicer ITKv3 external project has been bumped with r21347. A test was added for the ITKv4 patch. Will see if someone wants to review there tomorrow, then commit to MetaIO -> ITK/VTK -> Slicer. |
|
Extra. Thanks Matt. Also thank you for writing the test in ITKv4. Marking the issue as resolved, tomorrow packages should allow Roland to confirm it works and close the issue. Fixed in r21347 |
|
Closing resolved issues that have not been updated in more than 3 months |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-11-06 04:25 | rkwitt | New Issue | |
2012-11-06 04:25 | rkwitt | Status | new => assigned |
2012-11-06 04:25 | rkwitt | Assigned To | => crmullin |
2012-11-06 04:25 | rkwitt | File Added: Branch-truth.tre | |
2012-11-07 11:50 | crmullin | Note Added: 0007111 | |
2012-11-07 12:02 | crmullin | Note Edited: 0007111 | |
2012-11-07 12:55 | crmullin | Note Edited: 0007111 | |
2012-11-08 05:55 | jcfr | Target Version | => Slicer 4.2.1 |
2012-11-08 08:28 | jcfr | Note Added: 0007119 | |
2012-11-08 10:38 | mccormic | Note Added: 0007123 | |
2012-11-08 12:56 | jcfr | Note Added: 0007124 | |
2012-11-08 19:23 | mccormic | Note Added: 0007128 | |
2012-11-09 10:02 | jcfr | Note Added: 0007138 | |
2012-11-09 10:02 | jcfr | Assigned To | crmullin => mccormic |
2012-11-09 10:02 | jcfr | Status | assigned => confirmed |
2012-11-12 16:34 | mccormic | Note Added: 0007174 | |
2012-11-12 16:40 | jcfr | Note Added: 0007175 | |
2012-11-12 16:40 | jcfr | Status | confirmed => resolved |
2012-11-12 16:40 | jcfr | Fixed in Version | => Slicer 4.2.1 |
2012-11-12 16:40 | jcfr | Resolution | open => fixed |
2012-11-12 16:41 | jcfr | Note Edited: 0007175 | |
2014-03-06 05:12 | jcfr | Note Added: 0011002 | |
2014-03-06 05:13 | jcfr | Status | resolved => closed |