View Issue Details

IDProjectCategoryView StatusLast Update
0002731Slicer4Core: Building (CMake, Superbuild)public2014-03-06 04:55
Reporterawiles Assigned Tojcfr  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.0 
Target VersionSlicer 4.2.1Fixed in VersionSlicer 4.2.1 
Summary0002731: ITK configuration fails behind firewall
Description

While building Slicer on Windows 7 behind a firewall with Slicer_USE_GIT_PROTOCOL turned off, ITKv3 fails to move to the build stage because the submodule points to an address using a git protocol and not an http protocol.

Error message from MSVC 2010:

Note: checking out 'dcd655f89c'.
2>
2> You are in 'detached HEAD' state. You can look around, make experimental
2> changes and commit them, and you can discard any commits you make in this
2> state without impacting any branches by performing another checkout.
2>
2> If you want to create a new branch to retain commits you create, you may
2> do so (now or later) by using -b with the checkout command again. Example:
2>
2> git checkout -b new_branch_name
2>
2> HEAD is now at dcd655f... Merge branch 'metaTubeReader' into release-3.20
2> Submodule 'Andrew Wiles' (git://itk.org/ITKData.git) registered for path 'Testing/Data'
2> Cloning into 'Testing/Data'...
2> fatal: unable to connect to itk.org:
2> itk.org[0: 66.194.253.19]: errno=No error
2>
2> Clone of 'git://itk.org/ITKData.git' into submodule path 'Testing/Data' failed
2> CMake Error at ITKv3-prefix/tmp/ITKv3-gitclone.cmake:57 (message):
2> Failed to update submodules in: 'D:/src/Slicer4/SlicerBuild-Debug/ITKv3'

If I do a git submodule init on a separate clone I get:

$ git submodule init
Submodule 'Testing/Data' (git://itk.org/ITKData.git) registered for path 'Testin
g/Data'

Obviously, with Slicer_USE_GIT_PROTOCOL turned off, the above submodule should point to an http address. Is this a Slicer or ITK issue?

Additional Information

Note I am using DCMTK with Tag DCMTK-3.6.1_20121102 to avoid the MSVC2010 build error (http://na-mic.org/Mantis/view.php?id=2695). Not sure if Slicer will build with this change because I can't get past the ITK build step.

TagsNo tags attached.

Relationships

related to 0002751 closedjcfr Tweak messages displayed when building with Slicer_USE_GIT_PROTOCOL set to OFF 

Activities

awiles

awiles

2012-11-05 09:52

reporter   ~0007049

I think the fix is to put the following line in the ITKv3-gitclone.cmake file:

git config url.http://itk.org/.insteadOf git://itk.org/

However, I have no idea how to implement that generically in SlicerExtensionsDashboardDriverScript.cmake. I am happy to implement it and test it if someone can point me to file where this fix should be placed.

jcfr

jcfr

2012-11-05 10:18

administrator   ~0007050

After deleting ITKv3* folders from your build tree, could you try the following command:

git config --global url."http://itk.org/".insteadOf "git://itk.org"

.. and rebuild.

It should allow the ITKv3 submodules to be properly initialized.

To implement a more generic solution, we would have to see how custom "git clone steps" could be added to External project after the init and before the update submodule.

awiles

awiles

2012-11-05 11:18

reporter   ~0007054

I have tested this and it works. But yes, a generic solution is probably best to prevent frustrations of other users. It took me a while to track down the real issue.

jcfr

jcfr

2012-11-05 12:20

administrator   ~0007059

I just pushed a topic on my fork that would notify the user with his global config hasn't been updated properly.

Let me know if that would work.

See https://github.com/jcfr/Slicer/compare/2731-check-for-git-config-insteadof

awiles

awiles

2012-11-06 04:45

reporter   ~0007066

Looks great. I think this problem is solved. Thanks.

jcfr

jcfr

2012-11-06 04:54

administrator   ~0007068

Fixed in r21319
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21319

jcfr

jcfr

2014-03-06 04:53

administrator   ~0010751

Closing resolved issues that have not been updated in more than 3 months

Issue History

Date Modified Username Field Change
2012-11-05 09:14 awiles New Issue
2012-11-05 09:14 awiles Status new => assigned
2012-11-05 09:14 awiles Assigned To => jcfr
2012-11-05 09:32 jcfr Target Version => Slicer 4.2.1
2012-11-05 09:52 awiles Note Added: 0007049
2012-11-05 10:18 jcfr Note Added: 0007050
2012-11-05 11:14 jcfr Status assigned => feedback
2012-11-05 11:18 awiles Note Added: 0007054
2012-11-05 12:20 jcfr Note Added: 0007059
2012-11-06 04:45 awiles Note Added: 0007066
2012-11-06 04:54 jcfr Note Added: 0007068
2012-11-06 04:54 jcfr Status feedback => resolved
2012-11-06 04:54 jcfr Fixed in Version => Slicer 4.2.1
2012-11-06 04:54 jcfr Resolution open => fixed
2012-11-12 06:52 jcfr Relationship added related to 0002751
2014-03-06 04:53 jcfr Note Added: 0010751
2014-03-06 04:55 jcfr Status resolved => closed