View Issue Details

IDProjectCategoryView StatusLast Update
0002710Slicer4public2012-12-07 18:29
Reporternicole Assigned Tonicole  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.2-1Fixed in VersionSlicer 4.2.2-1 
Summary0002710: Abdominal atlas color file is all black
Description

Run abdominal atlas test, the segmentation label volume doesn't show up in the slice views. Looking at the referened color node, all values are black.

Additional Information

Need up update and reupload the mrb.

TagsNo tags attached.

Relationships

child of 0002514 closednicole Tutorial 13 - Abdominal Atlas 

Activities

nicole

nicole

2012-10-30 12:21

administrator   ~0006932

Last edited: 2012-10-30 12:23

Scene views color table storage nodes have incorrect path to the color table file:
<ColorTableStorage
id="vtkMRMLColorTableStorageNode23" name="vtkMRMLColorTableStorageNode23" hideFromEditors="true" selectable="true" selected="false" fileName="../__BundleSaveTemp-2012-10-04_19+01+34.531/Abdominal_Atlas_2012/Data/AbdominalAtlasColors.ctbl" useCompression="1" readState="0" writeState="0" ></ColorTableStorage>

trying to save a regular scene file first and then as an mrb...

nicole

nicole

2012-10-30 12:51

administrator   ~0006940

Saving as mrml scene only, paths to color table are fine in scene views.
Then save as an mrb directly after, the paths point to the temporary directory.

2012-10-30 12:58

 

Abdominal_Atlas_2012.mrml (1,203,298 bytes)
nicole

nicole

2012-10-30 12:59

administrator   ~0006941

Looks like all the storage nodes in the scene views are still pointing at the temp save dir for the bundle.
Maybe only the color nodes are trying to re-read themselves on scene view restore?

pieper

pieper

2012-10-30 14:15

administrator   ~0006943

Alex is changing the root directory on the scene view nodes during an mrb save.

alexy

alexy

2012-10-30 14:52

developer   ~0006946

Set root directory in the scene view nodes when saving .MRB files.
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=21289

nicole

nicole

2012-10-30 16:42

administrator   ~0006952

This fix doesn't seem to have helped all that much with the Brain Atlas file
http://slicer.kitware.com/midas3/download?items=10397

Granted, it was odd to begin with, but after opening the mrb and then saving it again, the top level scene view storage nodes have:
fileName="../../../__BundleLoadTemp2012-10-29_13+21+32.343/2012-09-18/
/Master%20Scene%20View1.png"
and
fileName="../../__BundleSaveTemp-2012-10-29_14+14+18.825/2012-10-29/projectsmarianna/ankara/tmp/ba-correction/AUG15/Left%20Cerebral%20Hemisphere.png

In the first scene view, volume storage nodes don't have the file list members reset:
fileName="Data/A1_grayT1.nrrd" fileListMember0="projectsbirn/nicole/Slicer42/Slicer4-SuperBuild-Debug/Slicer-build/tmpSlicer/__BundleSaveTemp-2012-10-29_14+14+18.825/2012-10-29/Data/A1_grayT1.nrrd"

and the color table storage node :
fileName="../../__BundleLoadTemp2012-10-30_14+01+05.118/2012-10-29/tmpSlicer/__BundleSaveTemp-2012-10-29_14+14+18.825/2012-10-29/projectsmarianna/ankara/tmp/ba-correction/AUG15/colorfiles/hncma-atlas-lut-mod2.ctbl"

Exiting Slicer and opening the newly saved mrb, all the scene view pngs are black because the thumbnail files weren't found. Restoring one scene view (Brainstem), looks mostly okay (color node is okay on the label map volume).

Will test with the abdomen atlas next.

nicole

nicole

2012-10-30 16:53

administrator   ~0006953

Last edited: 2012-10-30 16:55

Scene view pngs are missing when open the re-saved abdominal atlas mrb
http://slicer.kitware.com/midas3/download?items=8301

<SceneViewStorage
id="vtkMRMLSceneViewStorageNode2" name="SceneViewStorage_1" hideFromEditors="true" selectable="true" selected="false" fileName="../../__BundleLoadTemp2012-10-30_20+43+54.274/Abdominal_Atlas_2012/Data/Upper%20IG%20Tract.png" useCompression="1" readState="0" writeState="4" ></SceneViewStorage>

The data bundle png was fine.

Restoring the bone structures scene view, the segmentation volume has a black color table.

alexy

alexy

2012-10-30 17:27

developer   ~0006954

Nicole, does it happen when you start with a valid scene? Can you describe a scenario when you start with the valid scene and end up with invalid?

alexy

alexy

2012-10-30 18:06

developer   ~0006956

Fixed SceneViewStorage node's filename for MRB file.
revision: 21290

Nicole please test with starting with a valid scene file.

nicole

nicole

2012-10-31 06:46

administrator   ~0006964

It has to work with the Abdominal, Brain and Knee atlas files.
The Abdominal at least has an updated mrml file, it was recreated recently from scratch.

Current state: the scene view pngs are now correct again, but the color table nodes in the scene views still have all black entries. The file paths in the mrml file are correct, so I'm digging in further.

pieper

pieper

2012-10-31 06:50

administrator   ~0006965

If the bug fix is in the code that generates the scene, then I don't see how we can make the old scenes work.

nicole

nicole

2012-10-31 07:00

administrator   ~0006966

Seems like the bug is in the color node copy right now. working on it.

nicole

nicole

2012-10-31 07:48

administrator   ~0006971

Last edited: 2012-10-31 07:51

Strongly suspect it's a scene view restore logic error that I made on commit 20932:
http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Libs/MRML/Core/vtkMRMLSceneViewNode.cxx?r1=20932&amp;r2=20931&amp;pathrev=20932
line 498: the nodes that need to have UpdateScene called on them are the ones that were no scene view nodes aka they were included in the scene view.

Fixing this is probably going to expose the fact that the color table storage node in the scene view at that point still points to the temporary bundle directory since it was updated on mrml scene read... testing...

nicole

nicole

2012-10-31 08:23

administrator   ~0006972

I could reset the scene view storage node file names to be relative, but that's not going to fix the underlying problem that when reading in an mrb file, the dir where it was unpacked has been deleted - there are no files to re-read when restoring scene views.

jcfr

jcfr

2012-10-31 11:43

administrator   ~0006987

Considering MRB/Sceneview are not required for RSNA and the tutorial, re-targeted for 4.2.1.

jcfr

jcfr

2012-11-15 13:45

administrator   ~0007261

Seems that are still issue .. see http://na-mic.org/Bug/view.php?id=2512#c7257

nicole

nicole

2012-11-23 09:10

administrator   ~0007354

Edited the mrml file to include the color file data in the mrml file rather than just in the color file. This fixed the missing color information in the scene views, but we still need to revisit mrb + deleting files + restoring scene views in general.
Upload to Midas, in Nightly:
http://slicer.kitware.com/midas3/download?items=10277
Abdominal_Atlas_2012.mrb
Upload to Midas in 4.2 (thisone has the item id used in the AtlasTests.py file):
http://slicer.kitware.com/midas3/download?items=8301

nicole

nicole

2012-11-23 09:11

administrator   ~0007355

confirmed that download and run test shows proper colors in scene views.

jcfr

jcfr

2012-11-24 08:01

administrator   ~0007359

Excellent.
Is there anything to update on the 4.2 branch ?

nicole

nicole

2012-11-26 05:35

administrator   ~0007367

No update to the 4.2 branch needed, I uploaded a new revision of the mrb, the url didn't change.

Issue History

Date Modified Username Field Change
2012-10-30 11:03 nicole New Issue
2012-10-30 11:03 nicole Status new => assigned
2012-10-30 11:03 nicole Assigned To => nicole
2012-10-30 11:03 nicole Relationship added child of 0002514
2012-10-30 12:21 nicole Note Added: 0006932
2012-10-30 12:22 nicole Note Edited: 0006932
2012-10-30 12:23 nicole Note Edited: 0006932
2012-10-30 12:51 nicole Note Added: 0006940
2012-10-30 12:58 nicole File Added: Abdominal_Atlas_2012.mrml
2012-10-30 12:59 nicole Note Added: 0006941
2012-10-30 13:37 pieper Assigned To nicole => alexy
2012-10-30 14:15 pieper Note Added: 0006943
2012-10-30 14:15 pieper Status assigned => confirmed
2012-10-30 14:52 alexy Note Added: 0006946
2012-10-30 14:52 alexy Status confirmed => resolved
2012-10-30 14:52 alexy Resolution open => fixed
2012-10-30 16:42 nicole Note Added: 0006952
2012-10-30 16:53 nicole Note Added: 0006953
2012-10-30 16:54 nicole Status resolved => assigned
2012-10-30 16:54 nicole Resolution fixed => reopened
2012-10-30 16:55 nicole Note Edited: 0006953
2012-10-30 16:55 nicole Note Edited: 0006953
2012-10-30 17:27 alexy Note Added: 0006954
2012-10-30 18:06 alexy Note Added: 0006956
2012-10-30 18:06 alexy Status assigned => resolved
2012-10-30 18:06 alexy Resolution reopened => fixed
2012-10-31 06:46 nicole Note Added: 0006964
2012-10-31 06:46 nicole Assigned To alexy => nicole
2012-10-31 06:46 nicole Status resolved => assigned
2012-10-31 06:46 nicole Resolution fixed => reopened
2012-10-31 06:50 pieper Note Added: 0006965
2012-10-31 07:00 nicole Note Added: 0006966
2012-10-31 07:48 nicole Note Added: 0006971
2012-10-31 07:51 nicole Note Edited: 0006971
2012-10-31 08:23 nicole Note Added: 0006972
2012-10-31 11:43 jcfr Target Version Slicer 4.2.0 - coming release => Slicer 4.2.1
2012-10-31 11:43 jcfr Note Added: 0006987
2012-11-15 13:45 jcfr Note Added: 0007261
2012-11-16 12:02 jcfr Target Version Slicer 4.2.1 => Slicer 4.2.2
2012-11-23 09:10 nicole Note Added: 0007354
2012-11-23 09:10 nicole Status assigned => resolved
2012-11-23 09:10 nicole Fixed in Version => Slicer 4.2.2
2012-11-23 09:10 nicole Resolution reopened => fixed
2012-11-23 09:11 nicole Note Added: 0007355
2012-11-23 09:11 nicole Status resolved => closed
2012-11-24 08:01 jcfr Note Added: 0007359
2012-11-26 05:35 nicole Note Added: 0007367