View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002710 | Slicer4 | public | 2012-10-30 11:03 | 2012-12-07 18:29 | |
Reporter | nicole | Assigned To | nicole | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.2.2-1 | Fixed in Version | Slicer 4.2.2-1 | ||
Summary | 0002710: Abdominal atlas color file is all black | ||||
Description | Run abdominal atlas test, the segmentation label volume doesn't show up in the slice views. Looking at the referened color node, all values are black. | ||||
Additional Information | Need up update and reupload the mrb. | ||||
Tags | No tags attached. | ||||
Scene views color table storage nodes have incorrect path to the color table file: trying to save a regular scene file first and then as an mrb... |
|
Saving as mrml scene only, paths to color table are fine in scene views. |
|
2012-10-30 12:58
|
Abdominal_Atlas_2012.mrml (1,203,298 bytes) |
Looks like all the storage nodes in the scene views are still pointing at the temp save dir for the bundle. |
|
Alex is changing the root directory on the scene view nodes during an mrb save. |
|
Set root directory in the scene view nodes when saving .MRB files. |
|
This fix doesn't seem to have helped all that much with the Brain Atlas file Granted, it was odd to begin with, but after opening the mrb and then saving it again, the top level scene view storage nodes have: In the first scene view, volume storage nodes don't have the file list members reset: and the color table storage node : Exiting Slicer and opening the newly saved mrb, all the scene view pngs are black because the thumbnail files weren't found. Restoring one scene view (Brainstem), looks mostly okay (color node is okay on the label map volume). Will test with the abdomen atlas next. |
|
Scene view pngs are missing when open the re-saved abdominal atlas mrb <SceneViewStorage The data bundle png was fine. Restoring the bone structures scene view, the segmentation volume has a black color table. |
|
Nicole, does it happen when you start with a valid scene? Can you describe a scenario when you start with the valid scene and end up with invalid? |
|
Fixed SceneViewStorage node's filename for MRB file. Nicole please test with starting with a valid scene file. |
|
It has to work with the Abdominal, Brain and Knee atlas files. Current state: the scene view pngs are now correct again, but the color table nodes in the scene views still have all black entries. The file paths in the mrml file are correct, so I'm digging in further. |
|
If the bug fix is in the code that generates the scene, then I don't see how we can make the old scenes work. |
|
Seems like the bug is in the color node copy right now. working on it. |
|
Strongly suspect it's a scene view restore logic error that I made on commit 20932: Fixing this is probably going to expose the fact that the color table storage node in the scene view at that point still points to the temporary bundle directory since it was updated on mrml scene read... testing... |
|
I could reset the scene view storage node file names to be relative, but that's not going to fix the underlying problem that when reading in an mrb file, the dir where it was unpacked has been deleted - there are no files to re-read when restoring scene views. |
|
Considering MRB/Sceneview are not required for RSNA and the tutorial, re-targeted for 4.2.1. |
|
Seems that are still issue .. see http://na-mic.org/Bug/view.php?id=2512#c7257 |
|
Edited the mrml file to include the color file data in the mrml file rather than just in the color file. This fixed the missing color information in the scene views, but we still need to revisit mrb + deleting files + restoring scene views in general. |
|
confirmed that download and run test shows proper colors in scene views. |
|
Excellent. |
|
No update to the 4.2 branch needed, I uploaded a new revision of the mrb, the url didn't change. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-10-30 11:03 | nicole | New Issue | |
2012-10-30 11:03 | nicole | Status | new => assigned |
2012-10-30 11:03 | nicole | Assigned To | => nicole |
2012-10-30 11:03 | nicole | Relationship added | child of 0002514 |
2012-10-30 12:21 | nicole | Note Added: 0006932 | |
2012-10-30 12:22 | nicole | Note Edited: 0006932 | |
2012-10-30 12:23 | nicole | Note Edited: 0006932 | |
2012-10-30 12:51 | nicole | Note Added: 0006940 | |
2012-10-30 12:58 | nicole | File Added: Abdominal_Atlas_2012.mrml | |
2012-10-30 12:59 | nicole | Note Added: 0006941 | |
2012-10-30 13:37 | pieper | Assigned To | nicole => alexy |
2012-10-30 14:15 | pieper | Note Added: 0006943 | |
2012-10-30 14:15 | pieper | Status | assigned => confirmed |
2012-10-30 14:52 | alexy | Note Added: 0006946 | |
2012-10-30 14:52 | alexy | Status | confirmed => resolved |
2012-10-30 14:52 | alexy | Resolution | open => fixed |
2012-10-30 16:42 | nicole | Note Added: 0006952 | |
2012-10-30 16:53 | nicole | Note Added: 0006953 | |
2012-10-30 16:54 | nicole | Status | resolved => assigned |
2012-10-30 16:54 | nicole | Resolution | fixed => reopened |
2012-10-30 16:55 | nicole | Note Edited: 0006953 | |
2012-10-30 16:55 | nicole | Note Edited: 0006953 | |
2012-10-30 17:27 | alexy | Note Added: 0006954 | |
2012-10-30 18:06 | alexy | Note Added: 0006956 | |
2012-10-30 18:06 | alexy | Status | assigned => resolved |
2012-10-30 18:06 | alexy | Resolution | reopened => fixed |
2012-10-31 06:46 | nicole | Note Added: 0006964 | |
2012-10-31 06:46 | nicole | Assigned To | alexy => nicole |
2012-10-31 06:46 | nicole | Status | resolved => assigned |
2012-10-31 06:46 | nicole | Resolution | fixed => reopened |
2012-10-31 06:50 | pieper | Note Added: 0006965 | |
2012-10-31 07:00 | nicole | Note Added: 0006966 | |
2012-10-31 07:48 | nicole | Note Added: 0006971 | |
2012-10-31 07:51 | nicole | Note Edited: 0006971 | |
2012-10-31 08:23 | nicole | Note Added: 0006972 | |
2012-10-31 11:43 | jcfr | Target Version | Slicer 4.2.0 - coming release => Slicer 4.2.1 |
2012-10-31 11:43 | jcfr | Note Added: 0006987 | |
2012-11-15 13:45 | jcfr | Note Added: 0007261 | |
2012-11-16 12:02 | jcfr | Target Version | Slicer 4.2.1 => Slicer 4.2.2 |
2012-11-23 09:10 | nicole | Note Added: 0007354 | |
2012-11-23 09:10 | nicole | Status | assigned => resolved |
2012-11-23 09:10 | nicole | Fixed in Version | => Slicer 4.2.2 |
2012-11-23 09:10 | nicole | Resolution | reopened => fixed |
2012-11-23 09:11 | nicole | Note Added: 0007355 | |
2012-11-23 09:11 | nicole | Status | resolved => closed |
2012-11-24 08:01 | jcfr | Note Added: 0007359 | |
2012-11-26 05:35 | nicole | Note Added: 0007367 |