View Issue Details

IDProjectCategoryView StatusLast Update
0002704Slicer4Core: Building (CMake, Superbuild)public2017-06-07 23:27
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002704: Improve script allowing to "version" na-mic data tree
Description

See comments reported here: https://github.com/sankhesh/Slicer/commit/e86a3edd51682ef3224f363e13cdc1fb4036e55d

TagsNo tags attached.

Relationships

related to 0002561 closedjcfr Create script allowing to "version" na-mic data tree 

Activities

sankhesh

sankhesh

2012-10-31 12:41

developer   ~0006992

Pushed more commits towards improvement to topic: https://github.com/sankhesh/Slicer/commits/2561-version-namic-data-tree

sankhesh

sankhesh

2012-11-10 07:06

developer   ~0007150

From JC:

Thanks for working on this.

Seems method like getIDfromIndex, getFolderIndex, error, checkRequiredArguments, main should be hidden when the module midasdata will be imported.

What about adding a all member after the import (line 10) that would list all function that are suppose to be public ? See http://docs.python.org/2/tutorial/modules.html and http://stackoverflow.com/questions/2187583/whats-the-python-all-module-level-variable-for

sankhesh

sankhesh

2012-11-10 07:07

developer   ~0007151

Pushed the commit:
https://github.com/sankhesh/Slicer/commit/c0de6b64be288928136f09bb54330b3d41181ae3

jcfr

jcfr

2013-08-19 10:02

administrator   ~0009516

Fixed in r22296
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22296

jcfr

jcfr

2014-03-06 04:56

administrator   ~0010827

Closing resolved issues that have not been updated in more than 3 months

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014616

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 55902344

2013-08-19 14:01:05

jcfr

Details Diff
ENH: Script to version the na-mic data tree on Midas

This script can be used to duplicate the Nightly NA-MIC data tree on
Midas to a new folder tagged by the release version. The script used the
pydas api as well as some of Midas web-api for the methods not yet
ported to pydas. The script does not take any input arguments. All the
arguments should be provided as options using the option flags. For a
full list of options: "python release.py --help".
For now, it is assumed this script does not depend on slicer python. It
can be used from the regular python interpreter.

Added a function called versionData that takes the same arguments as
input as the command line module. This facilitates the use of this
script as a python importable module.
Improved documentation. Added docstring style documentation for
functions.

Added a new directory called release that will contain all scripts
that can be used when tagging Slicer for a new release. For example,
versioning Midas NA-MIC data tree, documentation generation, etc.

Added dry run functionality that prints the structure of the source
folder that is going to be duplicated. Made changes to test script as
well.

Added a an "_" before all functions that are not required by the user to
hide them.
Added an __all__ in the __init__.py for the package to know which module
it can import.
So, when you do a
from release import *
only, midasdata should be imported and not the unittest.

Fixes 0002561
Fixes 0002704

Co-authored-by: Jean-Christophe Fillion-Robin <JChris.FillionR@kitware.com>

From: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22296 3bd1e089-480b-0410-8dfb-8563597acbee
add - Base/Python/slicer/release/__init__.py Diff File
add - Base/Python/slicer/release/midasdata.py Diff File
add - Base/Python/slicer/release/midasdata_test.py Diff File

Issue History

Date Modified Username Field Change
2012-10-29 15:51 jcfr New Issue
2012-10-29 15:51 jcfr Status new => assigned
2012-10-29 15:51 jcfr Assigned To => jcfr
2012-10-29 15:51 jcfr Relationship added related to 0002561
2012-10-29 15:51 jcfr Assigned To jcfr => sankhesh
2012-10-29 15:51 jcfr Target Version => Slicer 4.3.0
2012-10-31 12:41 sankhesh Note Added: 0006992
2012-11-10 07:06 sankhesh Note Added: 0007150
2012-11-10 07:07 sankhesh Note Added: 0007151
2013-06-03 05:15 jcfr Assigned To sankhesh => jcfr
2013-08-19 10:02 jcfr Note Added: 0009516
2013-08-19 10:02 jcfr Status assigned => resolved
2013-08-19 10:02 jcfr Fixed in Version => Slicer 4.3.0
2013-08-19 10:02 jcfr Resolution open => fixed
2014-03-06 04:56 jcfr Note Added: 0010827
2014-03-06 04:58 jcfr Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 55902344
2017-06-07 23:27 jcfr Note Added: 0014616