View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002662Slicer4Core: Extensionspublic2012-10-17 14:542012-10-26 13:37
Reporterfedorov Assigned Tojcfr  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002662: logic is not initialized properly in Reporting extension
Description

logic is missing SlicerReportingModuleLogic methods, and the pointers do not match see below:

logic=slicer.modules.reporting.logic()
print logic
vtkSlicerReportingModuleLogic (0x138591340)
Debug: Off
Modified Time: 120708
Reference Count: 3
Registered Events:
Registered Observers:
vtkObserver (0x137e85420)
Event: 2
EventName: DeleteEvent
Command: 0x1350de8a0
Priority: 0
Tag: 2
vtkObserver (0x135083040)
Event: 2
EventName: DeleteEvent
Command: 0x1350e7880
Priority: 0
Tag: 3
vtkObserver (0x12a8ca620)
Event: 2
EventName: DeleteEvent
Command: 0x1350e9330
Priority: 0
Tag: 1
ClassName: vtkSlicerReportingModuleLogic
MRMLScene: 0x122c01f90
Active Parameter Node ID = null
Active Markup Hierarchy ID = null
Error Message none
GUI Hidden = true

logic
(vtkSlicerModuleLogic)0x1348b2c58

TagsNo tags attached.

Relationships

has duplicate 0002660 closedjcfr failure to load annotation libraries from some extensions 
related to 0002688 closedjcfr Fixup packaging of Tcl libraries 
related to 0002689 closedjcfr Fixup packaging of Python modules/libraries 

Activities

fedorov

fedorov

2012-10-17 15:08

developer   ~0006607

Not sure different pointer is the problem. Tested with Oct 7 nightly, and the pointers are also different, but logic is initialized properly and the methods are available:

logic=slicer.modules.reporting.logic()
logic
(vtkSlicerReportingModuleLogic)0x13953c890
print logic
vtkSlicerReportingModuleLogic (0x137ed5a10)
Debug: Off
Modified Time: 120879
Reference Count: 2
Registered Events:
Registered Observers:
vtkObserver (0x137ed5360)
Event: 2
EventName: DeleteEvent
Command: 0x137ed52f0
Priority: 0
Tag: 2
vtkObserver (0x137ed4830)
Event: 2
EventName: DeleteEvent
Command: 0x137ed5f50
Priority: 0
Tag: 3
vtkObserver (0x137ed6f00)
Event: 2
EventName: DeleteEvent
Command: 0x137ed4a60
Priority: 0
Tag: 1
ClassName: vtkSlicerReportingModuleLogic
MRMLScene: 0x10c13ff00
Active Parameter Node ID = null
Active Markup Hierarchy ID = null
Error Message none
GUI Hidden = true
fedorov

fedorov

2012-10-17 15:09

developer   ~0006608

but the difference is when I say "logic" in Oct 7, it prints vtkSlicerReportingModuleLogic, while with the latest build it says vtkSlicerModuleLogic
pieper

pieper

2012-10-17 15:13

administrator   ~0006609

Possibly related to this issue (SlicerRT extension installed on mac)

https://www.assembla.com/spaces/slicerrt/tickets/153?comment=182284313#comment:182284313
fedorov

fedorov

2012-10-17 15:19

developer   ~0006610

confirmed the issue is not reproducible on linux
jcfr

jcfr

2012-10-17 15:54

administrator   ~0006611

The difference of pointers can be explained by the fact calling (1) print the address of the python wrapper and calling (2) print the address of the associated C++ object.

(1) >>> logic

(2) >>> print logic

2012-10-25 07:32

 

2662-verify-patch-reporting-logic-properly-loaded.png (117,123 bytes)
jcfr

jcfr

2012-10-25 07:32

administrator   ~0006741

Fixed in r21242
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21242
jcfr

jcfr

2012-10-26 04:39

administrator   ~0006807

Confirmed that it works in today nightly: Slicer-4.2.0-rc1-2012-10-25-macosx-amd64.dmg

See http://slicer.cdash.org/viewFiles.php?buildid=44856

Issue History

Date Modified Username Field Change
2012-10-17 14:54 fedorov New Issue
2012-10-17 14:54 fedorov Status new => assigned
2012-10-17 14:54 fedorov Assigned To => jcfr
2012-10-17 15:08 fedorov Note Added: 0006607
2012-10-17 15:09 fedorov Note Added: 0006608
2012-10-17 15:13 pieper Note Added: 0006609
2012-10-17 15:19 fedorov Note Added: 0006610
2012-10-17 15:54 jcfr Note Added: 0006611
2012-10-22 07:21 jcfr Target Version => Slicer 4.2.0 - coming release
2012-10-25 07:28 jcfr Relationship added related to 0002688
2012-10-25 07:29 jcfr Relationship added related to 0002689
2012-10-25 07:32 jcfr File Added: 2662-verify-patch-reporting-logic-properly-loaded.png
2012-10-25 07:32 jcfr Note Added: 0006741
2012-10-25 07:32 jcfr Status assigned => resolved
2012-10-25 07:32 jcfr Fixed in Version => Slicer 4.2.0 - coming release
2012-10-25 07:32 jcfr Resolution open => fixed
2012-10-25 07:34 jcfr Relationship added has duplicate 0002660
2012-10-26 04:39 jcfr Note Added: 0006807
2012-10-26 13:37 fedorov Status resolved => closed