0002652: Launcher doesn't handle arguments added after --additional-module-paths - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0002652	Slicer4	Core: Base Code	public	2012-10-16 07:49	2017-06-07 23:27

Reporter	pinter	Assigned To	jcfr
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	Slicer 4.1.1
Target Version	Slicer 4.2.0	Fixed in Version	Slicer 4.2.0

Summary	0002652: Launcher doesn't handle arguments added after --additional-module-paths
Description	If --additional-module-paths is not the last argument added to the launcher, it will ignore the ones after it.
Additional Information	Example: This one works (runs the python code): D:\Slicer_Trunk_R64-bin\Slicer-build\Slicer.exe "--no-splash" "--testing" "--ignore-slicerrc" "--launcher-additional-settings" "D:/SlicerRT_SVN_src_R64-bin/inner-build/AdditionalLauncherSettings.ini" "--no-main-window" "--disable-cli-modules" "--python-code" "import slicer.testing; slicer.testing.runUnitTest(['D:/SlicerRT_SVN_src_R64-bin/inner-build/DicomRtImport/Testing/Python', 'D:/SlicerRT_SVN_src/DicomRtImport/Testing/Python'], 'DicomRtImportSelfTest')" "--additional-module-paths" "D:/SlicerRT_SVN_src_R64-bin/inner-build/lib/Slicer-4.1/qt-loadable-modules/Release" "D:/SlicerRT_SVN_src_R64-bin/inner-build/lib/Slicer-4.1/qt-scripted-modules" This one doesn't (python code is not executed): D:\Slicer_Trunk_R64-bin\Slicer-build\Slicer.exe "--no-splash" "--testing" "--ignore-slicerrc" "--launcher-additional-settings" "D:/SlicerRT_SVN_src_R64-bin/inner-build/AdditionalLauncherSettings.ini" "--no-main-window" "--disable-cli-modules" "--additional-module-paths" "D:/SlicerRT_SVN_src_R64-bin/inner-build/lib/Slicer-4.1/qt-loadable-modules/Release" "D:/SlicerRT_SVN_src_R64-bin/inner-build/lib/Slicer-4.1/qt-scripted-modules" "--python-code" "import slicer.testing; slicer.testing.runUnitTest(['D:/SlicerRT_SVN_src_R64-bin/inner-build/DicomRtImport/Testing/Python', 'D:/SlicerRT_SVN_src/DicomRtImport/Testing/Python'], 'DicomRtImportSelfTest')"
Tags	No tags attached.

pinter 2012-10-16 08:22 developer ~0006566	This issue captures the heart of the problem: https://github.com/commontk/CTK/issues/243

pinter 2012-10-16 09:40 developer ~0006569	Pushed to https://github.com/cpinter/Slicer/tree/2652-LauncherDoesntHandleArgumentsAddedAfterAdditionalModulePaths

pinter 2012-10-16 09:41 developer ~0006570	Can be reverted after fixing the CTK issue referenced above

jcfr 2012-10-16 11:47 administrator ~0006577	Looks good to me. Do you want me to integrate it ?

pinter 2012-10-16 12:00 developer ~0006578	Yes, please

jcfr 2012-10-16 13:23 administrator ~0006586	Fixed in r21201 See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21201

jcfr 2017-06-07 23:27 administrator ~0014546	Fix committed to 1683-launcher-with-output branch.

Slicer: 1683-launcher-with-output d195e7b2 2012-10-16 17:23:11 jcfr Details Diff	BUG: User arguments associated python unit tests are added last. The issue was that by using "--additional-module-paths" with a "s" it will prevent the parameter "--python-code" from being properly parsed. Indeed, the command line parser will think that it is an additional module path. The root cause of the problem lies into ctkCommandLineParser and is captured by issue https://github.com/commontk/CTK/issues/243 Thanks to Csaba Pinter for identifiying the issue and contributing a patch. See http://na-mic.org/Mantis/view.php?id=2652 Fixes 0002652 git-svn-id: http://svn.slicer.org/Slicer4/trunk@21201 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - CMake/SlicerMacroPythonTesting.cmake		Diff File

Date Modified	Username	Field	Change
2012-10-16 07:49	pinter	New Issue
2012-10-16 07:49	pinter	Status	new => assigned
2012-10-16 07:49	pinter	Assigned To	=> pieper
2012-10-16 08:22	pinter	Note Added: 0006566
2012-10-16 09:40	pinter	Note Added: 0006569
2012-10-16 09:41	pinter	Note Added: 0006570
2012-10-16 09:51	pieper	Assigned To	pieper => jcfr
2012-10-16 11:47	jcfr	Note Added: 0006577
2012-10-16 12:00	pinter	Note Added: 0006578
2012-10-16 13:23	jcfr	Note Added: 0006586
2012-10-16 13:23	jcfr	Status	assigned => resolved
2012-10-16 13:23	jcfr	Fixed in Version	=> Slicer 4.2.0 - coming release
2012-10-16 13:23	jcfr	Resolution	open => fixed
2012-10-16 13:33	pinter	Status	resolved => closed
2012-12-08 09:45	jcfr	Target Version	=> Slicer 4.2.0
2017-06-07 23:27	jcfr	Changeset attached	=> Slicer 1683-launcher-with-output d195e7b2
2017-06-07 23:27	jcfr	Note Added: 0014546