View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002648Slicer4Core: Building (CMake, Superbuild)public2012-10-15 12:542017-06-07 23:27
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002648: Rename macro "slicerMacroBuildQtModule" into "slicerMacroBuildLoadableModule"
Description

The fact the module depends on Qt is an implementation details. Since both scripted and loadable module can use Qt, it would be more correct to rename the macro.

Warning: Note that a lot of developer are using the macro slicerMacroBuildQtModule. This later one should be deprecated but not removed.

TagsDeprecation

Relationships

related to 0002647 closedjcfr Create a macro named slicerMacroBuildScriptedModule 
related to 0003332 closeddzenanz Rename file "SlicerMacroBuildQtModule.cmake" into "SlicerMacroBuildLoadableModule.cmake" 

Activities

jcfr

jcfr

2013-08-27 11:40

administrator   ~0009632

Fixed in r22342
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22342
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014606

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 374a7cae

2013-08-27 15:24:23

jcfr

Details Diff 		COMP: Add macro "slicerMacroBuildLoadableModule"

Both macros "slicerMacroBuildQtModule" and "slicerMacroBuildLoadableModule"
can be used. At this point, no warning message is displayed if the
deprecated macro is used.

Fixes 0002648

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22342 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerMacroBuildQtModule.cmake Diff File
mod - Extensions/Testing/SuperBuildExtensionTemplate/SuperLoadableModuleTemplate/CMakeLists.txt Diff File
mod - Modules/Loadable/Annotations/CMakeLists.txt Diff File
mod - Modules/Loadable/Cameras/CMakeLists.txt Diff File
mod - Modules/Loadable/Colors/CMakeLists.txt Diff File
mod - Modules/Loadable/CropVolume/CMakeLists.txt Diff File
mod - Modules/Loadable/Data/CMakeLists.txt Diff File
mod - Modules/Loadable/DoubleArrays/CMakeLists.txt Diff File
mod - Modules/Loadable/Markups/CMakeLists.txt Diff File
mod - Modules/Loadable/Measurements/CMakeLists.txt Diff File
mod - Modules/Loadable/Models/CMakeLists.txt Diff File
mod - Modules/Loadable/MultiVolumeRendering/CMakeLists.txt Diff File
mod - Modules/Loadable/Reformat/CMakeLists.txt Diff File
mod - Modules/Loadable/SceneViews/CMakeLists.txt Diff File
mod - Modules/Loadable/SlicerWelcome/CMakeLists.txt Diff File
mod - Modules/Loadable/TractographyDisplay/CMakeLists.txt Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/CMakeLists.txt Diff File
mod - Modules/Loadable/Transforms/CMakeLists.txt Diff File
mod - Modules/Loadable/Units/CMakeLists.txt Diff File
mod - Modules/Loadable/ViewControllers/CMakeLists.txt Diff File
mod - Modules/Loadable/VolumeRendering/CMakeLists.txt Diff File
mod - Modules/Loadable/Volumes/CMakeLists.txt Diff File

Issue History

Date Modified Username Field Change
2012-10-15 12:54 jcfr New Issue
2012-10-15 12:54 jcfr Status new => assigned
2012-10-15 12:54 jcfr Assigned To => jcfr
2012-10-15 12:54 jcfr Target Version => Slicer 4.3.0
2012-10-15 12:54 jcfr Relationship added related to 0002647
2013-02-15 10:46 jcfr Tag Attached: Deprecation
2013-08-27 11:14 jcfr Relationship added related to 0003332
2013-08-27 11:40 jcfr Note Added: 0009632
2013-08-27 11:40 jcfr Status assigned => resolved
2013-08-27 11:40 jcfr Fixed in Version => Slicer 4.3.0
2013-08-27 11:40 jcfr Resolution open => fixed
2013-08-27 11:40 jcfr Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 374a7cae
2017-06-07 23:27 jcfr Note Added: 0014606