View Issue Details

IDProjectCategoryView StatusLast Update
0002629Slicer4Core: Usabilitypublic2012-12-08 09:45
Reporterfedorov Assigned Tomillerjv  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002629: Crosshair does not work
Description

1) navigation mode does not work -- w/l is changed instead
2) crosshair + shift does not work (crosshair does not follow mouse when shift is pressed)

TagsNo tags attached.

Activities

millerjv

millerjv

2012-10-11 13:52

developer   ~0006501

Fixed in r21160.

DisplayableManagers can not observe events directly on the Interactor instead of the InteractorStyle. The InteractorStyle was swallowing the LeftButtonPressEvent which the Crosshair navigation mode needed.

Added priorities to events in DisplayableManagers.

Added Abort flag to events on the Interactor for the DisplayableManagers.

fedorov

fedorov

2012-10-14 15:36

developer   ~0006522

Tested with r21181, both issues appear to be unresolved, or maybe I am missing something, see screencast here: http://www.screencast.com/t/yYxDSKuhtHw

millerjv

millerjv

2012-10-14 18:31

developer   ~0006524

r21165 breaks the fix in r21160.

r21165 was introduced to fix a crash in the 3D Viewer introduced in r21160.

r21165 look harmless. Not sure why it breaks r21160.

millerjv

millerjv

2012-10-15 08:07

developer   ~0006537

Fixed (again) in r21186.

Moved the fix in r21165 down a couple of lines. For some reason, this makes a difference. In both configurations, the events registered by AdditionalInitializeStep() are cached until later in the setup. So it shouldn't make a difference. But somehow, having the interactor cached early, causes the events registered in AdditionalInitializeStep() to be lost.

"git bisect" ROCKS!

fedorov

fedorov

2012-10-16 10:53

developer   ~0006571

Jim, I tested this, and it looks like it depends on how fast I move
the mouse whether I will see the crosshair in the other slices or not.
Looks like the most reliable is to use navigation mode, in which case
it syncs everything pretty well.

Also, at least for my main use case of crosshairs, all slice viewers
are showing the same slice location, so there is no need to change
slice and crosshair will work as expected, so as far as I am
concerned, the issue is resolved. Thank you!

Issue History

Date Modified Username Field Change
2012-10-09 11:24 fedorov New Issue
2012-10-09 11:24 fedorov Status new => assigned
2012-10-09 11:24 fedorov Assigned To => kikinis
2012-10-09 11:24 fedorov Assigned To kikinis => millerjv
2012-10-11 13:52 millerjv Note Added: 0006501
2012-10-11 13:52 millerjv Status assigned => resolved
2012-10-11 13:52 millerjv Resolution open => fixed
2012-10-14 15:36 fedorov Note Added: 0006522
2012-10-14 15:36 fedorov Status resolved => feedback
2012-10-14 15:36 fedorov Resolution fixed => reopened
2012-10-14 18:31 millerjv Note Added: 0006524
2012-10-15 08:07 millerjv Note Added: 0006537
2012-10-15 08:07 millerjv Status feedback => resolved
2012-10-15 08:07 millerjv Resolution reopened => fixed
2012-10-16 10:53 fedorov Note Added: 0006571
2012-10-16 10:53 fedorov Status resolved => closed
2012-10-16 10:53 fedorov Fixed in Version => Slicer 4.2.0 - coming release
2012-12-08 09:45 jcfr Target Version => Slicer 4.2.0