View Issue Details

IDProjectCategoryView StatusLast Update
0002581Slicer4Core: MRMLpublic2012-10-22 03:50
Reporterkikinis Assigned Tofinetjul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002581: hiding closest anatomy letter in 3D view stops working after VR and scene close
Description

Closest letter to camera of the RL/PA/IS notes around box should be hidden; this works at startup but not after closing scene after using VR.

Steps To Reproduce

Start slicer
Download sample volume
Turn on volume rendering
Close scene
=> changing view no longer causes letters to change visibility.

TagsNo tags attached.

Activities

pieper

pieper

2012-09-29 07:15

administrator   ~0006277

Mail trail

On Fri, Sep 28, 2012 at 5:55 PM, Ron Kikinis <kikinis@bwh.harvard.edu> wrote:

You are right: load volume, close scene, load volume, volume render. Make
sure you use the cpu ray caster. The NCI ray caster does not composit
properly so the letter ends up behind the volume renderer in any case.

On 9/28/12 11:15 PM, Steve Pieper wrote:

The display of the annotation letters is working on my mac, linux, and
windows builds. It also works for me on the 2012-09-27 mac nightly.
Ron, what steps did you do that led to the letters not hiding as
expected? Was it after reloading an older scene?

-Steve

On Fri, Sep 28, 2012 at 1:34 PM, Nicole Aucoin <nicole@bwh.harvard.edu>
wrote:

The change I made should only be triggered on scene view restores.

Nicole

On 09/28/2012 01:00 PM, Julien Finet wrote:

Not sure what happened, maybe I did.
Nicole has also touched the camera displayable manager.
Alex, how did you turn off the orientation annotations ?

Julien.

On Fri, Sep 28, 2012 at 7:21 AM, Ron Kikinis <kikinis@bwh.harvard.edu
<mailto:kikinis@bwh.harvard.edu>> wrote:

 Hi,

 a few months ago, Alex changed the behavior of the orientation
 annotations in the 3d viewer. Essentially the letters were not
 visible, when they were in a cone of 45degrees around the viewray.
 I noticed in this morning mac nightly that this suppression has
 disappeared. Who removed it and why?

 Ron
 --     Ron Kikinis, M.D.,
 Robert Greenes Distinguished Director of Biomedical Informatics
 Professor of Radiology, Harvard Medical School
 Director, Surgical Planning Laboratory
 http://www.spl.harvard.edu/~kikinis
 &lt;http://www.spl.harvard.edu/%7Ekikinis>

--
Ron Kikinis, M.D.,
Robert Greenes Distinguished Director of Biomedical Informatics
Professor of Radiology, Harvard Medical School
Director, Surgical Planning Laboratory
http://www.spl.harvard.edu/~kikinis

alexy

alexy

2012-09-29 10:33

developer   ~0006282

After closing the scene vtkMRMLCameraNode does not observe vtkCamera somehow.
I think it is related to Julien's change in vtkMRMLCameraDisplayableManager.cxx,
Revision: 21037

finetjul

finetjul

2012-09-29 20:53

administrator   ~0006286

Fixed in r21081:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=21081

Issue could be reproduced by:
Start Slicer
Close Scene
-> labels not updated.

Commit r21082 cleanups the code a bit.

Issue History

Date Modified Username Field Change
2012-09-29 07:14 pieper New Issue
2012-09-29 07:14 pieper Status new => assigned
2012-09-29 07:14 pieper Assigned To => alexy
2012-09-29 07:15 pieper Note Added: 0006277
2012-09-29 10:33 alexy Note Added: 0006282
2012-09-29 10:33 alexy Assigned To alexy => finetjul
2012-09-29 18:55 finetjul Reporter pieper => kikinis
2012-09-29 18:55 finetjul Category Module VolumeRendering => MRML
2012-09-29 20:53 finetjul Note Added: 0006286
2012-09-29 20:53 finetjul Status assigned => resolved
2012-09-29 20:53 finetjul Fixed in Version => Slicer 4.2.0 - coming release
2012-09-29 20:53 finetjul Resolution open => fixed
2012-10-22 03:50 kikinis Status resolved => closed