View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002567 | Slicer4 | Core: QtTesting | public | 2012-09-25 10:56 | 2014-04-22 10:09 |
Reporter | jcfr | Assigned To | jcfr | ||
Priority | low | Severity | minor | Reproducibility | have not tried |
Status | acknowledged | Resolution | open | ||
Product Version | |||||
Target Version | Fixed in Version | ||||
Summary | 0002567: Add screenshot based comparison to test using QtTesting | ||||
Description |
Will let you come with a design/approach ... (re-use VTK facilities ? Implement new one in CTK ? Re-use QtTest image compare if any ?) | ||||
Tags | No tags attached. | ||||
I am currently working on a new class qSlicerCoreTestingUtility under Slicer/Base/QTCore that defines overloaded image compare methods. This class uses vtkTesting::RegressionTest to do the image compare. The initial effort is to integrate image comparison with the current testing framework. Next, I will add a test driver and modify the existing cmake macro "slicer_add_python_test" that eliminates the need for the additional python file per xml script. The idea is that when someone records a test, all they need to do is add a line - |
|
Pushed new topic with initial changes: |
|
Update: Added some versatility methods. There seems to be an issue with the image comparison implementation when I give it a QWidget and it has to grab a screenshot and compare with baseline image. |
|
FYI - Commit associated with CTK issue 248 has been integrated to CTK. |
|
Made some progress on the topic. Added a convenience cmake macro to add new qttesting tests and removed dependency on additional python script. Next, going to change existing qttesting based tests to use new macro as example. |
|
Testing Data Baselines are now on Midas. Added functionality to fetch baselines while building for qttesting tests using ExternalData.cmake. Kindly review. Copied from note added by mistake to issue 2060 on Dec 2012-12-07: // ----------------------------------------- Consider also reading: http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/UploadTestData // -------------- Hi Sankhesh,
For the qttesting baseline, let's use the ExternalData approach. Moving forward, the idea would be to consolidate ExternalData.cmake to also provide the functionality of Midas.cmake. Is is something you would like to work on ? // ----------------------------------------- Added functionality to specify a URL for baseline image that will be downloaded before testing. |
|
For reference: https://github.com/sankhesh/Slicer/commits/2567-screenshot-based-testing [^] |
|
Would be great if you could rebase the topic against the current Slicer master branch. |
|
Latest code pushed based on suggestions. Kindly review. |
|
Thanks. See comments: https://github.com/sankhesh/Slicer/commits/2567-screenshot-based-testing |
|
Cleaned up branch and squashed minor commits. Kindly review and let me know your comments/suggestions. https://github.com/sankhesh/Slicer/commits/2567-screenshot-based-testing |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-09-25 10:56 | jcfr | New Issue | |
2012-09-25 10:56 | jcfr | Status | new => assigned |
2012-09-25 10:56 | jcfr | Assigned To | => jcfr |
2012-09-25 10:56 | jcfr | Assigned To | jcfr => sankhesh |
2012-09-25 10:56 | jcfr | Priority | normal => low |
2012-09-25 10:56 | jcfr | Target Version | => Slicer 4.2.0 - coming release |
2012-09-25 10:57 | jcfr | Relationship added | related to 0002494 |
2012-10-23 12:55 | jcfr | Target Version | Slicer 4.2.0 - coming release => Slicer 4.3.0 |
2012-11-14 04:21 | sankhesh | Status | assigned => confirmed |
2012-11-15 08:50 | sankhesh | Relationship added | related to 0002060 |
2012-11-15 08:56 | sankhesh | Note Added: 0007249 | |
2012-11-18 07:44 | sankhesh | Note Added: 0007307 | |
2012-11-21 08:14 | sankhesh | Note Added: 0007336 | |
2012-11-21 10:09 | jcfr | Note Added: 0007341 | |
2012-11-30 07:31 | sankhesh | Note Added: 0007384 | |
2012-12-12 08:21 | sankhesh | Note Added: 0007493 | |
2012-12-12 08:21 | sankhesh | Status | confirmed => feedback |
2012-12-12 16:10 | jcfr | Note Added: 0007499 | |
2012-12-12 16:11 | jcfr | Note Edited: 0007499 | |
2012-12-12 16:12 | jcfr | Note Edited: 0007499 | |
2012-12-12 16:12 | jcfr | Note Edited: 0007493 | |
2012-12-12 16:14 | jcfr | Note Edited: 0007493 | |
2012-12-12 16:15 | jcfr | Note Edited: 0007493 | |
2013-03-09 11:26 | jcfr | Note Added: 0008104 | |
2013-03-18 09:09 | sankhesh | Note Added: 0008137 | |
2013-03-19 08:05 | jcfr | Note Added: 0008146 | |
2013-03-21 10:39 | sankhesh | Note Added: 0008192 | |
2013-06-03 05:15 | jcfr | Status | feedback => assigned |
2013-06-03 05:15 | jcfr | Assigned To | sankhesh => jcfr |
2013-08-27 11:45 | jcfr | Target Version | Slicer 4.3.0 => Slicer 4.4.0 |
2014-04-22 10:09 | jcfr | Status | assigned => acknowledged |
2014-04-22 10:09 | jcfr | Target Version | Slicer 4.4.0 => |