View Issue Details

IDProjectCategoryView StatusLast Update
0002560Slicer4Core: Base Codepublic2017-06-07 23:27
Reportermillerjv Assigned Tonicole  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002560: Models module does not have help popups on the gui elements
Description

No help popups are displayed when hovering over the gui elements in the Models module.

Help popups would be very useful for the Clipping section as it is unclear what it is that you keep or discard. It is also unclear what the positive and negative directions of each canonical axis are.

TagsNo tags attached.

Activities

finetjul

finetjul

2012-09-25 16:23

administrator   ~0006218

Last edited: 2012-09-25 16:23

Assigned to Nicole, she is in charge of the Models module (c.f. http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly)

nicole

nicole

2013-07-09 08:15

administrator   ~0008947

I dug through the code, and looked at Slicer3, and this hasn't had any good documentation that I could find. It points back to the vtkImplicitBoolean class which is also sparse on documentation.
For reference, toolTip properties need to be added to the file
Libs/MRML/Widgets/Resources/UI/qMRMLClipNodeWidget.ui

nicole

nicole

2013-07-17 08:33

administrator   ~0009097

Digging deeper, it turns out that "clip" means something else to VTK than what I'd assume.

Starting from the Slicer coordinate system documentation:
http://www.slicer.org/slicerWiki/index.php/Coordinate_systems#Anatomical_coordinate_system
Which says:
the axial plane is parallel to the ground and separates the head (Superior) from the feet (Inferior)
the coronal plane is perpendicular to the ground and separates the front from (Anterior) the back (Posterior)
the sagittal plane separates the Left from the Right

And checking the models module clipping documentation:
http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Modules/Models
which says:
Red Slice Clipping: Control on which side of the red slice plane is clipped on the model
Yellow Slice Clipping: Control on which side of the yellow slice plane is clipped on the model
Green Slice Clipping: Control on which side of the green slice plane is clipped on the model

I added this tool tip to the Red Slice Clipping checkbox:
Use the positive or negative space defined by the Red slice plane to clip the model. Positive side is toward the Superior, negative is toward the Inferior
And this on the positive radio buttons:
Use the positive space, toward the Superior (head), defined by the Red slice plane to clip the model.

But when I turn on positive clipping on the red slice, the part of the model on the Superior side of the red slice plane is visible, and the part of the model on the Inferior side of the red slice plane is invisible.

This seems that what the application is defining as clipping in the positive space is:
Hide the part of the model that is in the negative space defined by the slice plane and show what's on the positive side.
I was assuming that picking the positive option would clip away the positive side of the model and leave the negative side visible.

Digging into the code, the clipping widget slot updateNodeRedClipState calls:
this->setRedSliceClipState(this->redSliceClipState());
redSliceClipState will return ClipPositiveSpace if the red slice box is checked and the positive radio button is checked.
setRedSliceClipState will call SetRedSliceClipState on the MRMLClipNode
which is a vtkMRMLClipModelsNode, with the clip state defined as 0=off, 1=positive, 2=negative
In vtkMRMLModelDisplayableManager sets the plane direction by checking against the clip negative space enum (if the slice clip state is clip negative, set the plane direction to -1, otherwise to 1).
vtkClipPolyData documentation says:
"... returning everything inside of the specified implicit function"
which I think does imply that it's going to return things on the side you say, rather than the other side...
So if I pick to clip on the positive side, that's defined as "inside" my function, and it's going to return the part of the model on the positive side of the plane.

This isn't quite what I'd expect as a user from the word clip, so the next question is does this make sense as an updated tool tip:
Use the positive or negative space defined by the Red slice plane to clip the model. The part of the model in the selected space is kept, parts outside of it are clipped away. Positive side is toward the Superior, negative is toward the Inferior.

nicole

nicole

2013-07-17 11:57

administrator   ~0009110

Last edited: 2013-07-17 12:03

Tool tips checked in to svn:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22206
and updated documentation:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22207

jcfr

jcfr

2014-03-06 04:56

administrator   ~0010808

Closing resolved issues that have not been updated in more than 3 months

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 22170a3d

2013-07-17 15:56:27

naucoin

Details Diff
STYLE: add tool tips to the clipping widget

Explain what is meant by the clipping terms and positive/negative
spaces.

Issue 0002560



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22206 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Resources/UI/qMRMLClipNodeWidget.ui Diff File

Slicer: 2145-support-for-installing-extension-from-file b2dd1e54

2013-07-17 16:02:53

naucoin

Details Diff
STYLE: update clipping documentation

Use the text strings from the MRML clip node widget.

Issue 0002560



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22207 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/Documentation/Models.xml Diff File

Issue History

Date Modified Username Field Change
2012-09-24 08:08 millerjv New Issue
2012-09-24 08:08 millerjv Status new => assigned
2012-09-24 08:08 millerjv Assigned To => pieper
2012-09-24 13:12 pieper Assigned To pieper => finetjul
2012-09-25 16:22 finetjul Assigned To finetjul => nicole
2012-09-25 16:23 finetjul Note Added: 0006218
2012-09-25 16:23 finetjul Note Edited: 0006218
2012-12-08 10:12 jcfr Target Version => Slicer 4.3.0
2013-07-09 08:15 nicole Note Added: 0008947
2013-07-17 08:33 nicole Note Added: 0009097
2013-07-17 08:35 nicole Status assigned => feedback
2013-07-17 11:57 nicole Note Added: 0009110
2013-07-17 11:57 nicole Status feedback => resolved
2013-07-17 11:57 nicole Fixed in Version => Slicer 4.3.0
2013-07-17 11:57 nicole Resolution open => fixed
2013-07-17 12:03 nicole Note Edited: 0009110
2014-03-06 04:56 jcfr Note Added: 0010808
2014-03-06 04:58 jcfr Status resolved => closed
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file b2dd1e54
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file 22170a3d