View Issue Details

IDProjectCategoryView StatusLast Update
0002546Slicer4Core: Base Codepublic2012-12-08 09:42
Reporterinorton Assigned Toalexy  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002546: Slicer tries to save removed nodes.
Description

See screenshot. I deleted all of the *intraop nodes using the data view. They still show up in the Save menu.

TagsNo tags attached.

Activities

2012-09-23 13:41

 

slicer-ss-23sep.png (185,846 bytes)
slicer-ss-23sep.png (185,846 bytes)
finetjul

finetjul

2012-09-23 18:11

administrator   ~0006175

Last edited: 2012-09-23 18:13

The nodes you see belong to the scene view.
Behavior introduced in r20859 ( issue 0002229 ).

It is not possible to save those nodes (no extension to save) because the MRML scene of the storable nodes scene doesn't contain a DataIOMAnager (vtkMRMLVolumeArchetypeStorageNode::InitializeSupportedWriteFileTypes fails).

Isaiah, it would be good to have a Step by Step procedure to reproduce (I failed at reproducing at first).

inorton

inorton

2012-09-23 18:19

developer   ~0006176

Work, save, close, re-open, work, save, close, etc. Nothing unusual. It has happened for multiple separate scenes over past three days. These are mainly scalar nodes, except for one diffusiontensor node. I'm running 9/10 nightly, but Sonia confirmed this bug to me and she is using 9/19 nightly. I'm not using scene views at all.

alexy

alexy

2012-09-25 13:01

developer   ~0006209

Isaiah, are you loading an existing scene or creating a new one. If first can you provide the scene with the data?

alexy

alexy

2012-09-25 13:05

developer   ~0006210

Actually, if those nodes were in the scene at some point (and in the master scene view) this may be the expected new behavior. Save dialog exposes storable nodes that are present in scene views but not in the main scene. You don't have to save them though.

inorton

inorton

2012-09-25 13:52

developer   ~0006211

The nodes were in the scene and then I deleted them. I had loaded and saved the scene several times before deleting these nodes.

As far as I know, there were no scene views involved because I never created any.

It is already difficult to be certain everything is saved in the correct directory, correct format, and with a correct and unique name. I think it would be very unfortunate to require users to mentally disambiguate multiple versions/views of data from this long list in order to make sure the changes are properly saved.

Also, in cases where the format menu is not selectable, it's unclear what is the purpose of displaying these rows if the nodes/ghosts cannot actually be saved.

finetjul

finetjul

2012-09-25 15:18

administrator   ~0006214

For information a sceneview node is automatically created when you save the scene.
So when you load it again, you have a scene view.

inorton

inorton

2012-09-25 15:38

developer   ~0006215

I should have been more precise: I never explicitly created any extra scene view.

As an aside, this explains something else: every time I reload the scene, there is another pair of "view" and "camera" nodes. Saving and reloading a few times means that I now have 8 or 10 of these extra nodes.

finetjul

finetjul

2012-09-25 15:42

administrator   ~0006216

For the aside, the sceneview node doesn't explain why "view"s and "camera"s are duplicated.
This is explained because the scene is "imported" and not "connected". With "connect", the existing scene is cleared before "import". Which prevents duplication.
As of last week, the "view"s shouldn't be duplicated anymore because they are now singletons. Maybe cameras should be singletons as well...

alexy

alexy

2012-10-06 05:13

developer   ~0006413

Fixed by stopping saving storable nodes in the Main Scene View since they either in the main scene or are deleted on purpose.

Isaiah, if you delete those extra nodes and save the scene they should not come back.

Issue History

Date Modified Username Field Change
2012-09-23 13:41 inorton New Issue
2012-09-23 13:41 inorton Status new => assigned
2012-09-23 13:41 inorton Assigned To => pieper
2012-09-23 13:41 inorton File Added: slicer-ss-23sep.png
2012-09-23 14:19 pieper Assigned To pieper => finetjul
2012-09-23 18:08 finetjul Assigned To finetjul => alexy
2012-09-23 18:11 finetjul Note Added: 0006175
2012-09-23 18:13 finetjul Note Edited: 0006175
2012-09-23 18:19 inorton Note Added: 0006176
2012-09-25 13:01 alexy Note Added: 0006209
2012-09-25 13:05 alexy Note Added: 0006210
2012-09-25 13:52 inorton Note Added: 0006211
2012-09-25 15:18 finetjul Note Added: 0006214
2012-09-25 15:38 inorton Note Added: 0006215
2012-09-25 15:42 finetjul Note Added: 0006216
2012-10-06 05:13 alexy Note Added: 0006413
2012-10-06 05:13 alexy Status assigned => resolved
2012-10-06 05:13 alexy Resolution open => fixed
2012-10-25 13:43 inorton Status resolved => closed
2012-10-25 13:43 inorton Fixed in Version => Slicer 4.2.0 - coming release
2012-12-08 09:42 jcfr Target Version => Slicer 4.2.0