Regression from r20972:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20972

Node is being removed from scene and deleted, but vtkMRMLModelSliceDisplayableManager ignores it (vtkMRMLModelSliceDisplayableManager
::OnMRMLSceneNodeRemoved) and doesn't remove its pointer to it.

Unfortunately, r20972 doens't refer to an issue number :-P
After investigation it appears it's due to issue 0002428

The model slice displayable manager might have to respond to the batch processing end event to reset itself to the update scene then.

In 0002428 comment 0006037, it is said that GetDisplayNode() was called, however I can't see in the code where it is (except in a rendering routine).
I suggest that:

• vtkMRMLModelSliceDisplayableManager::OnMRMLSceneNodeRemoved removes the node as before
• but doesn't trigger a refresh if in batch processing
  Steve, if it works and tests pass, do you think it's a valid solution ?

Hi Julien -

As I recall, GetDisplayNodes was being called as a byproduct of AddDisplayableNode in vtkMRMLModelSliceDisplayableManager::OnMRMLSceneNodeAdded so a render wasn't required (although it could be triggered - see new child issue).

GetDisplayNodes was causeing the polydata from the displayble node to be assigned into the wrong display node pipeline and lots of stuff was broken. :/

So as long as GetDisplayNodes isn't called when batch processing is being performed then we should be okay with your other changes.

-Steve

Fixed in r21025

Steve, r20972 was not about AddDisplayableNode (OnMRMLSceneNodeAdded) but about OnMRMLSceneNodeRemoved

The source of the bad behavior was fixed here:

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20970

20972 was added for consistency.

Closing resolved issues that have not been updated in more than 3 months