0002530: Display is not updated when changing a transform - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0002530	Slicer4	Core: GUI	public	2012-09-17 15:08	2012-12-08 09:48

Reporter	lassoan	Assigned To	finetjul
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version
Target Version	Slicer 4.2.0	Fixed in Version	Slicer 4.2.0

Summary	0002530: Display is not updated when changing a transform
Description	If the Data module is used to create transforms and chain them by drag-and-drop then changing a transform will not update the display. How to reproduce: Download MRHead sample Go to Data module Right-click on Scene, Insert transform => LinearTransform_3 is created Right-click on LinearTransform_3, Insert transform => LinearTransform_4 is created, under LinearTransform_3 Drag-and-drop MRHead image to LinearTransform_4 => MRHead image is under LinearTransform_4 Go to transforms module Modify LinearTransform_4 => the MRHead image moves in the slice viewer Modify LinearTransform_3 => ERROR: the position of the MRHead image does not change in the slice viewer Notes: Neither the slice viewers, nor the 3D viewers are updated If an update of the viewer is enforced (e.g., changing slice, modfiying zoom) then the image jumps into its correct position, so internally the update is completed, only the viewers are not notified If LinearTransform_3 is applied to LinearTransform_4 in the Transforms module then the update works correctly, so it seems that something is wrong in how the Data module applies the transform and sets up observers Tested on Slicer-4.1.0-2012-09-14-win-amd64.exe
Tags	No tags attached.

finetjul 2012-09-23 19:00 administrator ~0006177	Fixed in r21038

lassoan 2012-10-03 03:57 developer ~0006356	Thank you very much for the fix, the reported problem does not occur any more. I've just reopened the bug instead of closing it to make sure you check the comment below. The r21038 commit was only a corrective action for one specific occurrence of the issue, but nothing prevents the problem happening again, somewhere else, at another time, without noticing. As a preventive action, the observers should be always added/updated when the node is added to a scene (this way the code would work correctly regardless of the calling order of the AddNode and SetAndObserveTransformNodeID).

finetjul 2012-10-03 04:41 administrator ~0006359	I'm well aware of that :-) it's emphasized in the currently disabled test added in r20998. Consider monitoring 0002539 to follow the resolution. Has to happen after 4.2 as it is a critical change.

lassoan 2012-10-03 05:50 developer ~0006360	Great, thanks!

Date Modified	Username	Field	Change
2012-09-17 15:08	lassoan	New Issue
2012-09-17 15:08	lassoan	Status	new => assigned
2012-09-17 15:08	lassoan	Assigned To	=> kikinis
2012-09-17 18:18	kikinis	Assigned To	kikinis => finetjul
2012-09-23 19:00	finetjul	Note Added: 0006177
2012-09-23 19:00	finetjul	Status	assigned => resolved
2012-09-23 19:00	finetjul	Fixed in Version	=> Slicer 4.2.0 - coming release
2012-09-23 19:00	finetjul	Resolution	open => fixed
2012-10-03 03:57	lassoan	Note Added: 0006356
2012-10-03 03:57	lassoan	Status	resolved => feedback
2012-10-03 03:57	lassoan	Resolution	fixed => reopened
2012-10-03 04:41	finetjul	Note Added: 0006359
2012-10-03 04:41	finetjul	Status	feedback => resolved
2012-10-03 04:41	finetjul	Resolution	reopened => fixed
2012-10-03 05:50	lassoan	Note Added: 0006360
2012-10-03 05:50	lassoan	Status	resolved => closed
2012-11-06 04:56	alexy	Relationship added	related to 0002725
2012-12-08 09:48	jcfr	Target Version	=> Slicer 4.2.0