View Issue Details

IDProjectCategoryView StatusLast Update
0002458Slicer4Core: Building (CMake, Superbuild)public2012-12-08 09:57
Reportersankhesh Assigned Tosankhesh  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002458: Building without PythonQt - CMake error
Description

Config: Ubuntu 12.04 LTS, GCC-4.6.3, Slicer4(08/31/2012)

Fresh build of Slicer4 with
Slicer_USE_PYTHONQT = OFF
Slicer_USE_PYTHONQT_TCL = OFF

Build fails with the following error:
CMake Error at Slicer/bld/EMSegment/Qt/Py/CMakeLists.txt:33 (ctkMacroCompilePythonScript):
Unknown CMake command "ctkMacroCompilePythonScript"

TagsNo tags attached.

Activities

sankhesh

sankhesh

2012-08-31 05:44

developer   ~0005902

Basically, the Slicer_USE_PYTHONQT cmake variable needs to be passed on to external projects (I verified the bug for EMSegment and MultiVolumeExplorer).

if(Slicer3_USE_PYTHONQT)
add_subdirectory(Py)
endif(Slicer3_USE_PYTHONQT)

jcfr

jcfr

2012-09-03 05:27

administrator   ~0005929

Since EMSegment required python, I would suggest we simply disable it if python is not enabled in Slicer.

sankhesh

sankhesh

2012-09-05 07:40

developer   ~0005971

Topic pushed to https://github.com/sankhesh/Slicer/tree/2458-building-without-pythonqt

jcfr

jcfr

2012-09-05 10:59

administrator   ~0005974

An issue should be considered resolved after it has been integrated into the code base. Before doing so, consider the comment I added on github.

sankhesh

sankhesh

2012-09-06 07:42

developer   ~0005993

jcfr:
Shouldn't it be

Slicer_BUILD_BRAINSTOOLS AND Slicer_BUILD_QTLOADABLEMODULES AND
Slicer_USE_PYTHONQT

instead of

Slicer_BUILD_BRAINSTOOLS AND Slicer_BUILD_QTLOADABLEMODULES;Slicer_USE_PYTHONQT

sankhesh

sankhesh

2012-09-06 07:43

developer   ~0005994

Fixed as per jcfr's suggestion and pushed topic to:
https://github.com/sankhesh/Slicer/commits/2458-building-without-pythonqt

jcfr

jcfr

2012-09-13 10:47

administrator   ~0006058

Thanks for pushing the fix.

Next time would be great to squash the commit before integrating to Slicer. It seems strange to see to commit having the exact same message but different changeset. See r20959 and r20960

Issue History

Date Modified Username Field Change
2012-08-31 05:12 sankhesh New Issue
2012-08-31 05:12 sankhesh Status new => assigned
2012-08-31 05:12 sankhesh Assigned To => jcfr
2012-08-31 05:44 sankhesh Note Added: 0005902
2012-08-31 05:49 sankhesh Assigned To jcfr => sankhesh
2012-09-03 05:27 jcfr Note Added: 0005929
2012-09-05 07:40 sankhesh Note Added: 0005971
2012-09-05 08:17 sankhesh Status assigned => resolved
2012-09-05 08:17 sankhesh Resolution open => fixed
2012-09-05 10:59 jcfr Note Added: 0005974
2012-09-05 10:59 jcfr Status resolved => assigned
2012-09-06 07:42 sankhesh Note Added: 0005993
2012-09-06 07:43 sankhesh Note Added: 0005994
2012-09-12 12:07 sankhesh Status assigned => resolved
2012-09-13 10:47 jcfr Note Added: 0006058
2012-09-13 10:47 jcfr Status resolved => closed
2012-09-13 10:47 jcfr Fixed in Version => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2012-12-08 09:57 jcfr Target Version => Slicer 4.2.0