View Issue Details

IDProjectCategoryView StatusLast Update
0002454Slicer4Module Editorpublic2017-06-07 23:27
Reporterfedorov Assigned Tofedorov  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0002454: Add FastMarching effect to Editor
Description

This is a module that was available in Slicer3. Ron would really like to have this functionality in Slicer4.

One of the main issues is resolving the occasional stability issues in the Slicer3 code, which requires review and understanding of the Fast marching algorithm implementation. The implementation is available as a set of VTK filters.

TagsNo tags attached.

Activities

fedorov

fedorov

2013-02-14 08:12

developer   ~0007927

Effect as extension WIP on github: https://github.com/fedorov/FastMarchingEffect

Optimization modifications to the filter in Slicer trunk: r21701.

fedorov

fedorov

2013-02-16 08:46

developer   ~0007965

Last edited: 2013-02-16 08:49

From: Steve Pieper
Date: Fri, Feb 15, 2013 at 2:04 PM
Subject: Re: FastMarching effect: pre-commit check would be great
To: Andrey Fedorov

I think you are right - I just commented out that error message and things worked for me.

I have to say, it actually worked pretty great for me - see attached. I think that's valuable enough that we should go ahead with putting it in the trunk.

But I do think we should add a progress dialog for the apply step, and also disable the volume slider until is is actually useful.

I was also thinking that a self test would be good, but not strictly essential.

Also, it needs to handle undo/redo correctly.

-Steve

fedorov

fedorov

2013-02-16 08:46

developer   ~0007966

From: Ron Kikinis <kikinis@bwh.harvard.edu>
Date: Sat, Feb 16, 2013 at 12:48 PM
Subject: fast marching
To: Andriy Fedorov <fedorov@bwh.harvard.edu>

Andrey,

when I worked with Harini on the UI for growcut we used the initialization provided by the user to define a volume of interest. Essentially you take the extent of the initialization add a 50% safety margin and assume the VOI has the same dimension in all directions. Such an approach would allow to remove one of the two sliders in your interface.

Ron

fedorov

fedorov

2013-02-16 08:48

developer   ~0007967

Another comment from Ron: make sure the slider has sufficient resolution to allow precision

fedorov

fedorov

2013-02-21 08:50

developer   ~0007994

initial commit to trunk in r21758.

Remaining item: self-test

jcfr

jcfr

2014-07-29 12:13

administrator   ~0012277

Editor effect has been added: See Modules/Scripted/EditorLib/FastMarchingEffect

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file ab13c5c7

2013-02-21 13:49:53

fedorov

Details Diff
ENH: adding FastMarching effect to Editor; see issue 0002454


git-svn-id: http://svn.slicer.org/Slicer4/trunk@21758 3bd1e089-480b-0410-8dfb-8563597acbee
add - Base/GUI/Tcl/ImageData/FastMarchingEffect.png Diff File
mod - Modules/Scripted/EditorLib/CMakeLists.txt Diff File
mod - Modules/Scripted/EditorLib/EditBox.py Diff File
add - Modules/Scripted/EditorLib/FastMarchingEffect.py Diff File
mod - Modules/Scripted/EditorLib/__init__.py Diff File

Issue History

Date Modified Username Field Change
2012-08-30 06:16 fedorov New Issue
2012-08-30 06:16 fedorov Status new => assigned
2012-08-30 06:16 fedorov Assigned To => pieper
2012-08-30 06:17 fedorov Assigned To pieper => fedorov
2012-12-08 10:12 jcfr Target Version => Slicer 4.3.0
2013-02-14 08:12 fedorov Note Added: 0007927
2013-02-14 08:12 fedorov Status assigned => acknowledged
2013-02-16 08:46 fedorov Note Added: 0007965
2013-02-16 08:46 fedorov Note Added: 0007966
2013-02-16 08:48 fedorov Note Added: 0007967
2013-02-16 08:49 fedorov Note Edited: 0007965
2013-02-16 08:49 fedorov Note Edited: 0007965
2013-02-21 08:50 fedorov Note Added: 0007994
2013-08-28 12:14 pieper Target Version Slicer 4.3.0 => Slicer 4.4.0
2014-07-29 12:13 jcfr Note Added: 0012277
2014-07-29 12:13 jcfr Status acknowledged => resolved
2014-07-29 12:13 jcfr Fixed in Version => Slicer 4.4.0
2014-07-29 12:13 jcfr Resolution open => fixed
2014-07-29 12:13 jcfr Status resolved => closed
2017-06-07 23:27 fedorov Changeset attached => Slicer 2145-support-for-installing-extension-from-file ab13c5c7