View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002351 | Slicer4 | Core: Extensions | public | 2012-07-25 10:47 | 2012-10-15 12:58 |
Reporter | lassoan | Assigned To | jcfr | ||
Priority | normal | Severity | tweak | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.2.0 | ||
Summary | 0002351: Scripted modules appear in an inconsistent directory location when building multiple modules in a single extension | ||||
Description | When building an extension that consists of multiple modules the location of the different targets (qt-loadable vs. scripted) is not consistent: e.g., Scripted modules are stored at a different location for each module: All dlls are stored in one common directory: Probably it doesn't cause any problems, but it's inconsistent and may lead to problems in the future. | ||||
Tags | No tags attached. | ||||
I changed the path in our extension by changing Maybe if the same change is made in the templates, it'd be enough. |
|
I couldn't reproduce that problem on Linux. Is this issue specific to Windows ? I checked the following structure and they seem to be valid: Could you provide more context ? Are we talking about the tree structure after installing on extension or may be the tree structure associated with windows build tree ? Thanks // --------------------- jchris@karakoram:~/Projects/SlicerRt-build/inner-build $ ls lib/Slicer-4.1/* lib/Slicer-4.1/qt-scripted-modules: // --------------------- jchris@karakoram:~/Projects/SlicerRt-build/inner-build/_CPack_Packages/Linux/TGZ/21184-linux-amd64-SlicerRT-svn356-2012-10-15 $ ls lib/Slicer-4.1/* lib/Slicer-4.1/qt-scripted-modules: // --------------------- jchris@karakoram:~/Downloads/21176-win-amd64-SlicerRT-svn352-2012-10-14 $ ls lib/Slicer-4.1/* lib/Slicer-4.1/qt-scripted-modules: |
|
The issue Andras described is that by default, the DLLs coming from C++ source were deployed in the ${CMAKE_BINARY_DIR}/lib/Slicer-4.1/qt-loadable-modules/[Configuration], but the compiled python scripts (py and pyc files) were deployed in the ${CMAKE_CURRENT_BINARY_DIR}/${Slicer_QTSCRIPTEDMODULES_LIB_DIR}, which is a completely different location and different from module to module. Looking at the template Extensions\Testing\ScriptedLoadableExtensionTemplate\CMakeLists.txt it seems that this has changed, so that the destination directory is now ${CMAKE_BINARY_DIR}/${Slicer_QTSCRIPTEDMODULES_LIB_DIR} (just like I did recently in case of our python module). Andras, I think the issue has been resolved, but not sooner than we used the template for our module, this is why it was inconsistent in our case. If you agree, we can close the issue. |
|
The template is fixed, so I agree that this issue can be closed now. I don't have rights to change the status from the current "feedback" to "closed", so someone with dev or admin rights have to do it. |
|
Re-open if there are still issues. I also created an issue to track the fact a macro named "slicerMacroBuildScriptedModule" should be added. See 0002647 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-07-25 10:47 | lassoan | New Issue | |
2012-07-25 10:47 | lassoan | Status | new => assigned |
2012-07-25 10:47 | lassoan | Assigned To | => jcfr |
2012-07-25 15:38 | jcfr | Target Version | => Slicer 4.3.0 |
2012-07-25 15:39 | jcfr | Status | assigned => acknowledged |
2012-10-15 06:58 | pinter | Note Added: 0006530 | |
2012-10-15 10:50 | jcfr | Note Added: 0006540 | |
2012-10-15 10:50 | jcfr | Status | acknowledged => feedback |
2012-10-15 11:09 | pinter | Note Added: 0006541 | |
2012-10-15 12:50 | lassoan | Note Added: 0006550 | |
2012-10-15 12:52 | jcfr | Note Added: 0006551 | |
2012-10-15 12:52 | jcfr | Status | feedback => resolved |
2012-10-15 12:52 | jcfr | Fixed in Version | => Slicer 4.2.0 - coming release |
2012-10-15 12:52 | jcfr | Resolution | open => fixed |
2012-10-15 12:52 | jcfr | Relationship added | related to 0002647 |
2012-10-15 12:58 | lassoan | Status | resolved => closed |