View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002341 | Slicer4 | Core: Base Code | public | 2012-07-24 02:03 | 2018-03-02 11:07 |
Reporter | jcfr | Assigned To | hastings.greer | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Fixed in Version | Slicer 4.6.0 | |||
Summary | 0002341: Fix camera reset in vtkMRMLViewDisplayableManager | ||||
Description | See end of function "vtkMRMLViewDisplayableManager::vtkInternal::UpdateAxis" // Until we come up with a solution for all use cases, the resetting | ||||
Tags | No tags attached. | ||||
After investigation we recall that this was the change which re-centered the box everytime the visible model changes. But for some situations, like dynamic data changes in the scene this is problematics. Such as when fiducial tractography is going on or when tracked data is updated. |
|
This code was first introduced by Bill lorensen ENH: Box axis and labels now resize when actors are added or changed to the 3D window. ... then disabled by Alex in commit r13859 ENH: models display manager: first cut |
|
Looking through this code, I can't see any reason to change the camera whenever the axis is updated. I suggest that the commented out code is removed entirely. |
|
Thanks for investigating. Could you submit a PR ? And if re-centering the view when model visibility changes (or if user select a model), adding an option to link the Model module with the 3D view may be a more sensitive approach. |
|
With this code gone, http://na-mic.org/Mantis/view.php?id=2753 becomes fixable because the camera will never move when the bounding box is updated. Thoughts? |
|
Fixed in r25194 |
|
Thanks |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-07-24 02:03 | jcfr | New Issue | |
2012-07-24 02:03 | jcfr | Target Version | => Slicer 4.4.0 |
2012-08-20 08:26 | nicole | Assigned To | => pieper |
2012-08-20 08:26 | nicole | Status | new => assigned |
2014-03-06 13:14 | pieper | Note Added: 0011294 | |
2014-03-06 13:14 | pieper | Status | assigned => acknowledged |
2014-03-06 13:14 | pieper | Target Version | Slicer 4.4.0 => |
2014-03-06 13:15 | jcfr | Note Added: 0011295 | |
2016-06-14 15:47 | jcfr | Assigned To | pieper => hastings.greer |
2016-06-14 15:47 | jcfr | Status | acknowledged => assigned |
2016-06-16 11:54 | jcfr | Note Edited: 0011295 | View Revisions |
2016-06-16 18:07 | hastings.greer | Note Added: 0013976 | |
2016-06-16 18:16 | jcfr | Note Added: 0013977 | |
2016-06-16 18:16 | jcfr | Note Edited: 0013977 | View Revisions |
2016-06-16 18:43 | hastings.greer | Note Added: 0013978 | |
2016-06-16 18:53 | jcfr | Note Added: 0013979 | |
2016-06-16 18:53 | jcfr | Status | assigned => resolved |
2016-06-16 18:53 | jcfr | Fixed in Version | => Slicer 4.6.0 |
2016-06-16 18:53 | jcfr | Resolution | open => fixed |
2016-06-16 19:18 | jcfr | Note Added: 0013983 | |
2016-06-16 19:18 | jcfr | Relationship added | related to 0002752 |
2016-06-16 19:18 | jcfr | Relationship added | related to 0002753 |
2018-03-02 11:07 | jcfr | Status | resolved => closed |