View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002336Slicer4Core: Base Codepublic2012-07-23 13:252014-05-13 08:58
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status acknowledgedResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0002336: Consolidate enum used to specify scalarInvariant operation in DTI
Description

The enum associated with the scalarInvariant operation is defined in two different location:

      1) https://github.com/Slicer/Slicer/blob/master/Libs/vtkTeem/vtkDiffusionTensorMathematics.h#L50
      2) https://github.com/Slicer/Slicer/blob/master/Libs/MRML/Core/vtkMRMLDiffusionTensorDisplayPropertiesNode.h#L70

These two enums have a different number of elements and seems to be used like they are similar. See [1] and [2].

[1] https://github.com/Slicer/Slicer/blob/master/Modules/Scripted/Scripts/DataProbe.py#L391
[2] https://github.com/Slicer/Slicer/blob/master/Modules/Scripted/Scripts/DataProbe.py#L146

TagsNo tags attached.

Activities

jcfr

jcfr

2013-02-23 19:41

administrator   ~0008025

Reminder sent to: pieper

Let me know what you think of this. Thanks.
pieper

pieper

2013-02-24 06:40

administrator   ~0008030

Yes, it makes sense to me to consolidate them. Thanks for looking in to this.

Issue History

Date Modified Username Field Change
2012-07-23 13:25 jcfr New Issue
2012-07-23 15:07 jcfr Assigned To => jcfr
2012-07-23 15:07 jcfr Status new => assigned
2012-07-23 15:07 jcfr Target Version => Slicer 4.3.0
2013-02-23 19:41 jcfr Note Added: 0008025
2013-02-23 19:41 jcfr Status assigned => feedback
2013-02-24 06:40 pieper Note Added: 0008030
2013-02-24 10:11 jcfr Description Updated
2013-08-30 12:50 jcfr Target Version Slicer 4.3.0 => Slicer 4.4.0
2014-05-13 08:58 jcfr Status feedback => acknowledged
2014-05-13 08:58 jcfr Target Version Slicer 4.4.0 =>