View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002313Slicer4Core: Base Codepublic2012-07-06 14:162020-03-05 08:13
Reporterjcfr Assigned Topinter  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status resolvedResolutionwon't fix 
Product Version 
Target VersionFixed in VersionSlicer 4.11.0 
Summary0002313: Implement onSDBSaveToDCMActionTriggered
Description

Either implement the function or remove the function and comments from the code.

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=17927
and http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Applications/SlicerApp/qSlicerAppMainWindowCore.cxx?view=markup#l243

TagsNo tags attached.

Relationships

related to 0002254 acknowledgedpieper Unable to create Slicer DICOM data bundle 

Activities

pieper

pieper

2012-08-07 12:56

administrator   ~0005519

This feature will be incorporated when the DICOM module is more completely integrate with the rest of the main GUI - for now all this kind of functionality would stay inside the DICOM module. For now remove the unused code.
lassoan

lassoan

2020-03-04 12:47

developer   ~0016339

@pinter Could you check if this issue is still relevant (I doubt it).
pinter

pinter

2020-03-04 13:02

developer   ~0016341

There are code stubs related to this in qSlicerMainWindow.* (a disabled action and an empty function with comment saying it's not yet implemented - search for "SDBSaveToDCMAction").

Since this function has been implemented in a different way (through DICOM plugin), this is not relevant anymore I think.

If you'd like I can remove the dead code and close this.
lassoan

lassoan

2020-03-04 15:24

developer   ~0016342

Yes, it would be great if you could remove the unused code and close this. Thank you!
pinter

pinter

2020-03-05 05:54

developer   ~0016343

Stubs removed in commit
https://github.com/Slicer/Slicer/commit/b886fca4f2041a71d2a5454cc9aa783e6d7121fa
If we need to expose this function from the toolbar in the future, this may need to be added back.
lassoan

lassoan

2020-03-05 08:13

developer   ~0016344

Thank you!

Issue History

Date Modified Username Field Change
2012-07-06 14:16 jcfr New Issue
2012-07-06 14:17 jcfr Status new => assigned
2012-07-06 14:17 jcfr Assigned To => nicole
2012-07-06 14:17 jcfr Target Version => Slicer 4.2.0 - Sept 1st 2012
2012-08-07 12:56 pieper Note Added: 0005519
2012-08-07 12:56 pieper Severity minor => feature
2012-08-07 12:56 pieper Status assigned => closed
2012-08-07 12:56 pieper Status closed => assigned
2012-08-07 12:56 pieper Assigned To nicole => pieper
2012-08-20 12:34 jcfr Target Version Slicer 4.2.0 - Feature freeze Sept 1st 2012 => Slicer 4.2.5
2012-08-21 09:40 jcfr Target Version Slicer 4.2.5 => Slicer 4.3.0
2013-07-08 11:25 pieper Target Version Slicer 4.3.0 => Slicer 4.4.0
2014-03-06 13:28 pieper Relationship added related to 0002254
2014-05-13 09:55 jcfr Target Version Slicer 4.4.0 =>
2020-03-04 12:46 lassoan Assigned To pieper => pinter
2020-03-04 12:47 lassoan Note Added: 0016339
2020-03-04 13:02 pinter Note Added: 0016341
2020-03-04 15:24 lassoan Note Added: 0016342
2020-03-05 05:54 pinter Status assigned => resolved
2020-03-05 05:54 pinter Resolution open => won't fix
2020-03-05 05:54 pinter Fixed in Version => Slicer 4.11.0
2020-03-05 05:54 pinter Note Added: 0016343
2020-03-05 08:13 lassoan Note Added: 0016344