View Issue Details

IDProjectCategoryView StatusLast Update
0002282Slicer4Core: Extensionspublic2014-03-06 05:06
Reporterjcfr Assigned Tomillerjv  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002282: Update Carma extension
Description

Integrate topic associated with this issue: https://github.com/carma-center/carma_slicer_extension/issues/1

When this is done, add a note on that issue: https://github.com/Slicer/ExtensionsIndex/issues/31

Currently in the process of writing down the workflow that should be used to contribute extension fixes, I (Jc) will take care of integrating the new extension description file.

TagsNo tags attached.

Activities

jcfr

jcfr

2012-07-04 14:05

administrator   ~0005073

Hi Jim,

Any update ? Would be great if you could integrate the topic referenced above.

When this is done, add a note on that issue: https://github.com/Slicer/ExtensionsIndex/issues/31

Thanks
Jc

millerjv

millerjv

2012-07-05 05:27

developer   ~0005075

Jc,

I didn't understand the previous status. I didn't realize that you had fixed the issues in your repository already.

Do I understand the process correctly? Instead of sending pull requests to the master repository, we put an issue on the master repository and list the issue in the commit message of the forked repository? This seems to list the commit on the master repository activity page. Is this correct?

jcfr

jcfr

2012-07-05 12:17

administrator   ~0005077

Hi Jim,

Indeed, that the idea. The process explaining how to contribute a new extension description [1] is similar to the one associated with extension update/fix contribution.

[1] https://github.com/Slicer/ExtensionsIndex#contributing
[2] TBD

millerjv

millerjv

2012-07-17 10:05

developer   ~0005166

Jc,

What is the recommend mechanism for testing these changes?

Grabbing your changes is not an issue.

But to build with your changes, I either

1) Have to already have the extension built so I can descend directly into the build tree to build against the modifications

2) Locally modify the s4ext file so it points to my local repo and commit

jcfr

jcfr

2012-07-17 10:37

administrator   ~0005167

Try on your workstation by submitting an experimental upload.

If possible, try also on the other platform. Ideally, we should have a next and master branch on the extension index ... that's plan for later.

For now, when you think you have something working, update the extension description .. then push a topic on your extension index fork. The commit should reference the issue i entered on the extension index issue tracker.

millerjv

millerjv

2012-07-17 11:24

developer   ~0005168

The problem is that a "make" in ExtensionIndex-build causes the version of the code in the s4ext to be used. Is the only recourse to temporality modify the s4ext file to point to my local repository and the local commit to verify the changes before I push the changes to the master repository?

jcfr

jcfr

2012-07-17 11:30

administrator   ~0005169

If you following that approach, simply locally update your local extension description file to point to your fork of carma extension or something along the line. I am not sure to understand what the issue here.

Would be great if you could join the hang out later so that we can clarify the issue.

jcfr

jcfr

2012-07-17 15:06

administrator   ~0005178

Fixed - See https://github.com/Slicer/ExtensionsIndex/commit/f7aaf7f9906049326221f41ce0062a5333ad6cb1

jcfr

jcfr

2012-07-27 15:42

administrator   ~0005421

Dear issue reporter,

Good news :) Slicer developers SOLVED the problem you reported - YOU now need to VERIFY and CLOSE this issue.

jcfr

jcfr

2014-03-06 05:05

administrator   ~0010917

Closing resolved issues that have not been updated in more than 3 months

Issue History

Date Modified Username Field Change
2012-06-29 16:38 jcfr New Issue
2012-06-29 16:38 jcfr Status new => assigned
2012-06-29 16:38 jcfr Assigned To => jcfr
2012-06-29 16:39 jcfr Assigned To jcfr => millerjv
2012-06-29 16:39 jcfr Target Version => Slicer 4.2.0 - Sept 1st 2012
2012-07-04 14:05 jcfr Note Added: 0005073
2012-07-05 05:27 millerjv Note Added: 0005075
2012-07-05 12:17 jcfr Note Added: 0005077
2012-07-17 10:05 millerjv Note Added: 0005166
2012-07-17 10:37 jcfr Note Added: 0005167
2012-07-17 11:24 millerjv Note Added: 0005168
2012-07-17 11:30 jcfr Note Added: 0005169
2012-07-17 15:07 jcfr Note Added: 0005178
2012-07-17 15:07 jcfr Status assigned => resolved
2012-07-17 15:07 jcfr Fixed in Version => Slicer 4.2.0 - Sept 1st 2012
2012-07-17 15:07 jcfr Resolution open => fixed
2012-07-27 15:42 jcfr Note Added: 0005421
2014-03-06 05:05 jcfr Note Added: 0010917
2014-03-06 05:06 jcfr Status resolved => closed