View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002255 | Slicer4 | Core: Building (CMake, Superbuild) | public | 2012-06-25 12:21 | 2012-07-03 11:40 |
Reporter | jcfr | Assigned To | crmullin | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.0.1 | ||||
Target Version | Slicer 4.2.0 | Fixed in Version | Slicer 4.2.0 | ||
Summary | 0002255: Integrate GIT_REPO option into dashboard script | ||||
Description | The user should have the option to specify from which repository Slicer will be checked out. Also, the default should be set to check out Slicer from git instead of svn. | ||||
Tags | No tags attached. | ||||
Re-consider what I mentioned earlier today, Slicer source should still be checked out from SVN. This is important for extensions support. |
|
Correction: VVN source: git |
|
WIP branch -- all the user has to do in the template script is define GIT_REPOSITORY |
|
There could be a GIT_TAG variable defined so that the vvn-master branch is checked out if GIT_REPOSITORY is defined, executing the command: |
|
I agree with your comments. https://github.com/chrismullins/Slicer/commit/b0a80e5165fec59ff0b8186582bf94bd9ba63810 |
|
Updated so that GIT_TAG corresponds with only the branch name desired by the user. https://github.com/chrismullins/Slicer/commit/7c3d5ce1626b99b78b03485081e35a97c3841c0a Is there any need to check whether or not the "-b" option is available (as in Visomics and CMake), or can we assume everyone is using a suitable version of git? TODO: Make sure updating works, don't clone a new repo every night. |
|
See inlined comment. Thanks |
|
For my reference: http://www.cmake.org/Wiki/CMake_Scripting_Of_CTest This appears to work: https://github.com/chrismullins/Slicer/commit/5c7218f0d5180fdb4fb20b00ee7dd632b17a3801 Below is some ctest output after resetting HEAD a few times: Updating the repository: /home/crmullin/Dashboards/Slicer4 |
|
Consider note: https://github.com/chrismullins/Slicer/commit/5c7218f0d5180fdb4fb20b00ee7dd632b17a3801#commitcomment-1522420 |
|
Thanks for the catch. I was wondering which it would be according to http://www.slicer.org/slicerWiki/index.php/Documentation/4.1/Developers/Style_Guide#Commit_message_prefix |
|
Commit message updated to match guidelines. https://github.com/chrismullins/Slicer/commit/81e9ae63faed04bd972fd1f4b7e74eefad32c7f4 |
|
Make sure you get github commit on your kitware account. In the mean time, consider reading: https://github.com/chrismullins/Slicer/commit/81e9ae63faed04bd972fd1f4b7e74eefad32c7f4#commitcomment-1529474 |
|
Fixed in r20549 See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20549 |
|
Both Slicer nightly and continuous dashboard works as expected, the new driver script works fine. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-06-25 12:21 | crmullin | New Issue | |
2012-06-25 12:21 | crmullin | Status | new => assigned |
2012-06-25 12:21 | crmullin | Assigned To | => jcfr |
2012-06-25 12:26 | jcfr | Relationship added | parent of 0002059 |
2012-06-25 12:26 | jcfr | Relationship deleted | parent of 0002059 |
2012-06-25 12:26 | jcfr | Relationship added | child of 0002059 |
2012-06-25 12:30 | jcfr | Note Added: 0004923 | |
2012-06-25 12:36 | crmullin | Note Added: 0004924 | |
2012-06-25 13:28 | jcfr | Reporter | crmullin => jcfr |
2012-06-25 13:28 | jcfr | Assigned To | jcfr => crmullin |
2012-06-28 07:10 | crmullin | Note Added: 0004961 | |
2012-06-28 07:17 | crmullin | Note Added: 0004963 | |
2012-06-28 07:18 | crmullin | Note Edited: 0004963 | |
2012-06-28 07:28 | jcfr | Note Added: 0004964 | |
2012-06-28 09:18 | crmullin | Note Added: 0004968 | |
2012-06-29 07:41 | crmullin | Note Added: 0004991 | |
2012-06-29 07:44 | crmullin | Note Edited: 0004991 | |
2012-06-29 07:45 | crmullin | Note Edited: 0004991 | |
2012-06-29 08:12 | jcfr | Note Added: 0004993 | |
2012-06-29 09:44 | crmullin | Note Added: 0004994 | |
2012-06-29 16:08 | jcfr | Note Added: 0005006 | |
2012-06-29 16:08 | jcfr | Status | assigned => feedback |
2012-06-29 16:10 | jcfr | ETA | none => < 1 day |
2012-06-29 16:10 | jcfr | Target Version | => Slicer 4.2.0 - Sept 1st 2012 |
2012-06-30 13:32 | crmullin | Note Added: 0005014 | |
2012-07-02 10:54 | crmullin | Note Added: 0005039 | |
2012-07-02 11:29 | jcfr | Note Added: 0005042 | |
2012-07-03 11:37 | crmullin | Note Added: 0005059 | |
2012-07-03 11:37 | crmullin | Status | feedback => resolved |
2012-07-03 11:37 | crmullin | Fixed in Version | => Slicer 4.2.0 - Sept 1st 2012 |
2012-07-03 11:37 | crmullin | Resolution | open => fixed |
2012-07-03 11:40 | jcfr | Note Added: 0005060 | |
2012-07-03 11:40 | jcfr | Status | resolved => closed |
2013-08-30 12:54 | jcfr | Relationship added | has duplicate 0002520 |