View Issue Details

IDProjectCategoryView StatusLast Update
0002255Slicer4Core: Building (CMake, Superbuild)public2012-07-03 11:40
Reporterjcfr Assigned Tocrmullin  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionSlicer 4.0.1 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002255: Integrate GIT_REPO option into dashboard script
Description

The user should have the option to specify from which repository Slicer will be checked out. Also, the default should be set to check out Slicer from git instead of svn.

TagsNo tags attached.

Relationships

has duplicate 0002520 closedjcfr Prepare factory/dashboard script to support branchy workflow 
child of 0002059 acknowledgedjcfr Transition to Git 

Activities

jcfr

jcfr

2012-06-25 12:30

administrator   ~0004923

Re-consider what I mentioned earlier today, Slicer source should still be checked out from SVN. This is important for extensions support.

crmullin

crmullin

2012-06-25 12:36

developer   ~0004924

Correction: VVN source: git
Slicer source: svn

crmullin

crmullin

2012-06-28 07:10

developer   ~0004961

WIP branch -- all the user has to do in the template script is define GIT_REPOSITORY
https://github.com/chrismullins/Slicer/commit/50a6ade150ef8b5706e80c70e0344c7866325262

crmullin

crmullin

2012-06-28 07:17

developer   ~0004963

Last edited: 2012-06-28 07:18

There could be a GIT_TAG variable defined so that the vvn-master branch is checked out if GIT_REPOSITORY is defined, executing the command:
git clone -b vvn-master git@kwsource.kitwarein.com:ninja/vvn.git ${CTEST_SOURCE_DIRECTORY}
Or, just checkout VVN repo by default (if GIT_REPOSITORY), setting GIT_TAG to "".

jcfr

jcfr

2012-06-28 07:28

administrator   ~0004964

See https://github.com/chrismullins/Slicer/commit/50a6ade150ef8b5706e80c70e0344c7866325262#commitcomment-1516082

crmullin

crmullin

2012-06-28 09:18

developer   ~0004968

I agree with your comments.

https://github.com/chrismullins/Slicer/commit/b0a80e5165fec59ff0b8186582bf94bd9ba63810

crmullin

crmullin

2012-06-29 07:41

developer   ~0004991

Last edited: 2012-06-29 07:45

Updated so that GIT_TAG corresponds with only the branch name desired by the user.

https://github.com/chrismullins/Slicer/commit/7c3d5ce1626b99b78b03485081e35a97c3841c0a

Is there any need to check whether or not the "-b" option is available (as in Visomics and CMake), or can we assume everyone is using a suitable version of git?

TODO: Make sure updating works, don't clone a new repo every night.

jcfr

jcfr

2012-06-29 08:12

administrator   ~0004993

See inlined comment. Thanks

crmullin

crmullin

2012-06-29 09:44

developer   ~0004994

For my reference: http://www.cmake.org/Wiki/CMake_Scripting_Of_CTest

This appears to work: https://github.com/chrismullins/Slicer/commit/5c7218f0d5180fdb4fb20b00ee7dd632b17a3801

Below is some ctest output after resetting HEAD a few times:

Updating the repository: /home/crmullin/Dashboards/Slicer4
Use GIT repository type
Old revision of repository is: aaac769daf04b7a67d21ecc47db3ad920af1019a
New revision of repository is: ce84477eb44d8975995db7d6f86ac712bd8b81ae
Gathering version information (one . per revision):
..
Found 1 updated files

jcfr

jcfr

2012-06-29 16:08

administrator   ~0005006

Consider note: https://github.com/chrismullins/Slicer/commit/5c7218f0d5180fdb4fb20b00ee7dd632b17a3801#commitcomment-1522420

crmullin

crmullin

2012-06-30 13:32

developer   ~0005014

Thanks for the catch.
https://github.com/chrismullins/Slicer/commit/399675abb668b32785c5d222e3930e4fab49313b

I was wondering which it would be according to http://www.slicer.org/slicerWiki/index.php/Documentation/4.1/Developers/Style_Guide#Commit_message_prefix

crmullin

crmullin

2012-07-02 10:54

developer   ~0005039

Commit message updated to match guidelines.

https://github.com/chrismullins/Slicer/commit/81e9ae63faed04bd972fd1f4b7e74eefad32c7f4

jcfr

jcfr

2012-07-02 11:29

administrator   ~0005042

Make sure you get github commit on your kitware account. In the mean time, consider reading: https://github.com/chrismullins/Slicer/commit/81e9ae63faed04bd972fd1f4b7e74eefad32c7f4#commitcomment-1529474

crmullin

crmullin

2012-07-03 11:37

developer   ~0005059

Fixed in r20549

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20549

jcfr

jcfr

2012-07-03 11:40

administrator   ~0005060

Both Slicer nightly and continuous dashboard works as expected, the new driver script works fine.

Issue History

Date Modified Username Field Change
2012-06-25 12:21 crmullin New Issue
2012-06-25 12:21 crmullin Status new => assigned
2012-06-25 12:21 crmullin Assigned To => jcfr
2012-06-25 12:26 jcfr Relationship added parent of 0002059
2012-06-25 12:26 jcfr Relationship deleted parent of 0002059
2012-06-25 12:26 jcfr Relationship added child of 0002059
2012-06-25 12:30 jcfr Note Added: 0004923
2012-06-25 12:36 crmullin Note Added: 0004924
2012-06-25 13:28 jcfr Reporter crmullin => jcfr
2012-06-25 13:28 jcfr Assigned To jcfr => crmullin
2012-06-28 07:10 crmullin Note Added: 0004961
2012-06-28 07:17 crmullin Note Added: 0004963
2012-06-28 07:18 crmullin Note Edited: 0004963
2012-06-28 07:28 jcfr Note Added: 0004964
2012-06-28 09:18 crmullin Note Added: 0004968
2012-06-29 07:41 crmullin Note Added: 0004991
2012-06-29 07:44 crmullin Note Edited: 0004991
2012-06-29 07:45 crmullin Note Edited: 0004991
2012-06-29 08:12 jcfr Note Added: 0004993
2012-06-29 09:44 crmullin Note Added: 0004994
2012-06-29 16:08 jcfr Note Added: 0005006
2012-06-29 16:08 jcfr Status assigned => feedback
2012-06-29 16:10 jcfr ETA none => < 1 day
2012-06-29 16:10 jcfr Target Version => Slicer 4.2.0 - Sept 1st 2012
2012-06-30 13:32 crmullin Note Added: 0005014
2012-07-02 10:54 crmullin Note Added: 0005039
2012-07-02 11:29 jcfr Note Added: 0005042
2012-07-03 11:37 crmullin Note Added: 0005059
2012-07-03 11:37 crmullin Status feedback => resolved
2012-07-03 11:37 crmullin Fixed in Version => Slicer 4.2.0 - Sept 1st 2012
2012-07-03 11:37 crmullin Resolution open => fixed
2012-07-03 11:40 jcfr Note Added: 0005060
2012-07-03 11:40 jcfr Status resolved => closed
2013-08-30 12:54 jcfr Relationship added has duplicate 0002520