View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002247Slicer4Core: Base Codepublic2012-06-21 22:472017-06-07 23:27
Reporterfinetjul Assigned Tocrmullin  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionSlicer 4.1.1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002247: Rename qSlicerMODULE_NAMEModule.ui into qSlicerMODULE_NAMEModuleWidget.ui
Description

the ui files of the module panels are wrongly named, it should be the same name than the widget class name with the ui extension
Please change the templates as well

TagsNo tags attached.

Activities

crmullin

crmullin

2012-12-12 10:24

developer   ~0007496

Topic stage: https://github.com/chrismullins/Slicer/commit/2a623faec1c1cf1902a9102d23293b48a85957bb
crmullin

crmullin

2013-01-04 11:56

developer   ~0007613

Last edited: 2013-01-04 12:31

New topic after Julien's comments: https://github.com/chrismullins/Slicer/commit/864cc850134849e15674e0b7532c906883b9189a
crmullin

crmullin

2013-01-09 09:57

developer   ~0007637

Here is the latest, with the fixed line endings (!):
https://github.com/chrismullins/Slicer/commit/ab535b0465bf800e431544295b997ba36ce3a8e1
crmullin

crmullin

2013-01-14 09:17

developer   ~0007664

Thanks for the continued reviews, Julien. This commit compiles from a clean build with no errors:
https://github.com/chrismullins/Slicer/commit/15038b3c4e4eb5ecc15bb5d942454e1bfd1c0462
jcfr

jcfr

2013-01-18 10:35

administrator   ~0007713

Hi Chris,

Following r21613, Slicer doesn't work as it should.
I will very probably revert the commit.

// -------------------
1) Start Slicer
2) Click on download sample data within Welcome module
3) Click on MRHead
4) Go in Data or Volumes module
5) => There are no nodes
// -------------------

// -------------------
There is also the following warning at startup:

Object::connect: No such slot qSlicerWelcomeModuleWidget::loadData() in /home/jchris/Projects/Slicer-AHM-Superbuild-Debug/Slicer-build/Modules/Loadable/SlicerWelcome/ui_qSlicerWelcomeModuleWidget.h:293
Object::connect: (sender name: 'LoadNonDicomDataButton')
Object::connect: (receiver name: 'qSlicerWelcomeModuleWidget')
// -------------------

// -------------------
Tutorial testing xml should also be updated.
qSlicerDataModule -> qSlicerDataModuleWidget
etc ...

Using the following command:
ack --xml "qSlicer[A-Z][A-Za-z]+Module[^A-Za-z*]"

I can see the lines within xml files that should be updated.

In my ".ackrc" file, I have the line: --type-set=xml=.xml
// -------------------

// -------------------
The following expression may also be helpful:

ack --no-xml "qSlicer([A-Z][^b][A-Za-z]+)Module[^A-Za-z*]"

It lists all occurences of qSlicer...Module expect the qSlicerAbstract...Module ones.
// -------------------
jcfr

jcfr

2013-01-18 10:48

administrator   ~0007714

With Julien, we had an other look at the commit and it turns out that the connection involving "mrmlSceneChanged" hasn't been updated.
jcfr

jcfr

2013-01-18 11:28

administrator   ~0007715

Last edited: 2013-01-18 11:29

Commits r21615 and r21616 restore the expected behavior.

  • Module widget are now connected with the scene
  • Startup warning doesn't appear anymore
jcfr

jcfr

2013-01-18 11:39

administrator   ~0007716

Commit r21617 update XML QtTesting tutorials

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 173cacea

2013-01-18 11:37:03

christopher.mullins

Details Diff 		STYLE: Renamed qSlicer{MODULE_NAME}Module.ui into qSlicer{MODULE_NAME}ModuleWidget.ui

See na-mic.org/Mantis/view.php?id=2247

Fixes 0002247

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21613 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/LoadableExtensionTemplate/CMakeLists.txt Diff File
mod - Extensions/Testing/LoadableExtensionTemplate/qSlicerLoadableExtensionTemplateModuleWidget.cxx Diff File
mod - Extensions/Testing/SuperBuildLoadableExtensionTemplate/CMakeLists.txt Diff File
mod - Extensions/Testing/SuperBuildLoadableExtensionTemplate/qSlicerSuperBuildLoadableExtensionTemplateModuleWidget.cxx Diff File
mod - Modules/Core/CMakeLists.txt Diff File
mod - Modules/Core/EventBroker/qSlicerEventBrokerModuleWidget.cxx Diff File
mod - Modules/Core/ROI/qSlicerROIModuleWidget.cxx Diff File
mod - Modules/Loadable/Annotations/CMakeLists.txt Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModuleWidget.cxx Diff File
mod - Modules/Loadable/Cameras/CMakeLists.txt Diff File
mod - Modules/Loadable/Cameras/qSlicerCamerasModuleWidget.cxx Diff File
mod - Modules/Loadable/Colors/CMakeLists.txt Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.cxx Diff File
mod - Modules/Loadable/CropVolume/CMakeLists.txt Diff File
mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModuleWidget.cxx Diff File
mod - Modules/Loadable/Data/CMakeLists.txt Diff File
mod - Modules/Loadable/Data/qSlicerDataModuleWidget.cxx Diff File
mod - Modules/Loadable/Measurements/CMakeLists.txt Diff File
mod - Modules/Loadable/Measurements/qSlicerMeasurementsModuleWidget.cxx Diff File
mod - Modules/Loadable/Models/CMakeLists.txt Diff File
mod - Modules/Loadable/Models/qSlicerModelsModuleWidget.cxx Diff File
mod - Modules/Loadable/MultiVolumeRendering/CMakeLists.txt Diff File
mod - Modules/Loadable/MultiVolumeRendering/qSlicerMultiVolumeRenderingModuleWidget.cxx Diff File
mod - Modules/Loadable/Reformat/CMakeLists.txt Diff File
mod - Modules/Loadable/Reformat/qSlicerReformatModuleWidget.cxx Diff File
mod - Modules/Loadable/SceneViews/CMakeLists.txt Diff File
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx Diff File
mod - Modules/Loadable/SlicerWelcome/CMakeLists.txt Diff File
mod - Modules/Loadable/SlicerWelcome/qSlicerWelcomeModuleWidget.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/Widgets/CMakeLists.txt Diff File
mod - Modules/Loadable/TractographyDisplay/Widgets/qSlicerTractographyDisplayModuleWidget.cxx Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/CMakeLists.txt Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/qSlicerTractographyInteractiveSeedingModuleWidget.cxx Diff File
mod - Modules/Loadable/Transforms/CMakeLists.txt Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx Diff File
mod - Modules/Loadable/ViewControllers/CMakeLists.txt Diff File
mod - Modules/Loadable/ViewControllers/qSlicerViewControllersModuleWidget.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Widgets/CMakeLists.txt Diff File
mod - Modules/Loadable/VolumeRendering/Widgets/qSlicerVolumeRenderingModuleWidget.cxx Diff File
mod - Modules/Loadable/Volumes/CMakeLists.txt Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModuleWidget.cxx Diff File

Slicer: 2145-support-for-installing-extension-from-file 333b50d7

2013-01-18 16:27:34

jcfr

Details Diff 		BUG: Ensure module widget listen to mrmlSceneChanged signal

This is a follow-up on commit r21613 where the connections haven't been
updated as expected.

Fixes 0002247

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21615 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Core/Resources/UI/qSlicerROIModuleWidget.ui Diff File
mod - Modules/Loadable/Cameras/Resources/UI/qSlicerCamerasModuleWidget.ui Diff File
mod - Modules/Loadable/Colors/Resources/UI/qSlicerColorsModuleWidget.ui Diff File
mod - Modules/Loadable/CropVolume/Resources/UI/qSlicerCropVolumeModuleWidget.ui Diff File
mod - Modules/Loadable/Data/Resources/UI/qSlicerDataModuleWidget.ui Diff File
mod - Modules/Loadable/Measurements/Resources/UI/qSlicerMeasurementsModuleWidget.ui Diff File
mod - Modules/Loadable/Models/Resources/UI/qSlicerModelsModuleWidget.ui Diff File
mod - Modules/Loadable/MultiVolumeRendering/Resources/UI/qSlicerMultiVolumeRenderingModuleWidget.ui Diff File
mod - Modules/Loadable/Reformat/Resources/UI/qSlicerReformatModuleWidget.ui Diff File
mod - Modules/Loadable/TractographyDisplay/Widgets/Resources/UI/qSlicerTractographyDisplayModuleWidget.ui Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/Resources/UI/qSlicerTractographyInteractiveSeedingModuleWidget.ui Diff File
mod - Modules/Loadable/Transforms/Resources/UI/qSlicerTransformsModuleWidget.ui Diff File
mod - Modules/Loadable/ViewControllers/Resources/UI/qSlicerViewControllersModuleWidget.ui Diff File
mod - Modules/Loadable/VolumeRendering/Resources/UI/qSlicerVolumeRenderingModuleWidget.ui Diff File
mod - Modules/Loadable/Volumes/Resources/UI/qSlicerVolumesModuleWidget.ui Diff File

Issue History

Date Modified Username Field Change
2012-06-21 22:47 finetjul New Issue
2012-06-21 22:47 finetjul Status new => assigned
2012-06-21 22:47 finetjul Assigned To => crmullin
2012-06-21 22:52 finetjul Summary Rename qMRMLMODULE_NAMEModule.ui into qMRMLMODULE_NAMEModuleWidget.ui => Rename qSlicerMODULE_NAMEModule.ui into qSlicerMODULE_NAMEModuleWidget.ui
2012-08-21 11:51 jcfr Target Version => Slicer 4.3.0
2012-12-12 10:24 crmullin Note Added: 0007496
2013-01-04 11:56 crmullin Note Added: 0007613
2013-01-04 12:31 finetjul Note Edited: 0007613
2013-01-09 09:57 crmullin Note Added: 0007637
2013-01-14 09:17 crmullin Note Added: 0007664
2013-01-18 10:35 jcfr Note Added: 0007713
2013-01-18 10:48 jcfr Note Added: 0007714
2013-01-18 11:28 jcfr Note Added: 0007715
2013-01-18 11:29 jcfr Note Edited: 0007715
2013-01-18 11:39 jcfr Note Added: 0007716
2013-01-18 11:39 jcfr Status assigned => resolved
2013-01-18 11:39 jcfr Fixed in Version => Slicer 4.3.0
2013-01-18 11:39 jcfr Resolution open => fixed
2013-02-11 16:22 finetjul Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 333b50d7
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file 173cacea