View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002194 | Slicer4 | Core: QtTesting | public | 2012-06-13 12:13 | 2012-07-30 07:19 |
Reporter | finetjul | Assigned To | BenjaminLong | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.2.0 | Fixed in Version | Slicer 4.2.0 | ||
Summary | 0002194: Configure ApplicationsSlicerAppData.py into build tree | ||||
Description | From Julien - June 13, 2012: In CMakeLists.txt of SlicerApp/Testing/Python | ||||
Tags | No tags attached. | ||||
//-------------- the ApplicationsSlicerAppData.py are with the other python files because we include it. //-------------- Python path / sys.path is your friend. You could look at how things are done with python_unit_test. //-------------- What about adding the file into Base/Pyhton/Slicer ? |
|
Make sens, I also propose the file is renamed: |
|
every files are named lowercase in this directory. |
|
Indeed, the idea is to follow this convention [1] slicerappdatapaths.py May be we could add the file into a folder named "datapaths", it means we would have: slicer/datapaths/slicerapp.py Later we could then add file like these ones if it makes sens: slicer/datapaths/baseqtcore.py What do you think ? [1] http://www.python.org/dev/peps/pep-0008/#package-and-module-names |
|
As long as we don't need more path, we should stay with slicerappdatapaths.py |
|
Jc: "Indeed, the idea is to follow this convention [1]" |
|
1) slicerappdatapaths.py sounds good to me. Make sure the file is not installed, it wouldn't make sens. 2) Python guidelines have been updated. See http://www.slicer.org/slicerWiki/index.php/Documentation/4.1/Developers/Style_Guide/Python#Guidelines |
|
fixed in r20354: |
|
The file "Python/slicer/slicerappdatapaths.py" should NOT be committed, it currently contain hard coded value ! The file Applications/SlicerApp/Testing/Python/slicerappdatapaths.py.in should be configured into the the build directory: ${Slicer_BINARY_DIR}/bin/Python/slicer |
|
Fixed in r20363 |
|
I suggested the use of "${Slicer_BINARY_DIR}/bin/Python/slicer" because I anticipated that you would keep the file "slicerappdatapaths.py.in" in "pplications/SlicerApp/Testing/Python/" I would recommend to move the file "slicerappdatapaths.py.in" If you convince me that moving "slicerappdatapaths.py.in" is not what we should do, use ${CMAKE_CURRENT_BINARY_DIR}/slicer/slicerappdatapaths.py instead of "${Slicer_BINARY_DIR}/bin/Python/slicer/slicerappdatapaths.py". See http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Base/Python/CMakeLists.txt?view=markup&pathrev=20363#l59 |
|
Fixed in r20366 |
|
Thanks :) Make also sure to fix indent, it is missing two spaces. See http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Applications/SlicerApp/Testing/Python/CMakeLists.txt?view=markup&pathrev=20366#l166 |
|
Dear issue reporter, Good news :) Slicer developers SOLVED the problem you reported - YOU now need to VERIFY and CLOSE this issue. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-06-13 12:13 | jcfr | New Issue | |
2012-06-13 12:13 | jcfr | Status | new => assigned |
2012-06-13 12:13 | jcfr | Assigned To | => BenjaminLong |
2012-06-13 12:13 | jcfr | Reporter | jcfr => finetjul |
2012-06-13 12:13 | jcfr | Target Version | => Slicer 4.2.0 - Sept 1st 2012 |
2012-06-13 13:18 | jcfr | Note Added: 0004815 | |
2012-06-13 13:23 | jcfr | Note Added: 0004816 | |
2012-06-13 13:45 | BenjaminLong | Note Added: 0004818 | |
2012-06-13 13:51 | BenjaminLong | Note Edited: 0004818 | |
2012-06-13 14:01 | jcfr | Note Added: 0004819 | |
2012-06-13 14:05 | BenjaminLong | Note Added: 0004821 | |
2012-06-13 14:06 | finetjul | Note Added: 0004822 | |
2012-06-13 14:06 | finetjul | Note Edited: 0004822 | |
2012-06-13 14:15 | jcfr | Note Added: 0004823 | |
2012-06-13 14:28 | BenjaminLong | Note Added: 0004825 | |
2012-06-13 14:28 | BenjaminLong | Status | assigned => resolved |
2012-06-13 14:28 | BenjaminLong | Resolution | open => fixed |
2012-06-13 16:20 | jcfr | Note Added: 0004827 | |
2012-06-13 16:20 | jcfr | Status | resolved => assigned |
2012-06-14 10:05 | BenjaminLong | Note Added: 0004831 | |
2012-06-14 10:05 | BenjaminLong | Status | assigned => resolved |
2012-06-14 10:23 | jcfr | Note Added: 0004832 | |
2012-06-14 10:33 | jcfr | Status | resolved => assigned |
2012-06-14 12:34 | BenjaminLong | Note Added: 0004835 | |
2012-06-14 12:34 | BenjaminLong | Status | assigned => resolved |
2012-06-14 12:40 | jcfr | Note Added: 0004836 | |
2012-07-27 15:40 | jcfr | Note Added: 0005398 | |
2012-07-30 07:19 | finetjul | Status | resolved => closed |
2012-07-30 07:19 | finetjul | Fixed in Version | => Slicer 4.2.0 - October 1st 2012 |