View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002187Slicer4Core: QtTestingpublic2012-06-12 09:322014-03-06 05:10
Reporterpieper Assigned Tofinetjul  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.2.0 
Summary0002187: Do not used "activated" signal since it doesn't map to "clicked" in a cross platform fashion
Description

// ------------
From Julien - June 12, 2012:

Seems that "activated" is platform dependent, so we probably don't want that (except if we hack to make it respond to single clicks).
The problem with "clicked" is that it doesn't respond to keyboard events (down arrow wouldn't work for you).
So I suggest using QItemSelectionModel::currentChanged instead.

// ------------
From Steve - June 12, 2012:

Hi Benjamin -

Ron noticed that your change from 'clicked' to 'activated' caused an
unexpected change in the user experience (doubleclick rather than
click for some of the editor features). I'd used 'clicked' on purpose
to make things act more like menus. Perhaps you can find a signal
(selectionChanged?) that restores the old behavior and still works
with the testing framework.

-Steve

TagsNo tags attached.

Relationships

parent of 0002156 acknowledgedfinetjul QtTest - Add "rules for developer" to the wiki 
Not all the children of this issue are yet resolved or closed.

Activities

BenjaminLong

BenjaminLong

2012-06-14 12:34

reporter   ~0004834

Fixed in r20364
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20364
pieper

pieper

2012-06-14 13:49

administrator   ~0004838

Benjamin -

Looks like you didn't fix the comment about selection changed:

http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Modules/Scripted/EditorLib/HelperBox.py?r1=20364&r2=20363&pathrev=20364

Also, you made a similar change to the ColorBox code and this needs to be fixed too. (perhaps you could review your commits and find where you changed clicked to activated)

-Steve
jcfr

jcfr

2012-07-27 15:40

administrator   ~0005395

Dear issue reporter,

Good news :) Slicer developers SOLVED the problem you reported - YOU now need to VERIFY and CLOSE this issue.
pieper

pieper

2012-07-28 10:21

administrator   ~0005437

Reported issue was not fixed.
finetjul

finetjul

2012-08-21 19:48

administrator   ~0005674

Fixed in r20184
jcfr

jcfr

2014-03-06 05:07

administrator   ~0010951

Closing resolved issues that have not been updated in more than 3 months

Issue History

Date Modified Username Field Change
2012-06-12 09:32 jcfr New Issue
2012-06-12 09:32 jcfr Status new => assigned
2012-06-12 09:32 jcfr Assigned To => BenjaminLong
2012-06-12 09:33 jcfr Reporter jcfr => pieper
2012-06-12 09:33 jcfr Target Version => Slicer 4.2.0 - Sept 1st 2012
2012-06-14 12:34 BenjaminLong Note Added: 0004834
2012-06-14 12:34 BenjaminLong Status assigned => resolved
2012-06-14 12:34 BenjaminLong Resolution open => fixed
2012-06-14 13:49 pieper Note Added: 0004838
2012-07-27 15:40 jcfr Note Added: 0005395
2012-07-28 10:21 pieper Note Added: 0005437
2012-07-28 10:21 pieper Status resolved => assigned
2012-07-28 10:21 pieper Resolution fixed => reopened
2012-07-31 13:03 pieper Assigned To BenjaminLong => finetjul
2012-08-20 10:18 jcfr Target Version Slicer 4.2.0 - Feature freeze Sept 1st 2012 => Slicer 4.2.5
2012-08-20 11:33 finetjul Relationship added parent of 0002156
2012-08-21 09:40 jcfr Target Version Slicer 4.2.5 => Slicer 4.3.0
2012-08-21 19:48 finetjul Note Added: 0005674
2012-08-21 19:48 finetjul Status assigned => resolved
2012-08-21 19:48 finetjul Fixed in Version => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2012-08-21 19:48 finetjul Resolution reopened => fixed
2014-03-06 05:07 jcfr Note Added: 0010951
2014-03-06 05:10 jcfr Status resolved => closed