0002131: Address unused warning introduced by commit r20147 - Added projections of the eigenvector corresponding to the maximal eigenvalu

ID	Project	Category	View Status	Date Submitted	Last Update

0002131	Slicer4	Core: Base Code	public	2012-05-28 20:21	2012-07-27 09:29

Reporter	jcfr	Assigned To	demian
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version
Target Version	Slicer 4.2.0	Fixed in Version	Slicer 4.2.0

Summary	0002131: Address unused warning introduced by commit r20147 - Added projections of the eigenvector corresponding to the maximal eigenvalu
Description	If these variables have no purpose, vtkNotUsed should be used. /home/jchris/Projects/Slicer4/Libs/vtkTeem/vtkDiffusionTensorMathematics.cxx:1080: warning: unused parameter ‘w’ [-Wunused-parameter] /home/jchris/Projects/Slicer4/Libs/vtkTeem/vtkDiffusionTensorMathematics.cxx:1085: warning: unused parameter ‘w’ [-Wunused-parameter] /home/jchris/Projects/Slicer4/Libs/vtkTeem/vtkDiffusionTensorMathematics.cxx:1090: warning: unused parameter ‘w’ [-Wunused-parameter]
Tags	No tags attached.

demian 2012-05-29 06:21 developer ~0004674	Fixed in commit r20284 according to the vtk coding standards: http://www.vtk.org/Wiki/VTK_Coding_Standards

jcfr 2012-05-29 07:48 administrator ~0004677	See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20284

jcfr 2012-05-29 07:51 administrator ~0004678 Last edited: 2012-05-29 07:52	Please used "vtkNotUsed" instead, this is more explicit and what is done in Slicer code. jchris@karakoram:~/Projects/Slicer4 [? master] $ ack -h vtkNotUsed \| wc -l 323

demian 2012-05-29 09:08 developer ~0004681	Both were accepted in the VTK coding standards. But done.

jcfr 2012-05-29 10:00 administrator ~0004682	vtkNotUsed should only be used in the cpp file. See http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Libs/vtkTeem/vtkDiffusionTensorMathematics.h?r1=20285&r2=20284&pathrev=20285

demian 2012-07-27 07:12 developer ~0005273 Last edited: 2012-07-27 09:29	fixed in review 20703 EDIT (jc): See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20703 It is convenient to add a direct link to viewvc

Date Modified	Username	Field	Change
2012-05-28 20:21	jcfr	New Issue
2012-05-28 20:21	jcfr	Assigned To	=> demian
2012-05-28 20:21	jcfr	Status	new => assigned
2012-05-28 20:21	jcfr	Target Version	=> Slicer 4.2.0 - Sept 1st 2012
2012-05-28 20:21	jcfr	Description Updated
2012-05-28 20:22	jcfr	Relationship added	related to 0002062
2012-05-29 06:21	demian	Note Added: 0004674
2012-05-29 06:21	demian	Status	assigned => resolved
2012-05-29 06:21	demian	Resolution	open => fixed
2012-05-29 07:48	jcfr	Note Added: 0004677
2012-05-29 07:48	jcfr	Status	resolved => closed
2012-05-29 07:48	jcfr	Fixed in Version	=> Slicer 4.2.0 - Sept 1st 2012
2012-05-29 07:51	jcfr	Note Added: 0004678
2012-05-29 07:51	jcfr	Status	closed => assigned
2012-05-29 07:52	jcfr	Note Edited: 0004678
2012-05-29 09:08	demian	Note Added: 0004681
2012-05-29 09:08	demian	Status	assigned => resolved
2012-05-29 10:00	jcfr	Note Added: 0004682
2012-05-29 10:00	jcfr	Status	resolved => assigned
2012-07-27 07:12	demian	Note Added: 0005273
2012-07-27 07:12	demian	Status	assigned => resolved
2012-07-27 09:29	jcfr	Note Edited: 0005273
2012-07-27 09:29	jcfr	Status	resolved => closed