View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002065 | Slicer4 | Core: MRML | public | 2012-05-16 11:38 | 2012-05-23 20:11 |
Reporter | jcfr | Assigned To | pinter | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.2.0 | Fixed in Version | Slicer 4.2.0 | ||
Summary | 0002065: Use the concept of "_data" in qMRMLNodeAttributeTableViewTest | ||||
Description | Test currently hard code the "test case", this should be probably be revised. See [1] for an example. | ||||
Tags | No tags attached. | ||||
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20092 |
|
Jc: Seems they were multiple people editing at the same time .. re-adding the note Julien: Partially implemented in 20093 See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20093 |
|
"test_remove" function has been updated, there is now a "testRemove_data" slot that could serve as example. See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20096 |
|
Fixed in http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20104 Notes (for non self-explanatory lines): |
|
Please close it if the tests pass on your OS too. |
|
The idea is to have the following methods in the test: void testPopulate(); void testSelect(); void testSetAttribute(); void testAdd(); void testRemove(); whereas currently the methods are the following: void testPopulate(); void testSelect(); void testSetAttribute(); void testAdd(); void testRemove(); |
|
I changed all the tests to use the "_data" concept in this revision: Please close if satisfactory. Thanks! |
|
Reminder sent to: finetjul Hi Julien, I think this issue could be closed. What do you think ? Thanks Jc |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-05-16 11:38 | jcfr | New Issue | |
2012-05-16 11:39 | jcfr | Assigned To | => pinter |
2012-05-16 11:39 | jcfr | Status | new => assigned |
2012-05-16 11:39 | jcfr | Target Version | => Slicer 4.2.0 AHM Summer 2012 |
2012-05-16 12:20 | jcfr | Note Added: 0004437 | |
2012-05-16 12:30 | jcfr | Note Edited: 0004437 | |
2012-05-16 12:32 | jcfr | Note Added: 0004440 | |
2012-05-16 13:33 | jcfr | Note Added: 0004443 | |
2012-05-16 13:35 | jcfr | Relationship added | parent of 0002069 |
2012-05-17 10:42 | pinter | Note Added: 0004465 | |
2012-05-17 10:45 | pinter | Note Added: 0004466 | |
2012-05-17 10:45 | pinter | Status | assigned => resolved |
2012-05-17 10:45 | pinter | Resolution | open => fixed |
2012-05-17 11:17 | jcfr | Note Added: 0004474 | |
2012-05-17 11:17 | jcfr | Status | resolved => assigned |
2012-05-22 15:02 | pinter | Note Added: 0004567 | |
2012-05-22 15:07 | jcfr | Note Added: 0004568 | |
2012-05-22 15:17 | finetjul | Status | assigned => resolved |
2012-05-22 15:17 | finetjul | Fixed in Version | => Slicer 4.2.0 - Sept 1st 2012 |
2012-05-23 20:11 | jcfr | Status | resolved => closed |