Since these two extensions are of "EXTENSION_HAS_ONLY_ONE_MODULE" style, I would recommend to use the following syntax instead:

// ---------------------------

Module name (usually identique to the directory name)

set(MODULE_NAME DoseAccumulation) # Do not use 'project()' - See SlicerConfig.cmake
set(MODULE_TITLE "Dose Accumulation")

if(NOT Slicer_SOURCE_DIR)
set(MODULE_HOMEPAGE "https://www.assembla.com/spaces/slicerrt")
set(MODULE_CATEGORY "Radiotherapy")
set(MODULE_ICONURL "http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Extensions/Testing/LoadableExtensionTemplate/Resources/Icons/LoadableExtensionTemplate.png?revision=19437&view=co")
set(MODULE_STATUS "Beta")
set(MODULE_CONTRIBUTORS "Csaba Pinter, Andras Lasso, Kevin Wang")
set(MODULE_DESCRIPTION "Accumulate dose volumes")
set(MODULE_SCREENSHOTURLS "https://www.assembla.com/spaces/slicerrt/documents/bhB--4vSSr4BSNacwqjQWU/download/bhB--4vSSr4BSNacwqjQWU?notinline=true")
set(MODULE_DEPENDS "NA") # Specified as a space separated list or 'NA' if any
endif()

then the call to "slicerMacroBuildQtModule" would be change into:

slicerMacroBuildQtModule(
NAME ${MODULE_NAME}
TITLE ${MODULE_TITLE}
[..]

I would also remove all comments that resume to be redundant with the name of the variable (I also updated the extension template to match that convention few weeks ago).

In your case, I would remove all these comments:

Module name (usually identique to the directory name)

Build module sub libraries

Additional includes - Current{source,binary} and Slicer{Libs,Base} already included

Source files

Headers that should run through moc

UI files

Additional Target libraries

Resources

I would also use the "block separator":

#-----------------------------------------------------------------------------

consistently in the two extensions.

In DoseAccumulation, the call to:

include(SlicerEnableExtensionTesting)

in not required anymore.

Make sure to use:
cmake_minimum_required(VERSION 2.8.7)

consistently in both extension

Declaring the EXTENSION_DEPENDS or MODULE_DEPENDS is now optional.

You could remove:

set(EXTENSION_DEPENDS "NA")

or

set(MODULE_DEPENDS "NA")

Thank you for the review and the comments!
I generated both modules with the python module generator, and most of the differences are due to the fact that I did these a few months apart.
I'll address these issues shortly.

In Testing/Cxx/CMakeLists.txt:

You shouldn't have to declare the macro SIMPLE_TEST. One is now included globally. See https://github.com/Slicer/Slicer/blob/master/CMake/SlicerMacroSimpleTest.cmake

In your case, it should probably be renamed into SIMPLE_TEST_WITH_DATA.

Even better, the one enclosed could be specialized for Slicer and committed into the trunk :) For now it's just a copy of the one I added in CTK [1]

[1] https://github.com/commontk/CTK/blob/master/CMake/ctkMacroSimpleTestWithData.cmake

You could consider looking at [1] for the format of "Testing/Cxx/CMakeLists.txt"

[1] https://github.com/Slicer/Slicer/blob/master/Extensions/Testing/LoadableExtensionTemplate/Testing/Cxx/CMakeLists.txt

I noticed you updated the CMakeLists.txt, this is great :)

Make sure to specify the contributors using the following syntax:

Firstname1 Lastname1 ([SubOrg1, ]Org1), Firstname2 Lastname2 ([SubOrg2, ]Org2)

For example: Jane Roe (Superware), John Doe (Lab1, Nowhere), Joe Bloggs (Noware)

This will allow us later to link contributor with their associated organization.

Thank you for your help, JC!
Now I think the CMake files in these modules are in good health :)

Few remarks still:

• contributors: see note 4398

• Comment: # Do not use 'project()' - See SlicerConfig.cmake is not in "DoseAccumulation" CMakeLists.txt

Sorry, I didn't notice your comment about the contributors. Should be OK now.

Thanks Csaba for considering my remarks and updating the CMakeLists.txt files. If you don't have any other questions, I believe the issue can be closed.

Thanks for your help!
I try and keep them conform to the latest templates from now on.