View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002006 | Slicer4 | Core: Building (CMake, Superbuild) | public | 2012-05-09 09:28 | 2014-03-06 06:09 |
Reporter | jcfr | Assigned To | pieper | ||
Priority | none | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.2.0 | Fixed in Version | Slicer 4.2.0 | ||
Summary | 0002006: Build Slicer against a recent DCMTK package | ||||
Description | The idea is to build the coming version of Slicer 4.2.0 against the latest DCMTK package. | ||||
Tags | No tags attached. | ||||
From Macro Nolden - https://github.com/commontk/CTK/issues/178: The latest DCMTK snapshot includes support for libiconv. This is automatically detected by DCMTK, but the CTK Superbuild does not link libiconv to all DCMTK-dependent targets. This results in errors like this: Undefined symbols for architecture x86_64: "_libiconv_close", referenced from: After a short discussion with the DCMTK team I think the best solution is to deactivate libiconv support for now since it's not easily detectable whether it is turned on or off. Encoding support is still supported by our ctkDICOMDataset wrapper class. |
|
OFFIS DICOM Team dicom@offis.de May 15 (3 days ago) to Andras, pieper
... and we've also "published" a new snapshot of DCMRT: http://nero.offis.de/download/dcmrt_20120515.tar.gz See dcmtk/CHANGES.361 and dcmtk/dcmrt/CHANGES files for details on what has changed since the last snapshot in February. Btw, the DCMRT library has its own COPYRIGHT file, which is stored in the "dcmrt" subdirectory. Anyway, it's licensed under the BSD license (in the same way as the DCMTK is). Regards, |
|
Would it be possible to try to build against this recent snapshot ? |
|
As discussed at project week, the plan is to make DCMTK a toplevel dependency of slicer's superbuild and pass this down to CTK and to ITKv4. Here is a topic branch that implements this: https://github.com/pieper/Slicer/tree/externalDCMTK https://github.com/pieper/Slicer/commit/716dc9496642b6b08e9308227111707d6a2e6901 I've tested the build (not install) on mac and windows and it works as expected. Right now it uses the master of dcmtk.git.rt, but we'll want to standardize on a snapshot before we merge this to slicer. |
|
From Jc - June 28 2012: Hi Steve, As soon as the following items are resolved, I guess it should be good to go: |
|
From Kent - June 29 2012: My ITK patch to add DCMTK Image I/O has a provision for USE_SYSTEM_DCMTK, that I've tested. When that gets further along I will test it in slicer. |
|
Steve, Could you consider the comments I reported and integrate into Slicer, then when we will need to test against ITKv4 it will a trivial update of External_ITKv4.cmake. Thanks |
|
From Jc - July 19 2012: Hi Kent, Do you know when your topic related to ITKv4 and DCMTK will be integrated to ITK master ? Slicer will pass the appropriate variable to ITKv4 when this one will supported DCMTK. See [1] and [2] Thanks [1] https://github.com/Slicer/Slicer/commit/b26b6c1dd8d910e96a8e58eb0d1e37a6a3ac2e8b |
|
From Kent - July 19 2012: I'm hoping to do it soon, but I have some issues to resolve, mostly with |
|
Fixed in r20654 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-05-09 09:28 | jcfr | New Issue | |
2012-05-09 09:28 | jcfr | Status | new => assigned |
2012-05-09 09:28 | jcfr | Assigned To | => jcfr |
2012-05-09 09:28 | jcfr | Assigned To | jcfr => pieper |
2012-05-09 09:47 | jcfr | Target Version | => Slicer 4.2.0 AHM Summer 2012 |
2012-05-09 12:51 | jcfr | Note Added: 0004270 | |
2012-05-09 12:52 | jcfr | Note Edited: 0004270 | |
2012-05-18 06:32 | pieper | Note Added: 0004488 | |
2012-05-18 07:43 | jcfr | Note Added: 0004492 | |
2012-06-28 09:05 | pieper | Note Added: 0004966 | |
2012-06-29 07:00 | jcfr | Note Added: 0004986 | |
2012-06-29 07:00 | jcfr | Note Added: 0004987 | |
2012-06-29 07:01 | jcfr | Note Added: 0004988 | |
2012-06-29 07:02 | jcfr | Note Edited: 0004988 | |
2012-07-19 11:03 | jcfr | Note Added: 0005206 | |
2012-07-19 11:03 | jcfr | Note Added: 0005207 | |
2012-07-25 05:55 | pieper | Note Added: 0005233 | |
2012-07-25 05:55 | pieper | Status | assigned => closed |
2012-07-25 05:55 | pieper | Resolution | open => fixed |
2014-03-06 06:09 | jcfr | Fixed in Version | => Slicer 4.2.0 |