View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001963 | Slicer4 | Core: Base Code | public | 2012-05-01 14:27 | 2012-08-21 10:01 |
Reporter | jcfr | Assigned To | jcfr | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.2.0 | Fixed in Version | Slicer 4.2.0 | ||
Summary | 0001963: Add unit test to vtkArchive zip/unzip methods | ||||
Description | After looking at the existing test for "extract_tar", it also resumes this one should also be updated. See 0001962 for details. In a nutshell, a list of extracted file should be compare against a list of expected files. | ||||
Tags | No tags attached. | ||||
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20010 |
|
Since the file expected in the archive are hardcoded in the function "valideFile", the name of the archive to extract should probably be hardcoded. Only the data directory containing the archives should be passed as a parameter, probably using the -D parameter. The verbosity of the test should be kept at his minimum, if everything works fine.. no output is expected. That said, it's still possible to pass an option for extra verbosity. I would recommend to display the error using the format: Comments like the following should be removed: The usual "function block comment separator line" should be used. File "vtkMRMLCoreTestingMacros.h" shouldn't be included here. The two cases: extract and create archive should be split into to function returning a boolean. |
|
Update the test as needed. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-05-01 14:27 | jcfr | New Issue | |
2012-05-01 14:27 | jcfr | Status | new => assigned |
2012-05-01 14:27 | jcfr | Assigned To | => finetjul |
2012-05-01 14:27 | jcfr | Assigned To | finetjul => pieper |
2012-05-18 06:37 | pieper | Note Added: 0004489 | |
2012-05-18 06:37 | pieper | Status | assigned => resolved |
2012-05-18 06:37 | pieper | Resolution | open => fixed |
2012-05-18 07:55 | jcfr | Note Added: 0004493 | |
2012-05-18 07:56 | jcfr | Status | resolved => assigned |
2012-07-30 04:37 | pieper | Note Added: 0005443 | |
2012-07-30 04:37 | pieper | Assigned To | pieper => jcfr |
2012-07-30 04:37 | pieper | Status | assigned => closed |
2012-08-21 10:01 | jcfr | Fixed in Version | => Slicer 4.2.0 - Feature freeze Sept 1st 2012 |
2012-08-21 10:01 | jcfr | Target Version | => Slicer 4.2.0 - Feature freeze Sept 1st 2012 |