View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001940Slicer4Core: Packagingpublic2012-04-25 11:492012-06-04 09:09
Reporterfinetjul Assigned Tojcfr  
PrioritynormalSeveritytextReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionSlicer 4.1.0 
Target VersionSlicer 4.1.1Fixed in VersionSlicer 4.1.1 
Summary0001940: No version in mac bundle
Description

When looking at the details in finder of a downloaded official package of slicer on mac (e.g. 4.1), the meta data field version is not set.
Should probably passed in some way to CPack when doing the package.

TagsNo tags attached.

Activities

jcfr

jcfr

2012-04-26 06:31

administrator   ~0004084

See https://github.com/Slicer/Slicer/commit/e1bd3691f53c0b4945b6df4ad852baebce0e9753
finetjul

finetjul

2012-05-24 18:46

administrator   ~0004603

Tried in Slicer 2012-05-21 but no version mentioned. (see screenshot)

2012-05-24 18:47

 

Screen Shot 2012-05-24 at 10.44.45 PM.png (87,275 bytes)
jcfr

jcfr

2012-05-25 12:42

administrator   ~0004620

Could you provide me with the content of "plist" file ?
jcfr

jcfr

2012-05-28 22:05

administrator   ~0004662

r19946 - I fixed the problem - See https://github.com/Slicer/Slicer/commit/e1bd3691f53c0b4945b6df4ad852baebce0e9753

r19957 - This commit removed the fix previously introduced - See https://github.com/Slicer/Slicer/commit/2fdcd91f7802b84928417d5b7ed9f2df7c913d55#diff-0

I guess this could have happen while incorrectly resolving some merge conflict ... or something along the line.
jcfr

jcfr

2012-05-28 22:14

administrator   ~0004663

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20282
jcfr

jcfr

2012-05-28 22:21

administrator   ~0004664

Backported to 4.1.1 - http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20283
finetjul

finetjul

2012-06-04 09:09

administrator   ~0004761

Maybe the version shouldn't be set for the nightlies.
It's odd to see 4.1.0 when downloading a nightly package. It might be taken as the official 4.1.0 build. Could it be 4.1.0-r20282 ?

Issue History

Date Modified Username Field Change
2012-04-25 11:49 finetjul New Issue
2012-04-25 11:49 finetjul Status new => assigned
2012-04-25 11:49 finetjul Assigned To => jcfr
2012-04-25 11:49 finetjul Severity minor => text
2012-04-25 11:49 finetjul Product Version => Slicer 4.1.0
2012-04-26 06:31 jcfr Note Added: 0004084
2012-04-26 06:31 jcfr Status assigned => resolved
2012-04-26 06:31 jcfr Fixed in Version => Slicer 4.x AHM Summer 2012
2012-04-26 06:31 jcfr Resolution open => fixed
2012-05-08 15:09 jcfr Target Version => Slicer 4.1.1
2012-05-24 18:46 finetjul Note Added: 0004603
2012-05-24 18:46 finetjul Status resolved => assigned
2012-05-24 18:47 finetjul File Added: Screen Shot 2012-05-24 at 10.44.45 PM.png
2012-05-25 12:42 jcfr Note Added: 0004620
2012-05-28 22:05 jcfr Note Added: 0004662
2012-05-28 22:14 jcfr Note Added: 0004663
2012-05-28 22:14 jcfr Status assigned => resolved
2012-05-28 22:14 jcfr Fixed in Version Slicer 4.2.0 - Sept 1st 2012 => Slicer 4.1.1 - June 1st 2012
2012-05-28 22:21 jcfr Note Added: 0004664
2012-06-04 09:07 finetjul Status resolved => closed
2012-06-04 09:09 finetjul Note Added: 0004761